Skip to content

Commit 38187a6

Browse files
author
Dongwei Wang
committed
Remove rename parameter set
1 parent 9acffc1 commit 38187a6

File tree

2 files changed

+5
-59
lines changed

2 files changed

+5
-59
lines changed

src/Synapse/Synapse/Commands/DataPlaneCommands/Artifact/SparkJobDefinitions/SetAzureSynapseSparkJobDefinition.cs

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,15 @@ public class SetAzureSynapseSparkJobDefinition : SynapseArtifactsCmdletBase
1717
{
1818
private const string SetByName = "SetByName";
1919
private const string SetByObject = "SetByObject";
20-
private const string RenameByName = "RenameByName";
21-
private const string RenameByObject = "RenameByObject";
2220

2321
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = SetByName,
2422
Mandatory = true, HelpMessage = HelpMessages.WorkspaceName)]
25-
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = RenameByName,
26-
Mandatory = true, HelpMessage = HelpMessages.WorkspaceName)]
2723
[ResourceNameCompleter(ResourceTypes.Workspace, "ResourceGroupName")]
2824
[ValidateNotNullOrEmpty]
2925
public override string WorkspaceName { get; set; }
3026

3127
[Parameter(ValueFromPipeline = true, ParameterSetName = SetByObject,
3228
Mandatory = true, HelpMessage = HelpMessages.WorkspaceObject)]
33-
[Parameter(ValueFromPipeline = true, ParameterSetName = RenameByObject,
34-
Mandatory = true, HelpMessage = HelpMessages.WorkspaceObject)]
3529
[ValidateNotNull]
3630
public PSSynapseWorkspace WorkspaceObject { get; set; }
3731

@@ -40,13 +34,6 @@ public class SetAzureSynapseSparkJobDefinition : SynapseArtifactsCmdletBase
4034
[Alias("SparkJobDefinitionName")]
4135
public string Name { get; set; }
4236

43-
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = RenameByName,
44-
Mandatory = true, HelpMessage = HelpMessages.SparkJobDefinitionName)]
45-
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = RenameByObject,
46-
Mandatory = true, HelpMessage = HelpMessages.SparkJobDefinitionName)]
47-
[ValidateNotNullOrEmpty]
48-
public string NewName { get; set; }
49-
5037
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = SetByObject, Mandatory = true, HelpMessage = HelpMessages.JsonFilePath)]
5138
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = SetByName, Mandatory = true, HelpMessage = HelpMessages.JsonFilePath)]
5239
[ValidateNotNullOrEmpty]
@@ -65,22 +52,8 @@ public override void ExecuteCmdlet()
6552

6653
if (this.ShouldProcess(this.WorkspaceName, String.Format(Resources.SettingSynapseSparkJobDefinition, this.Name, this.WorkspaceName)))
6754
{
68-
switch (ParameterSetName)
69-
{
70-
case SetByName:
71-
case SetByObject:
72-
string rawJsonContent = SynapseAnalyticsClient.ReadJsonFileContent(this.TryResolvePath(DefinitionFile));
73-
WriteObject(new PSSparkJobDefinitionResource(SynapseAnalyticsClient.CreateOrUpdateSparkJobDefinition(this.Name, rawJsonContent)));
74-
break;
75-
76-
case RenameByName:
77-
case RenameByObject:
78-
SynapseAnalyticsClient.RenameSparkJobDefinition(this.Name, this.NewName);
79-
WriteObject(new PSSparkJobDefinitionResource(SynapseAnalyticsClient.GetSparkJobDefinition(this.NewName)));
80-
break;
81-
82-
default: throw new AzPSInvalidOperationException(string.Format(Resources.InvalidParameterSet, this.ParameterSetName));
83-
}
55+
string rawJsonContent = SynapseAnalyticsClient.ReadJsonFileContent(this.TryResolvePath(DefinitionFile));
56+
WriteObject(new PSSparkJobDefinitionResource(SynapseAnalyticsClient.CreateOrUpdateSparkJobDefinition(this.Name, rawJsonContent)));
8457
}
8558
}
8659
}

src/Synapse/Synapse/help/Set-AzSynapseSparkJobDefinition.md

Lines changed: 3 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -18,24 +18,12 @@ Set-AzSynapseSparkJobDefinition -WorkspaceName <String> -Name <String> -Definiti
1818
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
1919
```
2020

21-
### RenameByName
22-
```
23-
Set-AzSynapseSparkJobDefinition -WorkspaceName <String> -Name <String> -NewName <String> [-AsJob]
24-
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
25-
```
26-
2721
### SetByObject
2822
```
2923
Set-AzSynapseSparkJobDefinition -WorkspaceObject <PSSynapseWorkspace> -Name <String> -DefinitionFile <String>
3024
[-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
3125
```
3226

33-
### RenameByObject
34-
```
35-
Set-AzSynapseSparkJobDefinition -WorkspaceObject <PSSynapseWorkspace> -Name <String> -NewName <String> [-AsJob]
36-
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
37-
```
38-
3927
## DESCRIPTION
4028
The **Set-AzSynapseSparkJobDefinition** cmdlet creates a Spark job definition in workspace.
4129

@@ -95,7 +83,7 @@ The JSON file path.
9583
9684
```yaml
9785
Type: System.String
98-
Parameter Sets: SetByName, SetByObject
86+
Parameter Sets: (All)
9987
Aliases: File
10088

10189
Required: True
@@ -120,27 +108,12 @@ Accept pipeline input: False
120108
Accept wildcard characters: False
121109
```
122110
123-
### -NewName
124-
The Spark job definition name.
125-
126-
```yaml
127-
Type: System.String
128-
Parameter Sets: RenameByName, RenameByObject
129-
Aliases:
130-
131-
Required: True
132-
Position: Named
133-
Default value: None
134-
Accept pipeline input: False
135-
Accept wildcard characters: False
136-
```
137-
138111
### -WorkspaceName
139112
Name of Synapse workspace.
140113
141114
```yaml
142115
Type: System.String
143-
Parameter Sets: SetByName, RenameByName
116+
Parameter Sets: SetByName
144117
Aliases:
145118

146119
Required: True
@@ -155,7 +128,7 @@ workspace input object, usually passed through the pipeline.
155128
156129
```yaml
157130
Type: Microsoft.Azure.Commands.Synapse.Models.PSSynapseWorkspace
158-
Parameter Sets: SetByObject, RenameByObject
131+
Parameter Sets: SetByObject
159132
Aliases:
160133

161134
Required: True

0 commit comments

Comments
 (0)