Addressed Review -- Renamed methods, reverted version

Author: cle5eland

src/ResourceManager/IotCentral/Commands.IotCentral/Az.IotCentral.psd1

@@ -12,7 +12,7 @@
 # RootModule = ''
 
 # Version number of this module.
-ModuleVersion = '0.1.1'
+ModuleVersion = '0.1.0'
 
 # Supported PSEditions
 CompatiblePSEditions = 'Core', 'Desktop'

src/ResourceManager/IotCentral/Commands.IotCentral/AzureRM.IotCentral.psd1

@@ -12,7 +12,7 @@
 # RootModule = ''
 
 # Version number of this module.
-ModuleVersion = '1.0.1'
+ModuleVersion = '1.0.0'
 
 # Supported PSEditions
 # CompatiblePSEditions = @()

src/ResourceManager/IotCentral/Commands.IotCentral/ChangeLog.md

@@ -21,7 +21,3 @@
 * Preview Release
 * Added Tabular Output Format
 * Added Subdomain Checking in New-AzureRmIotCentralApp
-
-## 2018.11.06 - Version 1.0.0
-* Preview Release
-* Initial Module Prerelease

src/ResourceManager/IotCentral/Commands.IotCentral/Common/IotCentralBaseCmdlet.cs

@@ -32,6 +32,8 @@ public abstract class IotCentralBaseCmdlet : AzureRMCmdlet
         protected const string ResourceIdParameterSet = "ResourceIdParameterSet";
         protected const string InputObjectParameterSet = "InputObjectParameterSet";
 
+        protected const string resourceType = "IoTApps";
+
         [Parameter(
             Mandatory = true,
             Position = 0,

src/ResourceManager/IotCentral/Commands.IotCentral/IotCentral/NewAzureRmIotCentralApp.cs

@@ -83,8 +83,8 @@ public override void ExecuteCmdlet()
         {
             if (ShouldProcess(Name, ResourceProperties.Resources.NewIotCentralApp))
             {
-                this.CheckNameAvailability();
-                this.CheckSubdomainAvailability();
+                this.EnsureNameAvailabilityOrThrow();
+                this.EnsureSubdomainAvailabilityOrThrow();
 
                 var iotCentralApp = new App()
                 {
@@ -103,23 +103,23 @@ public override void ExecuteCmdlet()
 
         }
 
-        private void CheckNameAvailability()
+        private void EnsureNameAvailabilityOrThrow()
         {
-            var checkNameInputs = new OperationInputs(this.Name, "IoTApps");
+            var checkNameInputs = new OperationInputs(this.Name, resourceType);
             var nameAvailabilityInfo = this.IotCentralClient.Apps.CheckNameAvailability(checkNameInputs);
-            this.CheckAvailability(nameAvailabilityInfo);
+            this.EnsureAvailabilityOrThrow(nameAvailabilityInfo);
         }
 
-        private void CheckSubdomainAvailability()
+        private void EnsureSubdomainAvailabilityOrThrow()
         {
-            var checkSubdomainInputs = new OperationInputs(this.Subdomain, "IoTApps");
+            var checkSubdomainInputs = new OperationInputs(this.Subdomain, resourceType);
             var subdomainAvailabilityInfo = this.IotCentralClient.Apps.CheckSubdomainAvailability(checkSubdomainInputs);
-            this.CheckAvailability(subdomainAvailabilityInfo);
+            this.EnsureAvailabilityOrThrow(subdomainAvailabilityInfo);
         }
 
-        private void CheckAvailability(AppAvailabilityInfo availabilityInfo)
+        private void EnsureAvailabilityOrThrow(AppAvailabilityInfo availabilityInfo)
         {
-            if (!(availabilityInfo.NameAvailable == true))
+            if (availabilityInfo.NameAvailable != true)
             {
                 throw new PSArgumentException(availabilityInfo.Message);
             }