Addressed PR feedback

Author: anton-evseev

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/Generated/ApplicationSecurityGroupTestsGenerated.ps1

@@ -46,7 +46,7 @@ function Test-ApplicationSecurityGroupCRUDMinimalParameters
     $rgname = Get-ResourceGroupName;
     $rglocation = Get-ProviderLocation ResourceManagement;
     $rname = Get-ResourceName;
-    $location = "westcentralus";
+    $location = Get-ProviderLocation "Microsoft.Network/ApplicationSecurityGroups";
 
     try
     {
@@ -67,6 +67,9 @@ function Test-ApplicationSecurityGroupCRUDMinimalParameters
         # Remove ApplicationSecurityGroup
         $removeApplicationSecurityGroup = Remove-AzureRmApplicationSecurityGroup -ResourceGroupName $rgname -Name $rname -PassThru -Force;
         Assert-AreEqual $true $removeApplicationSecurityGroup;
+
+        # Get ApplicationSecurityGroup should fail
+        Assert-ThrowsContains { Get-AzureRmApplicationSecurityGroup -ResourceGroupName $rgname -Name $rname } "${rname} not found";
     }
     finally
     {
@@ -85,7 +88,7 @@ function Test-ApplicationSecurityGroupCRUDAllParameters
     $rgname = Get-ResourceGroupName;
     $rglocation = Get-ProviderLocation ResourceManagement;
     $rname = Get-ResourceName;
-    $location = "westcentralus";
+    $location = Get-ProviderLocation "Microsoft.Network/ApplicationSecurityGroups";
     # Resource's parameters
     $Tag = @{tag1='test'};
 
@@ -110,6 +113,9 @@ function Test-ApplicationSecurityGroupCRUDAllParameters
         # Remove ApplicationSecurityGroup
         $removeApplicationSecurityGroup = Remove-AzureRmApplicationSecurityGroup -ResourceGroupName $rgname -Name $rname -PassThru -Force;
         Assert-AreEqual $true $removeApplicationSecurityGroup;
+
+        # Get ApplicationSecurityGroup should fail
+        Assert-ThrowsContains { Get-AzureRmApplicationSecurityGroup -ResourceGroupName $rgname -Name $rname } "${rname} not found";
     }
     finally
     {

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/Generated/RouteTableTestsGenerated.ps1

@@ -75,6 +75,9 @@ function Test-RouteTableCRUDMinimalParameters
         # Remove RouteTable
         $removeRouteTable = Remove-AzureRmRouteTable -ResourceGroupName $rgname -Name $rname -PassThru -Force;
         Assert-AreEqual $true $removeRouteTable;
+
+        # Get RouteTable should fail
+        Assert-ThrowsContains { Get-AzureRmRouteTable -ResourceGroupName $rgname -Name $rname } "${rname} not found";
     }
     finally
     {
@@ -143,6 +146,9 @@ function Test-RouteTableCRUDAllParameters
         # Remove RouteTable
         $removeRouteTable = Remove-AzureRmRouteTable -ResourceGroupName $rgname -Name $rname -PassThru -Force;
         Assert-AreEqual $true $removeRouteTable;
+
+        # Get RouteTable should fail
+        Assert-ThrowsContains { Get-AzureRmRouteTable -ResourceGroupName $rgname -Name $rname } "${rname} not found";
     }
     finally
     {
@@ -215,8 +221,11 @@ function Test-RouteCRUDMinimalParameters
         Assert-AreEqual $AddressPrefixAdd $vRoute.AddressPrefix;
 
         # Remove Route
-        Remove-AzureRmRouteConfig -RouteTable $vRouteTable -Name $vRouteTable.Routes[-1].Name;
+        Remove-AzureRmRouteConfig -RouteTable $vRouteTable -Name $rnameAdd;
         $vRouteTable = Set-AzureRmRouteTable -RouteTable $vRouteTable;
+
+        # Get Route should fail
+        Assert-ThrowsContains { Get-AzureRmRouteConfig -RouteTable $vRouteTable -Name $rnameAdd } "Sequence contains no matching element";
     }
     finally
     {
@@ -296,8 +305,11 @@ function Test-RouteCRUDAllParameters
         Assert-AreEqual $NextHopTypeAdd $vRoute.NextHopType;
 
         # Remove Route
-        Remove-AzureRmRouteConfig -RouteTable $vRouteTable -Name $vRouteTable.Routes[-1].Name;
+        Remove-AzureRmRouteConfig -RouteTable $vRouteTable -Name $rnameAdd;
         $vRouteTable = Set-AzureRmRouteTable -RouteTable $vRouteTable;
+
+        # Get Route should fail
+        Assert-ThrowsContains { Get-AzureRmRouteConfig -RouteTable $vRouteTable -Name $rnameAdd } "Sequence contains no matching element";
     }
     finally
     {

src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.ApplicationSecurityGroupTestsGenerated/TestApplicationSecurityGroupCRUDAllParameters.json

@@ -7,15 +7,15 @@
       "RequestBody": "",
       "RequestHeaders": {
         "x-ms-client-request-id": [
-          "27840b46-6a74-455e-8019-9c7b3f2f34e7"
+          "c0334623-627b-4192-8b6d-844b8f950ec9"
         ],
         "accept-language": [
           "en-US"
         ],
         "User-Agent": [
-          "FxVersion/4.7.2633.0",
+          "FxVersion/4.7.3131.0",
           "OSName/Windows10Enterprise",
-          "OSVersion/6.3.16299",
+          "OSVersion/6.3.17134",
           "Microsoft.Azure.Management.Network.NetworkManagementClient/19.1.0.0"
         ]
       },
@@ -34,10 +34,10 @@
           "no-cache"
         ],
         "x-ms-request-id": [
-          "1f205b7a-3257-4c2a-a3c8-e1c6ac753233"
+          "49822452-e103-4688-bfbe-95f3aefb3f6a"
         ],
         "x-ms-correlation-request-id": [
-          "ac462f22-893d-4f06-a62c-a6f00be687c4"
+          "a4dcbd8b-7e03-4b9c-ba53-5a2ae840a75e"
         ],
         "Strict-Transport-Security": [
           "max-age=31536000; includeSubDomains"
@@ -50,24 +50,24 @@
           "Microsoft-HTTPAPI/2.0"
         ],
         "x-ms-ratelimit-remaining-subscription-reads": [
-          "14999"
+          "14981"
         ],
         "x-ms-routing-request-id": [
-          "FRANCECENTRAL:20180725T124245Z:ac462f22-893d-4f06-a62c-a6f00be687c4"
+          "UKSOUTH2:20180801T111430Z:a4dcbd8b-7e03-4b9c-ba53-5a2ae840a75e"
         ],
         "X-Content-Type-Options": [
           "nosniff"
         ],
         "Date": [
-          "Wed, 25 Jul 2018 12:42:44 GMT"
+          "Wed, 01 Aug 2018 11:14:29 GMT"
         ]
       },
       "StatusCode": 200
     }
   ],
   "Names": {
     "Test-UsageCRUDMinimalParameters": [
-      "ps4962"
+      "ps5054"
     ]
   },
   "Variables": {

src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.ApplicationSecurityGroupTestsGenerated/TestApplicationSecurityGroupCRUDMinimalParameters.json

@@ -38,7 +38,7 @@
 
 namespace Microsoft.Azure.Commands.Network
 {
-    [Cmdlet(VerbsCommon.Get, "AzureRmNetworkUsage"), OutputType(typeof(List<PSUsage>))]
+    [Cmdlet(VerbsCommon.Get, "AzureRmNetworkUsage"), OutputType(typeof(PSUsage))]
     public partial class GetAzureRmNetworkUsage : NetworkBaseCmdlet
     {
         [Parameter(

src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.RouteTableTestsGenerated/TestRouteCRUDAllParameters.json

@@ -32,7 +32,9 @@ This command deletes an application security group named MyApplicationSecurityGr
 ## PARAMETERS
 
 ### -AsJob
-Run cmdlet in the background```yaml
+Run cmdlet in the background
+
+```yaml
 Type: System.Management.Automation.SwitchParameter
 Parameter Sets: (All)
 Aliases:

src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.RouteTableTestsGenerated/TestRouteCRUDMinimalParameters.json

@@ -24,4 +24,3 @@
 "Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureVirtualNetworkGatewayBGPPeerStatus","Get-AzureRmVirtualNetworkGatewayBGPPeerStatus","0","1020","The cmdlet 'Get-AzureRmVirtualNetworkGatewayBGPPeerStatus' no longer has output type 'Microsoft.Azure.Commands.Network.Models.PSBGPPeerStatus[]'.","Make cmdlet 'Get-AzureRmVirtualNetworkGatewayBGPPeerStatus' return type 'Microsoft.Azure.Commands.Network.Models.PSBGPPeerStatus[]'."
 "Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetVirtualNetworkGatewayLearnedRouteCommand","Get-AzureRmVirtualNetworkGatewayLearnedRoute","0","1020","The cmdlet 'Get-AzureRmVirtualNetworkGatewayLearnedRoute' no longer has output type 'Microsoft.Azure.Commands.Network.Models.PSGatewayRoute[]'.","Make cmdlet 'Get-AzureRmVirtualNetworkGatewayLearnedRoute' return type 'Microsoft.Azure.Commands.Network.Models.PSGatewayRoute[]'."
 "Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.NewAzureRmRouteTable","New-AzureRmRouteTable","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Location' for cmdlet 'New-AzureRmRouteTable'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Location'."
-"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.Automation.GetAzureRmNetworkUsage","Get-AzureRmNetworkUsage","0","1020","The cmdlet 'Get-AzureRmNetworkUsage' no longer has output type 'Microsoft.Azure.Commands.Network.Models.PSUsage'.","Make cmdlet 'Get-AzureRmNetworkUsage' return type 'Microsoft.Azure.Commands.Network.Models.PSUsage'."