Address review comments

Author: solankisamir

src/ResourceManager/ApiManagement/AzureRM.ApiManagement.psd1

@@ -141,10 +141,10 @@ CmdletsToExport = 'Add-AzureRmApiManagementRegion',
                'Set-AzureRmApiManagementSubscription', 
                'Set-AzureRmApiManagementUser', 
                'Set-AzureRmApiManagementTenantAccess',
-	           'Get-AzureRmApiManagementIdentityProvider',
-	           'New-AzureRmApiManagementIdentityProvider',
-	           'Set-AzureRmApiManagementIdentityProvider',
-	           'Remove-AzureRmApiManagementIdentityProvider'
+               'Get-AzureRmApiManagementIdentityProvider',
+               'New-AzureRmApiManagementIdentityProvider',
+               'Set-AzureRmApiManagementIdentityProvider',
+               'Remove-AzureRmApiManagementIdentityProvider'
 
 # Variables to export from this module
 # VariablesToExport = @()

src/ResourceManager/ApiManagement/Commands.ApiManagement.ServiceManagement/Commands/GetAzureApiManagementIdentityProvider.cs

@@ -19,13 +19,13 @@ namespace Microsoft.Azure.Commands.ApiManagement.ServiceManagement.Commands
     using System.Collections.Generic;
     using System.Management.Automation;
 
-    [Cmdlet(VerbsCommon.Get, Constants.ApiManagementIdentityProvider, DefaultParameterSetName = GetAll)]
-    [OutputType(typeof(IList<PsApiManagementIdentityProvider>), ParameterSetName = new[] { GetAll })]
-    [OutputType(typeof(PsApiManagementIdentityProvider), ParameterSetName = new[] { GetByType })]
+    [Cmdlet(VerbsCommon.Get, Constants.ApiManagementIdentityProvider, DefaultParameterSetName = AllIdentityProviders)]
+    [OutputType(typeof(IList<PsApiManagementIdentityProvider>), ParameterSetName = new[] { AllIdentityProviders })]
+    [OutputType(typeof(PsApiManagementIdentityProvider), ParameterSetName = new[] { IdentityProviderByType })]
     public class GetAzureApiManagementIdentityProvider : AzureApiManagementCmdletBase
     {
-        private const string GetAll = "Get all identity Providers";
-        private const string GetByType = "Get by identity provider type";
+        private const string AllIdentityProviders = "AllIdentityProviders";
+        private const string IdentityProviderByType = "IdentityProviderByType";
 
         [Parameter(
             ValueFromPipelineByPropertyName = true,
@@ -35,20 +35,20 @@ public class GetAzureApiManagementIdentityProvider : AzureApiManagementCmdletBas
         public PsApiManagementContext Context { get; set; }
 
         [Parameter(
-            ParameterSetName = GetByType,
+            ParameterSetName = IdentityProviderByType,
             ValueFromPipelineByPropertyName = true,
-            Mandatory = false,
+            Mandatory = true,
             HelpMessage = "Identifier of a Identity Provider. If specified will try to find identity provider configuration by the identifier. This parameter is optional.")]
         public PsApiManagementIdentityProviderType Type { get; set; }
 
         public override void ExecuteApiManagementCmdlet()
         {
-            if (ParameterSetName.Equals(GetAll))
+            if (ParameterSetName.Equals(AllIdentityProviders))
             {
                 var identityProviders = Client.IdentityProviderList(Context);
                 WriteObject(identityProviders, true);
             }
-            else if (ParameterSetName.Equals(GetByType))
+            else if (ParameterSetName.Equals(IdentityProviderByType))
             {
                 var identityProvider = Client.IdentityProviderByName(Context, Type.ToString("g"));
                 WriteObject(identityProvider);

src/ResourceManager/ApiManagement/Commands.ApiManagement.ServiceManagement/Commands/GetAzureApiManagementLogger.cs

@@ -37,7 +37,7 @@ public class GetAzureApiManagementLogger : AzureApiManagementCmdletBase
         [Parameter(
             ParameterSetName = GetById,
             ValueFromPipelineByPropertyName = true,
-            Mandatory = false,
+            Mandatory = true,
             HelpMessage = "Identifier of a logger. If specified will try to find logger by the identifier. This parameter is optional.")]
         public String LoggerId { get; set; }
 

src/ResourceManager/ApiManagement/Commands.ApiManagement.ServiceManagement/Commands/RemoveAzureApiManagementIdentityProvider.cs

@@ -50,19 +50,17 @@ public override void ExecuteApiManagementCmdlet()
             var actionWarning = string.Format(CultureInfo.CurrentCulture, Resources.IdentityProviderRemoveWarning, Type.ToString("g"));
 
             // Do nothing if force is not specified and user cancelled the operation
-            if (!ShouldProcess(
+            if (ShouldProcess(
                     actionDescription,
                     actionWarning,
                     Resources.ShouldProcessCaption))
             {
-                return;
-            }
-
-            Client.IdentityProviderRemove(Context, Type.ToString("g"));
+                Client.IdentityProviderRemove(Context, Type.ToString("g"));
 
-            if (PassThru.IsPresent)
-            {
-                WriteObject(true);
+                if (PassThru.IsPresent)
+                {
+                    WriteObject(true);
+                }
             }
         }
     }

src/ResourceManager/ApiManagement/Commands.SMAPI.Test/ScenarioTests/ApiManagementTests.ps1

@@ -312,24 +312,24 @@ Param($resourceGroupName, $serviceName)
 
     $context = New-AzureRmApiManagementContext -ResourceGroupName $resourceGroupName -ServiceName $serviceName
 
-	$wsdlUrl = "http://www.webservicex.net/stockquote.asmx?WSDL"
+	$wsdlPath1 = "./Resources/Weather.wsdl"
 	$path1 = "soapToRestApi"
 	$wsdlApiId1 = getAssetName	
-	$wsdlServiceName2 = "StockQuote" # from Url StockQuote
-	$wsdlEndpointName2 = "StockQuoteSoap" # from Url StockQuote
+	$wsdlServiceName1 = "Weather" # from file Weather.wsdl
+	$wsdlEndpointName1 = "WeatherSoap" # from file Weather.wsdl
 
     try
     {		 
 		 # import api from Url
-        $api = Import-AzureRmApiManagementApi -Context $context -ApiId $wsdlApiId1 -SpecificationUrl $wsdlUrl -SpecificationFormat Wsdl -Path $path1 -WsdlServiceName $wsdlServiceName2 -WsdlEndpointName $wsdlEndpointName2 -ApiType Soap
+        $api = Import-AzureRmApiManagementApi -Context $context -ApiId $wsdlApiId1 -SpecificationPath $wsdlPath1 -SpecificationFormat Wsdl -Path $path1 -WsdlServiceName $wsdlServiceName1 -WsdlEndpointName $wsdlEndpointName1 -ApiType Soap
 
         Assert-AreEqual $wsdlApiId1 $api.ApiId
         Assert-AreEqual $path1 $api.Path
 
 		 # export api to pipeline
         $result = Export-AzureRmApiManagementApi -Context $context -ApiId $wsdlApiId1 -SpecificationFormat Wsdl
 		Assert-NotNull $result
-		Assert-True {$result -like '*<wsdl:service name="StockQuote"*'}
+		Assert-True {$result -like '*<wsdl:service name="Weather"*'}
     }
     finally
     {