Merge pull request #17 from hovsepm/NoWarning

Hovsep · Hovsep · commit 42807ee4406e · 2014-12-03T10:33:34.000-08:00
Fixing build warnings (reduced to 74) (3115319)
diff --git a/src/Common/Commands.Common/Common/ServiceManagementTypes.cs b/src/Common/Commands.Common/Common/ServiceManagementTypes.cs
@@ -5258,7 +5258,7 @@ public string PrivateConfigurationSchema
         public string CompanyName { get; set; }
 
         #region IExtensibleDataObject Members
-        ExtensionDataObject IExtensibleDataObject.ExtensionData { get; set; }
+        public ExtensionDataObject ExtensionData { get; set; }
         #endregion
     }
 
diff --git a/src/ResourceManager/DataFactories/Commands.DataFactories/ProvisioningFailedException.cs b/src/ResourceManager/DataFactories/Commands.DataFactories/ProvisioningFailedException.cs
@@ -16,6 +16,7 @@
 
 namespace Microsoft.Azure.Commands.DataFactories
 {
+    [Serializable]
     internal class ProvisioningFailedException : Exception
     {
         public ProvisioningFailedException(string errorMessage)
diff --git a/src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/ResourcesController.cs b/src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/ResourcesController.cs
@@ -31,8 +31,8 @@ public sealed class ResourcesController
     {
         private CSMTestEnvironmentFactory csmTestFactory;
         private EnvironmentSetupHelper helper;
-        protected const string TenantIdKey = "TenantId";
-        protected const string DomainKey = "Domain";
+        private const string TenantIdKey = "TenantId";
+        private const string DomainKey = "Domain";
 
         public GraphRbacManagementClient GraphClient { get; private set; }
 
diff --git a/src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/DSC/DscSettingsSerializer.cs b/src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/DSC/DscSettingsSerializer.cs
@@ -68,9 +68,9 @@ public static DscPublicSettings DeserializePublicSettings(string publicSettingsS
                         JsonConvert.DeserializeObject<DscPublicSettings.Version1>(publicSettingsString);
                     publicSettings = publicSettingsV1.ToCurrentVersion();
                 }
-                catch (JsonException e)
+                catch (JsonException)
                 {
-                    throw e;
+                    throw;
                 } 
             }
             return publicSettings;
diff --git a/src/ServiceManagement/HDInsight/Commands.HDInsight.Test/Models/Simulators/AzureHDInsightJobSubmissionClientSimulator.cs b/src/ServiceManagement/HDInsight/Commands.HDInsight.Test/Models/Simulators/AzureHDInsightJobSubmissionClientSimulator.cs
@@ -54,7 +54,7 @@ public AzureHDInsightJobSubmissionClientSimulator(
             this.InitializeSimulator();
         }
 
-        public void Dispose()
+        public new void Dispose()
         {
         }
 
@@ -65,17 +65,17 @@ public string GetCustomUserAgent()
             throw new NotImplementedException();
         }
 
-        public void AddLogWriter(ILogWriter logWriter)
+        public new void AddLogWriter(ILogWriter logWriter)
         {
             this.logger.AddWriter(logWriter);
         }
 
-        public void RemoveLogWriter(ILogWriter logWriter)
+        public new void RemoveLogWriter(ILogWriter logWriter)
         {
             this.logger.RemoveWriter(logWriter);
         }
 
-        public void Cancel()
+        public new void Cancel()
         {
         }
 
@@ -329,12 +329,12 @@ public Task<JobList> ListJobsAsync()
             return TaskEx2.FromResult(jobDetailList);
         }
 
-        public void SetCancellationSource(CancellationTokenSource tokenSource)
+        public new void SetCancellationSource(CancellationTokenSource tokenSource)
         {
             this.cancellationTokenSource = tokenSource;
         }
 
-        public bool IgnoreSslErrors { get; set; }
+        public new bool IgnoreSslErrors { get; set; }
 
         public JobDetails StopJob(string jobId)
         {
@@ -537,6 +537,6 @@ private void WriteJobOutput(string jobId, string statusDirectory, string stdoutC
             this.jobOutput[jobId] = stdoutContent;
         }
 
-        public ILogger Logger { get; private set; }
+        public new ILogger Logger { get; private set; }
     }
 }
diff --git a/src/ServiceManagement/Services/Commands.Test/Commands.Test.csproj b/src/ServiceManagement/Services/Commands.Test/Commands.Test.csproj
@@ -78,11 +78,11 @@
     </Reference>
     <Reference Include="Microsoft.WindowsAzure.Common, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
       <SpecificVersion>False</SpecificVersion>
-      <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Common.1.4.0\lib\net45\Microsoft.WindowsAzure.Common.dll</HintPath>
+      <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Common.1.4.1\lib\net45\Microsoft.WindowsAzure.Common.dll</HintPath>
     </Reference>
     <Reference Include="Microsoft.WindowsAzure.Common.NetFramework, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
       <SpecificVersion>False</SpecificVersion>
-      <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Common.1.4.0\lib\net45\Microsoft.WindowsAzure.Common.NetFramework.dll</HintPath>
+      <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Common.1.4.1\lib\net45\Microsoft.WindowsAzure.Common.NetFramework.dll</HintPath>
     </Reference>
     <Reference Include="Microsoft.WindowsAzure.Configuration, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
       <HintPath>..\..\..\packages\Microsoft.WindowsAzure.ConfigurationManager.2.0.3\lib\net40\Microsoft.WindowsAzure.Configuration.dll</HintPath>
@@ -97,7 +97,7 @@
     </Reference>
     <Reference Include="Microsoft.WindowsAzure.Management.ExpressRoute, Version=0.9.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
       <SpecificVersion>False</SpecificVersion>
-      <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.ExpressRoute.0.11.2-preview\lib\net40\Microsoft.WindowsAzure.Management.ExpressRoute.dll</HintPath>
+      <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.ExpressRoute.0.16.2-preview\lib\net40\Microsoft.WindowsAzure.Management.ExpressRoute.dll</HintPath>
     </Reference>
     <Reference Include="Microsoft.WindowsAzure.Management.MediaServices">
       <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.MediaServices.1.2.0\lib\net40\Microsoft.WindowsAzure.Management.MediaServices.dll</HintPath>
diff --git a/src/ServiceManagement/Services/Commands.Test/packages.config b/src/ServiceManagement/Services/Commands.Test/packages.config
@@ -7,12 +7,12 @@
   <package id="Microsoft.Data.OData" version="5.6.0" targetFramework="net45" />
   <package id="Microsoft.Data.Services.Client" version="5.6.0" targetFramework="net45" />
   <package id="Microsoft.Net.Http" version="2.2.28" targetFramework="net45" />
-  <package id="Microsoft.WindowsAzure.Common" version="1.4.0" targetFramework="net45" />
-  <package id="Microsoft.WindowsAzure.Common.Dependencies" version="1.1.0" targetFramework="net45" />
+  <package id="Microsoft.WindowsAzure.Common" version="1.4.1" targetFramework="net45" />
+  <package id="Microsoft.WindowsAzure.Common.Dependencies" version="1.1.1" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.ConfigurationManager" version="2.0.3" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management" version="2.1.0" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management.Compute" version="6.0.0" targetFramework="net45" />
-  <package id="Microsoft.WindowsAzure.Management.ExpressRoute" version="0.11.2-preview" targetFramework="net45" />
+  <package id="Microsoft.WindowsAzure.Management.ExpressRoute" version="0.16.2-preview" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management.MediaServices" version="1.2.0" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management.ServiceBus" version="0.15.0-preview" targetFramework="net45" />
   <package id="Microsoft.WindowsAzure.Management.Storage" version="3.1.0" targetFramework="net45" />

Original file line number	Diff line number	Diff line change
`@@ -5258,7 +5258,7 @@ public string PrivateConfigurationSchema`
`5258`	`5258`	`public string CompanyName { get; set; }`
`5259`	`5259`
`5260`	`5260`	`#region IExtensibleDataObject Members`
`5261`		`- ExtensionDataObject IExtensibleDataObject.ExtensionData { get; set; }`
	`5261`	`+ public ExtensionDataObject ExtensionData { get; set; }`
`5262`	`5262`	`#endregion`
`5263`	`5263`	`}`
`5264`	`5264`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`
`17`	`17`	`namespace Microsoft.Azure.Commands.DataFactories`
`18`	`18`	`{`
	`19`	`+ [Serializable]`
`19`	`20`	`internal class ProvisioningFailedException : Exception`
`20`	`21`	`{`
`21`	`22`	`public ProvisioningFailedException(string errorMessage)`
Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,8 @@ public sealed class ResourcesController`
`31`	`31`	`{`
`32`	`32`	`private CSMTestEnvironmentFactory csmTestFactory;`
`33`	`33`	`private EnvironmentSetupHelper helper;`
`34`		`- protected const string TenantIdKey = "TenantId";`
`35`		`- protected const string DomainKey = "Domain";`
	`34`	`+ private const string TenantIdKey = "TenantId";`
	`35`	`+ private const string DomainKey = "Domain";`
`36`	`36`
`37`	`37`	`public GraphRbacManagementClient GraphClient { get; private set; }`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -68,9 +68,9 @@ public static DscPublicSettings DeserializePublicSettings(string publicSettingsS`
`68`	`68`	`JsonConvert.DeserializeObject<DscPublicSettings.Version1>(publicSettingsString);`
`69`	`69`	`publicSettings = publicSettingsV1.ToCurrentVersion();`
`70`	`70`	`}`
`71`		`- catch (JsonException e)`
	`71`	`+ catch (JsonException)`
`72`	`72`	`{`
`73`		`- throw e;`
	`73`	`+ throw;`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`	`return publicSettings;`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public AzureHDInsightJobSubmissionClientSimulator(`
`54`	`54`	`this.InitializeSimulator();`
`55`	`55`	`}`
`56`	`56`
`57`		`- public void Dispose()`
	`57`	`+ public new void Dispose()`
`58`	`58`	`{`
`59`	`59`	`}`
`60`	`60`
`@@ -65,17 +65,17 @@ public string GetCustomUserAgent()`
`65`	`65`	`throw new NotImplementedException();`
`66`	`66`	`}`
`67`	`67`
`68`		`- public void AddLogWriter(ILogWriter logWriter)`
	`68`	`+ public new void AddLogWriter(ILogWriter logWriter)`
`69`	`69`	`{`
`70`	`70`	`this.logger.AddWriter(logWriter);`
`71`	`71`	`}`
`72`	`72`
`73`		`- public void RemoveLogWriter(ILogWriter logWriter)`
	`73`	`+ public new void RemoveLogWriter(ILogWriter logWriter)`
`74`	`74`	`{`
`75`	`75`	`this.logger.RemoveWriter(logWriter);`
`76`	`76`	`}`
`77`	`77`
`78`		`- public void Cancel()`
	`78`	`+ public new void Cancel()`
`79`	`79`	`{`
`80`	`80`	`}`
`81`	`81`
`@@ -329,12 +329,12 @@ public Task<JobList> ListJobsAsync()`
`329`	`329`	`return TaskEx2.FromResult(jobDetailList);`
`330`	`330`	`}`
`331`	`331`
`332`		`- public void SetCancellationSource(CancellationTokenSource tokenSource)`
	`332`	`+ public new void SetCancellationSource(CancellationTokenSource tokenSource)`
`333`	`333`	`{`
`334`	`334`	`this.cancellationTokenSource = tokenSource;`
`335`	`335`	`}`
`336`	`336`
`337`		`- public bool IgnoreSslErrors { get; set; }`
	`337`	`+ public new bool IgnoreSslErrors { get; set; }`
`338`	`338`
`339`	`339`	`public JobDetails StopJob(string jobId)`
`340`	`340`	`{`
`@@ -537,6 +537,6 @@ private void WriteJobOutput(string jobId, string statusDirectory, string stdoutC`
`537`	`537`	`this.jobOutput[jobId] = stdoutContent;`
`538`	`538`	`}`
`539`	`539`
`540`		`- public ILogger Logger { get; private set; }`
	`540`	`+ public new ILogger Logger { get; private set; }`
`541`	`541`	`}`
`542`	`542`	`}`