Storage breaking changes

Author: cormacpayne

src/ResourceManager/Storage/ChangeLog.md

@@ -19,6 +19,8 @@
 -->
 ## Current Release
 * Set minimum dependency of module to PowerShell 5.0
+* Introduced multiple breaking changes
+    - Please refer to the migration guide for more information
 
 ## Version 4.2.3
 * Updated to the latest version of the Azure ClientRuntime

src/ResourceManager/Storage/Commands.Management.Storage/StorageAccount/NewAzureStorageAccount.cs

@@ -97,12 +97,6 @@ public class NewAzureStorageAccountCommand : StorageAccountBaseCmdlet
         [ValidateNotNullOrEmpty]
         public bool? UseSubDomain { get; set; }
 
-        [Parameter(
-            Mandatory = false,
-            HelpMessage = "Storage Service that will enable encryption.")]
-        [Obsolete("Encryption at Rest is already enabled by default for this storage account.", false)]
-        public EncryptionSupportServiceEnum? EnableEncryptionService { get; set; }
-
         [Parameter(
             Mandatory = false,
             HelpMessage = "Storage Account Tags.")]

src/ResourceManager/Storage/Commands.Management.Storage/StorageAccount/SetAzureStorageAccount.cs

@@ -101,18 +101,6 @@ public SwitchParameter Force
         [ValidateNotNullOrEmpty]
         public bool? UseSubDomain { get; set; }
 
-        [Parameter(
-            Mandatory = false,
-            HelpMessage = "Storage Service that will enable encryption.")]
-        [Obsolete("Encryption at Rest is enabled by default for this storage account.", false)]
-        public EncryptionSupportServiceEnum? EnableEncryptionService { get; set; }
-
-        [Parameter(
-            Mandatory = false,
-            HelpMessage = "Storage Service that will disable encryption.")]
-        [Obsolete("Encryption at Rest is enabled by default for this storage account. This feature cannot be disabled.", false)]
-        public EncryptionSupportServiceEnum? DisableEncryptionService { get; set; }
-
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true,
@@ -148,7 +136,7 @@ public SwitchParameter StorageEncryption
         private bool storageEncryption = false;
 
         [Parameter(HelpMessage = "Whether to set Storage Account encryption keySource to Microsoft.Keyvault or not. " +
-            "If you specify KeyName, KeyVersion and KeyvaultUri, Storage Account Encryption KeySource will also be set to Microsoft.Keyvault weather this parameter is set or not.", 
+            "If you specify KeyName, KeyVersion and KeyvaultUri, Storage Account Encryption KeySource will also be set to Microsoft.Keyvault weather this parameter is set or not.",
             Mandatory = false, ParameterSetName = KeyvaultEncryptionParameterSet)]
         public SwitchParameter KeyvaultEncryption
         {

src/ResourceManager/Storage/Commands.Management.Storage/help/New-AzureRmStorageAccount.md

@@ -16,9 +16,9 @@ Creates a Storage account.
 ```
 New-AzureRmStorageAccount [-ResourceGroupName] <String> [-Name] <String> [-SkuName] <String>
  [-Location] <String> [-Kind <String>] [-AccessTier <String>] [-CustomDomainName <String>]
- [-UseSubDomain <Boolean>] [-EnableEncryptionService <EncryptionSupportServiceEnum>] [-Tag <Hashtable>]
- [-EnableHttpsTrafficOnly <Boolean>] [-AssignIdentity] [-NetworkRuleSet <PSNetworkRuleSet>] [-AsJob]
- [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+ [-UseSubDomain <Boolean>] [-Tag <Hashtable>] [-EnableHttpsTrafficOnly <Boolean>] 
+ [-AssignIdentity] [-NetworkRuleSet <PSNetworkRuleSet>] [-AsJob] [-DefaultProfile <IAzureContextContainer>] 
+ [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -143,23 +143,6 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -EnableEncryptionService
-Indicates whether this cmdlet enables Storage Service Encryption. 
-Azure Blob storage and Azure Files are supported.
-
-```yaml
-Type: EncryptionSupportServiceEnum
-Parameter Sets: (All)
-Aliases: 
-Accepted values: None, Blob, File
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
 ### -EnableHttpsTrafficOnly
 Indicates whether or not the Storage account only enables HTTPS traffic.
 

src/ResourceManager/Storage/Commands.Management.Storage/help/Set-AzureRmStorageAccount.md

@@ -17,9 +17,7 @@ Modifies a Storage account.
 ```
 Set-AzureRmStorageAccount [-ResourceGroupName] <String> [-Name] <String> [-Force] [-SkuName <String>]
  [-AccessTier <String>] [-CustomDomainName <String>] [-UseSubDomain <Boolean>]
- [-EnableEncryptionService <EncryptionSupportServiceEnum>]
- [-DisableEncryptionService <EncryptionSupportServiceEnum>] [-Tag <Hashtable>]
- [-EnableHttpsTrafficOnly <Boolean>] [-StorageEncryption] [-AssignIdentity]
+ [-Tag <Hashtable>] [-EnableHttpsTrafficOnly <Boolean>] [-StorageEncryption] [-AssignIdentity]
  [-NetworkRuleSet <PSNetworkRuleSet>] [-UpgradeToStorageV2] [-AsJob] [-DefaultProfile <IAzureContextContainer>]
  [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
@@ -28,9 +26,7 @@ Set-AzureRmStorageAccount [-ResourceGroupName] <String> [-Name] <String> [-Force
 ```
 Set-AzureRmStorageAccount [-ResourceGroupName] <String> [-Name] <String> [-Force] [-SkuName <String>]
  [-AccessTier <String>] [-CustomDomainName <String>] [-UseSubDomain <Boolean>]
- [-EnableEncryptionService <EncryptionSupportServiceEnum>]
- [-DisableEncryptionService <EncryptionSupportServiceEnum>] [-Tag <Hashtable>]
- [-EnableHttpsTrafficOnly <Boolean>] [-KeyvaultEncryption] -KeyName <String> -KeyVersion <String>
+ [-Tag <Hashtable>] [-EnableHttpsTrafficOnly <Boolean>] [-KeyvaultEncryption] -KeyName <String> -KeyVersion <String>
  -KeyVaultUri <String> [-AssignIdentity] [-NetworkRuleSet <PSNetworkRuleSet>] [-UpgradeToStorageV2] [-AsJob]
  [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
@@ -202,40 +198,6 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -DisableEncryptionService
-Indicates whether this cmdlet disables Storage Service Encryption. 
-Azure Blob storage and Azure Files are supported.
-
-```yaml
-Type: EncryptionSupportServiceEnum
-Parameter Sets: (All)
-Aliases: 
-Accepted values: None, Blob, File
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
-### -EnableEncryptionService
-Indicates whether this cmdlet enables Storage Service Encryption. 
-Azure Blob storage and Azure Files are supported.
-
-```yaml
-Type: EncryptionSupportServiceEnum
-Parameter Sets: (All)
-Aliases: 
-Accepted values: None, Blob, File
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
 ### -EnableHttpsTrafficOnly
 Indicates whether or not the Storage account only enables HTTPS traffic.
 

src/ResourceManager/Storage/documentation/current-breaking-changes.md

@@ -38,4 +38,14 @@
     https://github.com/Azure/azure-powershell/blob/dev/documentation/breaking-changes/breaking-change-template.md
 -->
 
-## Current Breaking Changes
+## Current Breaking Changes
+
+### Release 5.0.0 - May 2018
+
+The following cmdlets were affected this release:
+
+**New-AzureRmStorageAccount**
+- The parameter `EnableEncryptionService` is being removed
+
+**Set-AzureRmStorageAccount**
+- The parameters `EnableEncryptionService` and `DisableEncryptionService` is being removed