Merge pull request #233 from MabOneSdk/anudeeb-dev1

Trigger Backup Cmdlet

Author: Samuel Anudeep

src/ResourceManager/RecoveryServices.Backup/CmdletParameterHelpMessages.cs

@@ -73,6 +73,7 @@ internal static class Item
             public const string Status = "Status of the data source";
             public const string Container = "Container where the item resides";
             public const string RemoveProtectionOption = "If this option is used, all the backup data for this item will also be deleted and restoring data will not be possible.";
+            public const string ExpiryDate = "Retention period for the recovery points created by this backup operaiton";
         }
 
         internal static class RecoveryPoint

src/ResourceManager/RecoveryServices.Backup/Cmdlets/Item/EnableAzureRmRecoveryServicesProtection.cs

@@ -83,29 +83,7 @@ public override void ExecuteCmdlet()
 
                 // Track Response and display job details
 
-                WriteDebug(Resources.TrackingOperationStatusURLForCompletion +
-                                itemResponse.AzureAsyncOperation);
-
-                var response = WaitForOperationCompletionUsingStatusLink(
-                                                itemResponse.AzureAsyncOperation,
-                                                HydraAdapter.GetProtectedItemOperationStatusByURL);
-
-                WriteDebug(Resources.FinalOperationStatus + response.OperationStatus.Status);
-
-                if (response.OperationStatus.Properties != null &&
-                       ((HydraModel.OperationStatusJobExtendedInfo)response.OperationStatus.Properties).JobId != null)
-                {
-                    var jobStatusResponse = (HydraModel.OperationStatusJobExtendedInfo)response.OperationStatus.Properties;
-                    WriteObject(GetJobObject(jobStatusResponse.JobId));
-                }
-
-                if(response.OperationStatus.Status == HydraModel.OperationStatusValues.Failed)
-                {
-                    var errorMessage = string.Format(Resources.EnableProtectionOperationFailed,
-                    response.OperationStatus.OperationStatusError.Code,
-                    response.OperationStatus.OperationStatusError.Message);
-                    throw new Exception(errorMessage);
-                }
+                HandleCreatedJob(itemResponse, Resources.EnableProtectionOperation);
             });
         }
     }

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Cmdlets.csproj

@@ -83,6 +83,7 @@
     <Compile Include="Cmdlets\Container\UnregisterAzureRmBackupManagementServer.cs" />
     <Compile Include="Cmdlets\Container\UnregisterAzureRmRecoveryServicesBackupContainer.cs" />
     <Compile Include="Cmdlets\Item\DisableAzureRmRecoveryServicesProtection.cs" />
+    <Compile Include="Cmdlets\Backup\BackupAzureRmRecoveryServicesItem.cs" />
     <Compile Include="Cmdlets\Item\EnableAzureRmRecoveryServicesProtection.cs" />
     <Compile Include="Cmdlets\Item\GetAzureRmRecoveryServicesItem.cs" />
     <Compile Include="Cmdlets\Jobs\GetAzureRmRecoveryServicesJob.cs" />
@@ -103,9 +104,7 @@
     <Compile Include="RecoveryServicesBackupCmdletBase.cs" />
     <Compile Include="CmdletParameterHelpMessages.cs" />
   </ItemGroup>
-  <ItemGroup>
-    <Folder Include="Cmdlets\Backup\" />
-  </ItemGroup>
+  <ItemGroup />
   <ItemGroup>
     <ProjectReference Include="..\..\Common\Commands.Common.Authentication\Commands.Common.Authentication.csproj">
       <Project>{d3804b64-c0d3-48f8-82ec-1f632f833c9e}</Project>

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Helpers/HydraHelpers.cs

@@ -59,19 +59,26 @@ public static string GetHydraProviderType(CmdletModel.WorkloadType workloadType)
             return providerType;
         }
 
-        public static void GetSkipTokenFromNextLink(string url, out string nextLink)
+        public static void GetSkipTokenFromNextLink(string nextLink, out string skipToken)
         {
-            Uri uriObj = new Uri(url);
-            // This is sent by service and we don't expect this to be encoded.
-            // TODO: Need to make sure during testing that this is in fact true.
-            NameValueCollection queryParams = HttpUtility.ParseQueryString(uriObj.Query);
-            if (queryParams.Get(HydraConstants.SkipToken) != null)
+            if (nextLink != null)
             {
-                nextLink = queryParams.Get(HydraConstants.SkipToken);
+                Uri uriObj = new Uri(nextLink);
+                // This is sent by service and we don't expect this to be encoded.
+                // TODO: Need to make sure during testing that this is in fact true.
+                NameValueCollection queryParams = HttpUtility.ParseQueryString(uriObj.Query);
+                if (queryParams.Get(HydraConstants.SkipToken) != null)
+                {
+                    skipToken = queryParams.Get(HydraConstants.SkipToken);
+                }
+                else
+                {
+                    skipToken = null;
+                }
             }
             else
             {
-                nextLink = null;
+                skipToken = null;
             }
         }
 

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.HydraAdapter/BMSAPIs/ProtectableItemAPI.cs

@@ -38,5 +38,17 @@ public ProtectableObjectListResponse ListProtectableItem(
                                      BmsAdapter.GetCustomRequestHeaders(),
                                      BmsAdapter.CmdletCancellationToken).Result;
         }
+
+        public BaseRecoveryServicesJobResponse TriggerBackup(string containerName, string itemName)
+        {
+            return BmsAdapter.Client.Backup.TriggerBackupAsync(
+                BmsAdapter.GetResourceGroupName(),
+                BmsAdapter.GetResourceName(),
+                BmsAdapter.GetCustomRequestHeaders(),
+                HydraAdapter.AzureFabricName,
+                containerName,
+                itemName,
+                BmsAdapter.CmdletCancellationToken).Result;
+        }
     }
 }

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/CmdletParamEnums.cs

@@ -70,6 +70,7 @@ public enum ItemParams
         Container,
         ProtectionStatus,
         Status,
-        DeleteBackupData
+        DeleteBackupData,
+        ExpiryDate,
     }
 }

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/CommonModels/Utils.cs

@@ -62,6 +62,18 @@ public class IdUtils
     {
         static readonly Regex ResourceGroupRegex = new Regex(@"/Subscriptions/(?<subscriptionsId>.+)/resourceGroups/(?<resourceGroupName>.+)/providers/(?<providersName>.+)/vaults/(?<BackupVaultName>.+)/backupFabrics/(?<BackupFabricName>.+)/protectionContainers/(?<containersName>.+)", RegexOptions.Compiled);
         const string NameDelimiter = ";";
+        const string IdDelimiter = "/";
+
+        public class IdNames
+        {
+            public const string SubscriptionId = "Subscriptions";
+            public const string ResourceGroup = "resourceGroups";
+            public const string Provider = "providers";
+            public const string Vault = "vaults";
+            public const string BackupFabric = "backupFabrics";
+            public const string ProtectionContainerName = "protectionContainers";
+            public const string ProtectedItemName = "protectedItems";
+        }
 
         public static string GetResourceGroupName(string id)
         {
@@ -89,6 +101,19 @@ public static string GetResourceGroupName(string id)
 
             return null;
         }
+
+        public static string GetValueByName(string id, string idName)
+        {
+            var parts = id.Split(IdDelimiter.ToArray(), StringSplitOptions.RemoveEmptyEntries)
+                .Select((x, i) => new { Index = i, Value = x })
+                .GroupBy(x => x.Index % 2)
+                .ToList();
+
+            var dict = parts[0].ToList().Zip(parts[1].ToList(), (k, v) => new { k, v })
+                               .ToDictionary(x => x.k.Value, x => x.v.Value);
+
+            return dict[idName];
+        }
     }
 
     public class EnumUtils

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/Properties/Resources.Designer.cs

@@ -326,8 +326,8 @@ Please contact Microsoft for further assistant.</value>
   <data name="BothCloudServiceNameAndResourceGroupNameShouldNotEmpty" xml:space="preserve">
     <value>For Azure VM, both cloud service name and resource group name can not be empty</value>
   </data>
-  <data name="EnableProtectionOperationFailed" xml:space="preserve">
-    <value>Enable Protection OperationFailed with error code: {0} , and error Message: {1}</value>
+  <data name="EnableProtectionOperation" xml:space="preserve">
+    <value>Enable Protection Operation</value>
   </data>
   <data name="RemoveProtectionPolicyMessage" xml:space="preserve">
     <value>Removing the protection policy</value>
@@ -362,4 +362,10 @@ Please contact Microsoft for further assistant.</value>
   <data name="PolicyNameIsEmptyOrNull" xml:space="preserve">
     <value>PolicyName is NULL or Empty. Please enter valid PolicyName</value>
   </data>
+  <data name="OperationFailed" xml:space="preserve">
+    <value>{0} failed. Error Code: {1}. Error Message: {2}</value>
+  </data>
+  <data name="TriggerBackupOperation" xml:space="preserve">
+    <value>Trigger Backup Operation</value>
+  </data>
 </root>

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/Properties/Resources.resx

@@ -64,7 +64,7 @@ public BaseRecoveryServicesJobResponse EnableProtection()
             AzureRmRecoveryServicesIaasVmItem item = (AzureRmRecoveryServicesIaasVmItem)
                                                  ProviderData.ProviderParameters[ItemParams.Item];
             // do validations
-
+            
             string containerUri = "";
             string protectedItemUri = "";
             bool isComputeAzureVM = false;
@@ -88,7 +88,7 @@ public BaseRecoveryServicesJobResponse EnableProtection()
                 ValidateAzureVMWorkloadType(item.WorkloadType, policy.WorkloadType);
                 ValidateAzureVMModifyProtectionRequest(itemBase, policy);
 
-                isComputeAzureVM =  IsComputeAzureVM(item.VirtualMachineId);
+                isComputeAzureVM = IsComputeAzureVM(item.VirtualMachineId);
 
                 string containerType = HydraHelpers.GetHydraContainerType(item.ContainerType);
                 string vmType = HydraHelpers.GetHydraWorkloadType(item.WorkloadType);
@@ -186,7 +186,11 @@ public BaseRecoveryServicesJobResponse DisableProtection()
 
         public BaseRecoveryServicesJobResponse TriggerBackup()
         {
-            throw new NotImplementedException();
+            AzureRmRecoveryServicesItemBase item = (AzureRmRecoveryServicesItemBase)ProviderData.ProviderParameters[ItemParams.Item];
+            DateTime expiryDate = (DateTime)ProviderData.ProviderParameters[ItemParams.ExpiryDate];
+            AzureRmRecoveryServicesIaasVmItem iaasVmItem = item as AzureRmRecoveryServicesIaasVmItem;
+            return HydraAdapter.TriggerBackup(IdUtils.GetValueByName(iaasVmItem.Id, IdUtils.IdNames.ProtectionContainerName), 
+                IdUtils.GetValueByName(iaasVmItem.Id, IdUtils.IdNames.ProtectedItemName));
         }
 
         public BaseRecoveryServicesJobResponse TriggerRestore()
@@ -195,7 +199,7 @@ public BaseRecoveryServicesJobResponse TriggerRestore()
                 as AzureRmRecoveryServicesIaasVmRecoveryPoint;
             string storageId = ProviderData.ProviderParameters[RestoreBackupItemParams.StorageAccountId].ToString();
 
-            if(rp == null)
+            if (rp == null)
             {
                 throw new InvalidCastException("Cant convert input to AzureRmRecoveryServicesIaasVmRecoveryPoint");
             }
@@ -430,9 +434,23 @@ public List<AzureRmRecoveryServicesItemBase> ListProtectedItems()
             queryParams.DatasourceType = Microsoft.Azure.Management.RecoveryServices.Backup.Models.WorkloadType.VM;
             queryParams.ProviderType = ProviderType.AzureIaasVM.ToString();
 
-            var listResponse = HydraAdapter.ListProtectedItem(queryParams);
+            List<ProtectedItemResource> protectedItems = new List<ProtectedItemResource>();
+            string skipToken = null;
+            PaginationRequest paginationRequest = null;
+            do
+            {
+                var listResponse = HydraAdapter.ListProtectedItem(queryParams, paginationRequest);
+                protectedItems.AddRange(listResponse.ItemList.Value);
+
+                HydraHelpers.GetSkipTokenFromNextLink(listResponse.ItemList.NextLink, out skipToken);
+                if (skipToken != null)
+                {
+                    paginationRequest = new PaginationRequest();
+                    paginationRequest.SkipToken = skipToken;
+                }
+            } while (skipToken != null);
 
-            List<AzureRmRecoveryServicesItemBase> itemModels = ConversionHelpers.GetItemModelList(listResponse.ItemList.Value, container);
+            List<AzureRmRecoveryServicesItemBase> itemModels = ConversionHelpers.GetItemModelList(protectedItems, container);
 
             // 1. Filter by container
             itemModels = itemModels.Where(itemModel =>
@@ -654,11 +672,12 @@ private void ValidateAzureVMRetentionPolicy(AzureRmRecoveryServicesRetentionPoli
         private void ValidateAzureVMEnableProtectionRequest(string vmName, string serviceName, string rgName,
             AzureRmRecoveryServicesPolicyBase policy)
         {
-            if(string.IsNullOrEmpty(vmName))
+            ValidateAzureVMProtectionPolicy(policy);
+            if (string.IsNullOrEmpty(vmName))
             {
                 throw new ArgumentException(string.Format(Resources.InvalidAzureVMName));
             }
-            if(string.IsNullOrEmpty(rgName) && string.IsNullOrEmpty(serviceName))
+            if (string.IsNullOrEmpty(rgName) && string.IsNullOrEmpty(serviceName))
             {
                 throw new ArgumentException(string.Format(Resources.BothCloudServiceNameAndResourceGroupNameShouldNotEmpty));
             }
@@ -690,7 +709,7 @@ private void ValidateAzureVMDisableProtectionRequest(AzureRmRecoveryServicesItem
         private bool IsComputeAzureVM(string virtualMachineId)
         {
             bool isComputeAzureVM = true;
-            if(virtualMachineId.IndexOf(classicComputeAzureVMVersion, StringComparison.InvariantCultureIgnoreCase) >=0)
+            if (virtualMachineId.IndexOf(classicComputeAzureVMVersion, StringComparison.InvariantCultureIgnoreCase) >= 0)
             {
                 isComputeAzureVM = false;
             }
@@ -781,9 +800,9 @@ private void RefreshContainer()
         {
             bool isDiscoverySuccessful = false;
             string errorMessage = string.Empty;
-            var refreshContainerJobResponse = HydraAdapter.RefreshContainers();
+                var refreshContainerJobResponse = HydraAdapter.RefreshContainers();
 
-            //Now wait for the operation to Complete
+                //Now wait for the operation to Complete
             WaitForDiscoveryToComplete(refreshContainerJobResponse.Location, out isDiscoverySuccessful, out errorMessage);
 
             if (!isDiscoverySuccessful)

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Providers/Providers/IaasVmPsBackupProvider.cs

@@ -42,11 +42,6 @@ public IPsBackupProvider GetProviderInstance(ContainerType containerType, Backup
             switch (containerType)
             {
                 case ContainerType.AzureVM:
-                    if (backupManagementType.HasValue && backupManagementType != BackupManagementType.AzureVM)
-                    {
-                        throw new ArgumentException("BackupManagementType is not expected for ContainerType: " +
-                                                     containerType.ToString());
-                    }
                     providerType = PsBackupProviderTypes.IaasVm;
                     break;
                 case ContainerType.Windows:

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Providers/PsBackupProviderManager.cs

@@ -45,5 +45,11 @@ public void TestDisableAzureVMProtectionScenario()
         {
             this.RunPowerShellTest(PsBackupProviderTypes.IaasVm.ToString(), "Test-DisableAzureVMProtectionScenario");
         }
+
+        [Fact]
+        public void TestBackupItemScenario()
+        {
+            this.RunPowerShellTest(PsBackupProviderTypes.IaasVm.ToString(), "Test-BackupItemScenario");
+        }
     }
 }

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.cs

@@ -48,4 +48,18 @@ function Test-DisableAzureVMProtectionScenario
 
 	$job = Disable-AzureRmRecoveryServicesProtection -Item $item -Force;
 	Assert-AreEqual $job.Status "Completed";
+}
+
+function Test-BackupItemScenario
+{
+	$vault = Get-AzureRmRecoveryServicesVault -ResourceGroupName "pstestrg" -Name "pstestrsvault";
+	Set-AzureRmRecoveryServicesVaultContext -Vault $vault;
+	
+	$namedContainer = Get-AzureRmRecoveryServicesContainer -ContainerType "AzureVM" -Status "Registered" -Name "pstestv2vm1";
+	Assert-AreEqual $namedContainer.FriendlyName "pstestv2vm1";
+
+	$item = Get-AzureRmRecoveryServicesItem -Container $namedContainer -WorkloadType "AzureVM";
+	echo $item.Name;
+
+	Backup-AzureRmRecoveryServicesItem -Item $item;
 }