Call out breaking change and remove

Remove outdated breaking change
Add suppression

Author: Zhenyu Zhou

src/HDInsight/HDInsight/Az.HDInsight.psd1

@@ -107,8 +107,7 @@ CmdletsToExport = 'Get-AzHDInsightJob', 'New-AzHDInsightSqoopJobDefinition',
 
 # Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
 AliasesToExport = 'Enable-AzHDInsightOMS', 'Disable-AzHDInsightOMS', 
-               'Add-AzHDInsightConfigValues', 'Get-AzHDInsightOMS', 
-               'Get-AzHDInsightProperties'
+               'Get-AzHDInsightOMS'
 
 # DSC resources to export from this module
 # DscResourcesToExport = @()

src/HDInsight/HDInsight/ManagementCommands/AddAzureHDInsightConfigValuesCommand.cs

@@ -22,9 +22,7 @@
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
-    [GenericBreakingChange("Add-AzHDInsightConfigValues alias will be removed in an upcoming breaking change release", "2.0.0")]
     [Cmdlet("Add", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightConfigValue"),OutputType(typeof(AzureHDInsightConfig))]
-    [Alias("Add-AzHDInsightConfigValues")]
     public class AddAzureHDInsightConfigValuesCommand : HDInsightCmdletBase
     {
         private Dictionary<string, Hashtable> _configurations;

src/HDInsight/HDInsight/ManagementCommands/DisableAzureHDInsightOMSCommand.cs

@@ -15,10 +15,12 @@
 using Microsoft.Azure.Commands.HDInsight.Commands;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.HDInsight.Models;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation(ReplacementCmdletName = "Disable-AzHDInsightMonitoring")]
     [Cmdlet("Disable", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOperationsManagementSuite",SupportsShouldProcess = true)]
     [Alias("Disable-" + ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOMS")]
     [OutputType(typeof(OperationResource))]

src/HDInsight/HDInsight/ManagementCommands/EnableAzureHDInsightOMSCommand.cs

@@ -20,9 +20,11 @@
 using System.Reflection;
 using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation(ReplacementCmdletName = "Enable-AzHDInsightMonitoring")]
     [Cmdlet("Enable", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOperationsManagementSuite",SupportsShouldProcess = true)]
     [Alias("Enable-" + ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOMS")]
     [OutputType(typeof(OperationResource))]

src/HDInsight/HDInsight/ManagementCommands/GetAzureHDInsightOMSCommand.cs

@@ -15,10 +15,12 @@
 using Microsoft.Azure.Commands.HDInsight.Commands;
 using Microsoft.Azure.Commands.HDInsight.Models.Management;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation(ReplacementCmdletName = "Get-AzHDInsightMonitoring")]
     [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOperationsManagementSuite")]
     [Alias("Get-" + ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOMS")]
     [OutputType(typeof(AzureHDInsightOMS))]

src/HDInsight/HDInsight/ManagementCommands/GetAzureHDInsightPropertiesCommand.cs

@@ -20,9 +20,8 @@
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
-    [GenericBreakingChange("Get-AzHDInsightProperties alias will be removed in an upcoming breaking change release", "2.0.0")]
+    [CmdletOutputBreakingChange(typeof(CapabilitiesResponse), ReplacementCmdletOutputTypeName = "AzureHDInsightCapabilities")]
     [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightProperty"),OutputType(typeof(CapabilitiesResponse))]
-    [Alias("Get-AzHDInsightProperties")]
     public class GetAzureHDInsightPropertiesCommand : HDInsightCmdletBase
     {
         #region Input Parameter Definitions

src/HDInsight/HDInsight/ManagementCommands/GrantAzureHDInsightRdpServicesAccessCommand.cs

@@ -16,11 +16,13 @@
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.HDInsight.Models;
 using Microsoft.WindowsAzure.Commands.Common;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation("3.0.0")]
     [Cmdlet("Grant", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightRdpServicesAccess"),OutputType(typeof(void))]
     public class GrantAzureHDInsightRdpServicesAccessCommand : HDInsightCmdletBase
     {

src/HDInsight/HDInsight/ManagementCommands/RemoveAzureHDInsightClusterCommand.cs

@@ -15,10 +15,12 @@
 using Microsoft.Azure.Commands.HDInsight.Commands;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.HDInsight.Models;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletOutputBreakingChange(typeof(ClusterGetResponse))]
     [Cmdlet("Remove", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightCluster"),OutputType(typeof(ClusterGetResponse))]
     public class RemoveAzureHDInsightCommand : HDInsightCmdletBase
     {

src/HDInsight/HDInsight/ManagementCommands/RevokeAzureHDInsightRdpServicesAccessCommand.cs

@@ -15,10 +15,12 @@
 using Microsoft.Azure.Commands.HDInsight.Commands;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.HDInsight.Models;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation("3.0.0")]
     [Cmdlet("Revoke", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightRdpServicesAccess"),OutputType(typeof(void))]
     public class RevokeAzureHDInsightRdpServicesAccessCommand : HDInsightCmdletBase
     {

src/HDInsight/HDInsight/ManagementCommands/SetAzureHDInsightGatewayCredentialCommand.cs

@@ -19,12 +19,14 @@
 using Microsoft.Azure.Management.HDInsight.Models;
 using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
 using Microsoft.WindowsAzure.Commands.Common;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
 using System;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletOutputBreakingChange(typeof(HttpConnectivitySettings), ReplacementCmdletOutputTypeName = "AzureHDInsightGatewaySettings")]
     [Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightGatewayCredential", DefaultParameterSetName = SetByNameParameterSet, SupportsShouldProcess = true), OutputType(typeof(HttpConnectivitySettings))]
     public class SetAzureHDInsightGatewayCredentialCommand : HDInsightCmdletBase
     {

tools/StaticAnalysis/Exceptions/Az.HDInsight/BreakingChangeIssues.csv

@@ -0,0 +1,3 @@
+"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
+"Microsoft.Azure.PowerShell.Cmdlets.HDInsight.dll","Microsoft.Azure.Commands.HDInsight.GrantAzureHDInsightHttpServicesAccessCommand","Grant-AzHDInsightHttpServicesAccess","0","1000","The cmdlet 'Grant-AzHDInsightHttpServicesAccess' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'Grant-AzHDInsightHttpServicesAccess' back to the module, or add an alias to the original cmdlet name."
+"Microsoft.Azure.PowerShell.Cmdlets.HDInsight.dll","Microsoft.Azure.Commands.HDInsight.RevokeAzureHDInsightHttpServicesAccessCommand","Revoke-AzHDInsightHttpServicesAccess","0","1000","The cmdlet 'Revoke-AzHDInsightHttpServicesAccess' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'Revoke-AzHDInsightHttpServicesAccess' back to the module, or add an alias to the original cmdlet name."