Merge pull request #3848 from cormacpayne/breaking-change-fix

markcowl · web-flow · commit 4705f27d8b34 · 2017-04-27T11:32:13.000-07:00
Fix issue with breaking change tool handling multiple lists in output
diff --git a/tools/StaticAnalysis/BreakingChangeAnalyzer/CmdletMetadataHelper.cs b/tools/StaticAnalysis/BreakingChangeAnalyzer/CmdletMetadataHelper.cs
@@ -220,7 +220,10 @@ private void CheckForChangedOutputType(
             // Add each output in the new metadata to the dictionary
             foreach (var newOutput in newCmdlet.OutputTypes)
             {
-                outputDictionary.Add(newOutput.Type.Name, newOutput.Type);
+                if (!outputDictionary.ContainsKey(newOutput.Type.Name))
+                {
+                    outputDictionary.Add(newOutput.Type.Name, newOutput.Type);
+                }
             }
 
             // For each output in the old metadata, see if it

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,10 @@ private void CheckForChangedOutputType(`
`220`	`220`	`// Add each output in the new metadata to the dictionary`
`221`	`221`	`foreach (var newOutput in newCmdlet.OutputTypes)`
`222`	`222`	`{`
`223`		`- outputDictionary.Add(newOutput.Type.Name, newOutput.Type);`
	`223`	`+ if (!outputDictionary.ContainsKey(newOutput.Type.Name))`
	`224`	`+ {`
	`225`	`+ outputDictionary.Add(newOutput.Type.Name, newOutput.Type);`
	`226`	`+ }`
`224`	`227`	`}`
`225`	`228`
`226`	`229`	`// For each output in the old metadata, see if it`