Fix bug in StaticAnalysis that threw when a new mandatory parameter with aliases is added to a set

Author: cormacpayne

tools/StaticAnalysis/BreakingChangeAnalyzer/ParameterSetMetadataHelper.cs

@@ -13,6 +13,7 @@
 // ----------------------------------------------------------------------------------
 
 using System.Collections.Generic;
+using System.Linq;
 using Tools.Common.Loggers;
 using Tools.Common.Models;
 
@@ -115,7 +116,8 @@ public void CompareParameterSetMetadata(
                     bool foundAdditional = false;
                     foreach (var parameter in newParameterSet.Parameters)
                     {
-                        if (parameterDictionary.ContainsKey(parameter.ParameterMetadata.Name))
+                        if (parameterDictionary.ContainsKey(parameter.ParameterMetadata.Name) ||
+                            parameter.ParameterMetadata.AliasList.Any(a => parameterDictionary.ContainsKey(a)))
                         {
                             continue;
                         }