Skip to content

Commit 4b2b765

Browse files
Deployment Scripts GA - update api-version (#13737)
* Update deploymentScripts apiVersion to latest GA version * update changelog * Update ChangeLog.md * Fix template spec error type Co-authored-by: Yunchi Wang <[email protected]>
1 parent 325a226 commit 4b2b765

18 files changed

+28107
-186910
lines changed

src/Resources/ResourceManager/ResourceManager.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
<ItemGroup>
1515
<PackageReference Include="AutoMapper" Version="6.2.2" />
16-
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="3.10.0-preview" />
16+
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="3.11.0-preview" />
1717
<PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
1818
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="2.2.0" />
1919
</ItemGroup>

src/Resources/ResourceManager/SdkClient/TemplateSpecsSdkClient.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ private TemplateSpec GetAzureSdkTemplateSpec(
136136
catch (Exception ex)
137137
{
138138
if (!throwIfNotExists &&
139-
ex is DefaultErrorResponseException dex &&
139+
ex is TemplateSpecsErrorException dex &&
140140
dex.Response.StatusCode == System.Net.HttpStatusCode.NotFound)
141141
{
142142
// Template spec does not exist
@@ -164,7 +164,7 @@ internal TemplateSpecVersion GetAzureSdkTemplateSpecVersion(
164164
catch (Exception ex)
165165
{
166166
if (!throwIfNotExists &&
167-
ex is DefaultErrorResponseException dex &&
167+
ex is TemplateSpecsErrorException dex &&
168168
dex.Response.StatusCode == System.Net.HttpStatusCode.NotFound)
169169
{
170170
// Template spec version does not exist

src/Resources/Resources.Test/Resources.Test.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
</ItemGroup>
3232

3333
<ItemGroup>
34-
<PackageReference Update="Microsoft.Azure.Management.ResourceManager" Version="3.10.0-preview" />
34+
<PackageReference Update="Microsoft.Azure.Management.ResourceManager" Version="3.11.0-preview" />
3535
</ItemGroup>
3636
<ItemGroup>
3737
<PackageReference Include="FluentAssertions" Version="5.9.0" />

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptGetAllDeploymentScriptPropertiesCli.json

Lines changed: 430 additions & 15229 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptGetDeploymentScriptWithBadScript.json

Lines changed: 511 additions & 8323 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptGetForCli.json

Lines changed: 22676 additions & 4211 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptGetForPowerShell.json

Lines changed: 543 additions & 28572 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptLogGetForCli.json

Lines changed: 600 additions & 20634 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptLogGetForPowerShell.json

Lines changed: 558 additions & 19137 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptPipeDeploymentScriptObjectToGetLogs.json

Lines changed: 674 additions & 13904 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptRemoveDeploymentScriptCli.json

Lines changed: 424 additions & 13276 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptRemoveDeploymentScriptPowerShell.json

Lines changed: 539 additions & 19691 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptRemovePipedDeploymentScriptObject.json

Lines changed: 404 additions & 15524 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptTryRemoveNonExistingDeploymentScript.json

Lines changed: 94 additions & 94 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptTrySaveNonExistingFilePathForLogFile.json

Lines changed: 646 additions & 28309 deletions
Large diffs are not rendered by default.

src/Resources/Resources.Test/TemplateScriptDeployment.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
{
4545
"type": "Microsoft.Resources/deploymentScripts",
4646
"name": "[variables('scriptName')]",
47-
"apiVersion": "2019-10-01-preview",
47+
"apiVersion": "2020-10-01",
4848
"location": "[resourceGroup().location]",
4949
"kind": "[parameters('scriptKind')]",
5050
"identity": {

src/Resources/Resources.Test/TemplateScriptDeploymentCli.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
{
4545
"type": "Microsoft.Resources/deploymentScripts",
4646
"name": "[variables('scriptName')]",
47-
"apiVersion": "2019-10-01-preview",
47+
"apiVersion": "2020-10-01",
4848
"location": "[resourceGroup().location]",
4949
"kind": "[parameters('scriptKind')]",
5050
"identity": {

src/Resources/Resources/ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717
* Overview of change #1
1818
- Additional information about change #1
1919
-->
20+
2021
## Upcoming Release
2122
* Fixed a NullRef exception issue in `New-AzureManagedApplication` and `Set-AzureManagedApplication`.
23+
* Updated Azure Resource Manager SDK to use latest DeploymentScripts GA api-version: 2020-10-01.
2224

2325
## Version 3.1.0
2426
* Added `-Tag` parameter support to `Set-AzTemplateSpec` and `New-AzTemplateSpec`

0 commit comments

Comments
 (0)