Keep AssignIdentity parameter with a new parameter set.

Author: hyonholee

src/ResourceManager/Compute/Commands.Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs

@@ -29,7 +29,7 @@
 
 namespace Microsoft.Azure.Commands.Compute.Automation
 {
-    [Cmdlet("New", "AzureRmVmssConfig", SupportsShouldProcess = true)]
+    [Cmdlet("New", "AzureRmVmssConfig", SupportsShouldProcess = true, DefaultParameterSetName = "DefaultParameterSet")]
     [OutputType(typeof(PSVirtualMachineScaleSet))]
     public partial class NewAzureRmVmssConfigCommand : Microsoft.Azure.Commands.ResourceManager.Common.AzureRMCmdlet
     {

src/ResourceManager/Compute/Commands.Compute/Manual/NewAzureRmVmssConfigCommand.cs

@@ -26,12 +26,10 @@ namespace Microsoft.Azure.Commands.Compute.Automation
 {
     public partial class NewAzureRmVmssConfigCommand : Microsoft.Azure.Commands.ResourceManager.Common.AzureRMCmdlet
     {
-
         [Parameter(
-            Mandatory = false)]
-        [Obsolete("This parameter is obsolete.  Please use IdentityType parameter instead.", false)]
+            Mandatory = true,
+            ParameterSetName = "AssignIdentityParameterSet")]
         public SwitchParameter AssignIdentity { get; set; }
-       
     }
 }
 

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Config/NewAzureVMConfigCommand.cs

@@ -23,7 +23,8 @@ namespace Microsoft.Azure.Commands.Compute
 {
     [Cmdlet(
         VerbsCommon.New,
-        ProfileNouns.VirtualMachineConfig),
+        ProfileNouns.VirtualMachineConfig,
+        DefaultParameterSetName = "DefaultParameterSet"),
     OutputType(
         typeof(PSVirtualMachine))]
     public class NewAzureVMConfigCommand : Microsoft.Azure.Commands.ResourceManager.Common.AzureRMCmdlet
@@ -65,9 +66,10 @@ public class NewAzureVMConfigCommand : Microsoft.Azure.Commands.ResourceManager.
         public ResourceIdentityType? IdentityType { get; set; }
 
         [Parameter(
+            Mandatory = true,
+            ParameterSetName = "AssignIdentityParameterSet",
             ValueFromPipelineByPropertyName = false)]
         [ValidateNotNullOrEmpty]
-        [Obsolete("This parameter is obsolete.  Use IdentityType parameter instead.", false)]
         public SwitchParameter AssignIdentity { get; set; }
 
         [Parameter(

src/ResourceManager/Compute/Commands.Compute/help/New-AzureRmVMConfig.md

@@ -13,6 +13,14 @@ Creates a configurable virtual machine object.
 
 ## SYNTAX
 
+### DefaultParameterSet (Default)
+```
+New-AzureRmVMConfig [-VMName] <String> [-VMSize] <String> [[-AvailabilitySetId] <String>]
+ [[-LicenseType] <String>] [[-IdentityType] <ResourceIdentityType>] [-IdentityId <String[]>] [-Zone <String[]>]
+ [-Tags <Hashtable>] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+```
+
+### AssignIdentityParameterSet
 ```
 New-AzureRmVMConfig [-VMName] <String> [-VMSize] <String> [[-AvailabilitySetId] <String>]
  [[-LicenseType] <String>] [[-IdentityType] <ResourceIdentityType>] [-AssignIdentity] [-IdentityId <String[]>]
@@ -44,10 +52,10 @@ Specify the system assigned identity for the virtual machine.
 
 ```yaml
 Type: SwitchParameter
-Parameter Sets: (All)
+Parameter Sets: AssignIdentityParameterSet
 Aliases: 
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

src/ResourceManager/Compute/Commands.Compute/help/New-AzureRmVmssConfig.md

@@ -13,6 +13,21 @@ Creates a VMSS configuration object.
 
 ## SYNTAX
 
+### DefaultParameterSet (Default)
+```
+New-AzureRmVmssConfig [[-Overprovision] <Boolean>] [[-Location] <String>] [[-Tag] <Hashtable>]
+ [[-SkuName] <String>] [[-SkuTier] <String>] [[-SkuCapacity] <Int32>] [[-UpgradePolicyMode] <UpgradeMode>]
+ [[-OsProfile] <VirtualMachineScaleSetOSProfile>] [[-StorageProfile] <VirtualMachineScaleSetStorageProfile>]
+ [[-NetworkInterfaceConfiguration] <VirtualMachineScaleSetNetworkConfiguration[]>]
+ [[-Extension] <VirtualMachineScaleSetExtension[]>] [-SinglePlacementGroup <Boolean>] [-Zone <String[]>]
+ [-PlanName <String>] [-PlanPublisher <String>] [-PlanProduct <String>] [-PlanPromotionCode <String>]
+ [-RollingUpgradePolicy <RollingUpgradePolicy>] [-AutoOSUpgrade] [-HealthProbeId <String>]
+ [-BootDiagnostic <BootDiagnostics>] [-LicenseType <String>] [-Priority <String>]
+ [-IdentityType <ResourceIdentityType>] [-IdentityId <String[]>] [-DefaultProfile <IAzureContextContainer>]
+ [-WhatIf] [-Confirm] [<CommonParameters>]
+```
+
+### AssignIdentityParameterSet
 ```
 New-AzureRmVmssConfig [[-Overprovision] <Boolean>] [[-Location] <String>] [[-Tag] <Hashtable>]
  [[-SkuName] <String>] [[-SkuTier] <String>] [[-SkuCapacity] <Int32>] [[-UpgradePolicyMode] <UpgradeMode>]
@@ -63,10 +78,10 @@ Specify the system assigned identity for the virtual machine scale set.
 
 ```yaml
 Type: SwitchParameter
-Parameter Sets: (All)
+Parameter Sets: AssignIdentityParameterSet
 Aliases: 
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

src/ResourceManager/Compute/documentation/upcoming-breaking-changes.md

@@ -1,54 +1,9 @@
-<!--
-    Please leave this section at the top of the breaking change documentation.
-
-    New breaking changes should go under the section titled "Upcoming Breaking Changes", and should adhere to the following format:
-
-    # Upcoming Breaking Changes
-
-    ## Release X.0.0 - January 2017
-
-    The following cmdlets were affected this release:
-
-    **Cmdlet 1**
-    - Description of what has changed
-
-    ```powershell
-    # Old
-    # Sample of how the cmdlet was previously called
-
-    # New
-    # Sample of how the cmdlet should now be called
-    ```
-
-    Note: the above section follows the template found in the link below: 
-
-    https://github.com/Azure/azure-powershell/blob/dev/documentation/breaking-changes/breaking-change-template.md
--->
-
 # Upcoming Breaking Changes
 
 ## Release X.0.0 - May 2018
 
 The following cmdlets were affected this release:
 
-**New-AzureRmVMConfig**
-**Update-AzureRmVM**
-**New-AzureRmVmssConfig**
-- Switch parameter, AssignIdentity, will be replaced with IdentityType parameter which takes a value from 'SystemAssigned', 'UserAssigned', 'SystemAssignedUserAssinged', and 'None'.
-Previously, only 'SystemAssigned' identity type was available, and AssignIdentity parameter sets 'SystemAssigned' identity.  
-Now, more types of identities are available, so new parameter 'IdentityType' is introduced and will replace 'AssignIdentity' parameter.
-
-```powershell
-# Old
-# New-AzureRmVMConfig -AssignIdentity
-# New-AzureRmVmssConfig -AssignIdentity
-
-
-# New
-# New-AzureRmVMConfig -IdentityType 'SystemAssigned'
-# New-AzureRmVmssConfig -IdentityType 'SystemAssigned'
-```
-
 **New-AzureRmAvailabilitySet**
 - Switch parameter, Managed, will be replaced with Sku parameter.
 In order to set a managed availability set, a user should give Sku parameter with 'Aligned' value.