Skip to content

Commit 4ed2091

Browse files
committed
Merge pull request #46 from huangpf/dev
Dev
2 parents 594101b + 9b51c08 commit 4ed2091

File tree

5 files changed

+1718
-974
lines changed

5 files changed

+1718
-974
lines changed

src/ServiceManagement/Common/Commands.ScenarioTest/Resources/ServiceManagement/Files/LongRoleName.Cloud.cscfg

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
99
**********************************************************************************************
1010
-->
11-
<ServiceConfiguration serviceName="AzureCloudService2" xmlns="http://schemas.microsoft.com/ServiceHosting/2008/10/ServiceConfiguration" osFamily="4" osVersion="*" schemaVersion="2015-04.2.6">
12-
<Role name="WebRole1">
11+
<ServiceConfiguration serviceName="WindowsAzure1" xmlns="http://schemas.microsoft.com/ServiceHosting/2008/10/ServiceConfiguration" osFamily="4" osVersion="*" schemaVersion="2014-01.2.3">
12+
<Role name="WebRole1 With Spaces In Name">
1313
<Instances count="1" />
1414
<ConfigurationSettings>
1515
<Setting name="Microsoft.WindowsAzure.Plugins.Diagnostics.ConnectionString" value="UseDevelopmentStorage=true" />

src/ServiceManagement/Common/Commands.ScenarioTest/Resources/ServiceManagement/ServiceManagementTests.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -564,11 +564,11 @@ function Run-ServiceDeploymentExtensionCmdletTests
564564
}
565565
$cscfg = '.\Resources\ServiceManagement\Files\LongRoleName.Cloud.cscfg';
566566

567-
$webRoleShortName = "WebRole1";
567+
$webRoleNameWithSpaces = "WebRole1 With Spaces In Name";
568568
$workerRoleLongName = "Microsoft.Contoso.Department.ProjectCodeName.Worker";
569-
$rdpCfg1 = New-AzureServiceRemoteDesktopExtensionConfig -Credential $credential -Role $webRoleShortName
569+
$rdpCfg1 = New-AzureServiceRemoteDesktopExtensionConfig -Credential $credential -Role $webRoleNameWithSpaces
570570
$rdpCfg2 = New-AzureServiceRemoteDesktopExtensionConfig -Credential $credential -Role $workerRoleLongName;
571-
$adCfg1 = New-AzureServiceADDomainExtensionConfig -Role $webRoleShortName -WorkgroupName 'test1';
571+
$adCfg1 = New-AzureServiceADDomainExtensionConfig -Role $webRoleNameWithSpaces -WorkgroupName 'test1';
572572
$adCfg2 = New-AzureServiceADDomainExtensionConfig -Role $workerRoleLongName -WorkgroupName 'test2';
573573

574574
$st = New-AzureDeployment -ServiceName $svcName -Package $cspkg -Configuration $cscfg -Label $svcName -Slot Production -ExtensionConfiguration $rdpCfg1,$adCfg1;

src/ServiceManagement/Common/Commands.ScenarioTest/SessionRecords/Microsoft.WindowsAzure.Commands.ScenarioTest.ServiceManagementTests/RunServiceDeploymentExtensionCmdletTests.json

Lines changed: 1711 additions & 969 deletions
Large diffs are not rendered by default.

src/ServiceManagement/Compute/Commands.ServiceManagement/Extensions/Common/ExtensionRole.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public ExtensionRole(string roleName)
4949
{
5050
PrefixName = RoleName = roleName.Trim();
5151
PrefixName = PrefixName.Replace(".", string.Empty);
52+
PrefixName = PrefixName.Replace(" ", string.Empty);
5253
RoleType = ExtensionRoleType.NamedRoles;
5354
Default = false;
5455
}
@@ -62,6 +63,7 @@ public override string ToString()
6263
public string GetExtensionId(string extensionName, string slot, int index)
6364
{
6465
var normalizedExtName = extensionName.Replace(".", string.Empty);
66+
normalizedExtName = normalizedExtName.Replace(" ", string.Empty);
6567

6668
var suffix = new StringBuilder();
6769
suffix.AppendFormat(ExtensionIdSuffixTemplate, normalizedExtName, slot, index);

0 commit comments

Comments
 (0)