Skip to content

Commit 4f0583f

Browse files
authored
[KeyVault] Fixed CertificateString decoding issue in Import-AzKeyVaultCertificate (#20172)
* Fixed CertificateString decoding issue in Import-AzKeyVaultCertificate * add change log * update MD
1 parent 02e8db0 commit 4f0583f

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

src/KeyVault/KeyVault/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Fixed CertificateString decoding issue in `Import-AzKeyVaultCertificate`
2122
* Shifted the location of key CVM release policy to GitHub [#19984]
2223
* Added fallback logic (reading default CVM policy from a local copy) if fetching default CVM Policy from GitHub failed.
2324

src/KeyVault/KeyVault/Track2Models/Track2KeyVaultDataServiceClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ public IEnumerable<PSDeletedKeyVaultCertificateIdentityItem> GetDeletedCertifica
241241

242242
public PSKeyVaultCertificate ImportCertificate(string vaultName, string certName, string certificate, SecureString certPassword, IDictionary<string, string> tags, string contentType = Constants.Pkcs12ContentType)
243243
{
244-
return VaultClient.ImportCertificate(vaultName, certName, Encoding.ASCII.GetBytes(certificate), certPassword, tags, contentType);
244+
return VaultClient.ImportCertificate(vaultName, certName, Convert.FromBase64String(certificate), certPassword, tags, contentType);
245245
}
246246

247247
public PSKeyVaultCertificate ImportCertificate(string vaultName, string certName, byte[] certificate, SecureString certPassword, IDictionary<string, string> tags, string contentType = Constants.Pkcs12ContentType)

src/KeyVault/KeyVault/help/Import-AzKeyVaultCertificate.md

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ Import-AzKeyVaultCertificate [-VaultName] <String> [-Name] <String> -FilePath <S
2323
### ImportWithPrivateKeyFromString
2424
```
2525
Import-AzKeyVaultCertificate [-VaultName] <String> [-Name] <String> -CertificateString <String>
26-
[-Password <SecureString>] [-Tag <Hashtable>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
27-
[<CommonParameters>]
26+
[-ContentType <String>] [-Password <SecureString>] [-Tag <Hashtable>]
27+
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2828
```
2929

3030
### ImportWithPrivateKeyFromCollection
@@ -151,6 +151,21 @@ Accept pipeline input: False
151151
Accept wildcard characters: False
152152
```
153153
154+
### -ContentType
155+
Specifies the type of the certificate to be imported. Regards certificate string as PFX format by default.
156+
157+
```yaml
158+
Type: System.String
159+
Parameter Sets: ImportWithPrivateKeyFromString
160+
Aliases:
161+
162+
Required: False
163+
Position: Named
164+
Default value: None
165+
Accept pipeline input: False
166+
Accept wildcard characters: False
167+
```
168+
154169
### -DefaultProfile
155170
The credentials, account, tenant, and subscription used for communication with azure
156171

0 commit comments

Comments
 (0)