update test records

Author: yugangw-msft

src/ResourceManager/Common/Commands.ResourceManager.Common/Commands.ResourceManager.Common.csproj

@@ -268,6 +268,7 @@
     <Compile Include="Generated\TagOperationsExtensions.cs" />
     <Compile Include="Generated\TenantOperations.cs" />
     <Compile Include="Generated\TenantOperationsExtensions.cs" />
+    <Compile Include="GlobalSuppressions.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Properties\Resources.Designer.cs">
       <AutoGen>True</AutoGen>

src/ResourceManager/Common/Commands.ResourceManager.Common/GlobalSuppressions.cs

@@ -0,0 +1,14 @@
+// This file is used by Code Analysis to maintain SuppressMessage 
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given 
+// a specific target and scoped to a namespace, type, member, etc.
+//
+// To add a suppression to this file, right-click the message in the 
+// Code Analysis results, point to "Suppress Message", and click 
+// "In Suppression File".
+// You do not need to add suppressions to this file manually.
+
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1063:ImplementIDisposableCorrectly", Scope = "type", Target = "Microsoft.Azure.Management.Internal.Resources.AuthorizationClient")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1063:ImplementIDisposableCorrectly", Scope = "type", Target = "Microsoft.Azure.Management.Internal.Resources.FeatureClient")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1063:ImplementIDisposableCorrectly", Scope = "type", Target = "Microsoft.Azure.Management.Internal.Resources.ResourceManagementClient")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1063:ImplementIDisposableCorrectly", Scope = "type", Target = "Microsoft.Azure.Internal.Subscriptions.SubscriptionClient")]

src/ResourceManager/Profile/Commands.Profile.Test/AzureRMProfileTests.cs

@@ -65,9 +65,11 @@ private static RMProfileClient SetupTestEnvironment(List<string> tenants, params
         public void MultipleTenantsAndSubscriptionsSucceed()
         {
             var tenants = new List<string> {Guid.NewGuid().ToString(), DefaultTenant.ToString()};
-            var firstList = new List<string> { DefaultSubscription.ToString(), Guid.NewGuid().ToString() };
+            var secondsubscriptionInTheFirstTenant = Guid.NewGuid().ToString();
+            var firstList = new List<string> { DefaultSubscription.ToString(), secondsubscriptionInTheFirstTenant};
             var secondList = new List<string> { Guid.NewGuid().ToString()};
-            var client = SetupTestEnvironment(tenants, firstList, secondList);
+            var thirdList = new List<string> { DefaultSubscription.ToString(), secondsubscriptionInTheFirstTenant };
+            var client = SetupTestEnvironment(tenants, firstList, secondList, thirdList);
             var subResults = new List<AzureSubscription>(client.ListSubscriptions());
             Assert.Equal(3, subResults.Count);
             var tenantResults = client.ListTenants();
@@ -84,8 +86,9 @@ public void MultipleTenantsAndSubscriptionsSucceed()
         public void SingleTenantAndSubscriptionSucceeds()
         {
             var tenants = new List<string> {DefaultTenant.ToString()};
-            var subscriptions = new List<string> {DefaultSubscription.ToString()};
-            var client = SetupTestEnvironment(tenants, subscriptions);
+            var firstList = new List<string> {DefaultSubscription.ToString()};
+            var secondList = firstList;
+            var client = SetupTestEnvironment(tenants, firstList, secondList);
             var subResults = new List<AzureSubscription>(client.ListSubscriptions());
             Assert.Equal(1, subResults.Count);
             var tenantResults = client.ListTenants();
@@ -102,12 +105,14 @@ public void SingleTenantAndSubscriptionSucceeds()
         public void SubscriptionNotFoundDoesNotThrow()
         {
             var tenants = new List<string> { DefaultTenant.ToString() };
-            var subscriptions = new List<string> { Guid.NewGuid().ToString() };
-            var client = SetupTestEnvironment(tenants, subscriptions);
+            string randomSubscriptionId = Guid.NewGuid().ToString();
+            var firstList = new List<string> { randomSubscriptionId };
+            var secondList = firstList;
+            var client = SetupTestEnvironment(tenants, firstList, secondList);
             var subResults = new List<AzureSubscription>(client.ListSubscriptions());
             Assert.Equal(1, subResults.Count);
             AzureSubscription subValue;
-            Assert.True(client.TryGetSubscriptionById(DefaultTenant.ToString(), DefaultSubscription.ToString(), out subValue));
+            Assert.False(client.TryGetSubscriptionById(DefaultTenant.ToString(), DefaultSubscription.ToString(), out subValue));
         }
 
         [Fact]
@@ -130,7 +135,7 @@ public void NoSubscriptionsInListDoesNotThrow()
             var client = SetupTestEnvironment(tenants, subscriptions);
             Assert.Equal(0, client.ListSubscriptions().Count());
             AzureSubscription subValue;
-            Assert.True(client.TryGetSubscriptionById(DefaultTenant.ToString(), DefaultSubscription.ToString(), out subValue));
+            Assert.False(client.TryGetSubscriptionById(DefaultTenant.ToString(), DefaultSubscription.ToString(), out subValue));
         }
 
         [Fact]