Fixing daviburg's CR comments

Author: REDMOND\yisha

src/ResourceManager/LogicApp/Commands.LogicApp/Cmdlets/IntegrationAccount/GetAzureIntegrationAccountGeneratedIcnCommand.cs

@@ -71,15 +71,15 @@ public override void ExecuteCmdlet()
 
             if (string.IsNullOrEmpty(AgreementType))
             {
-                this.WriteWarning("By default, you are using the X12 agreement. Please provide a value for AgreementType if you would like to specify the agreement type. Possible values are X12 and Edifact.");
+                this.WriteWarning(Constants.NoAgreementTypeParameterWarningMessage);
             }
 
             this.WriteObject(
                 sendToPipeline: string.IsNullOrEmpty(this.AgreementName) ?
                     this.IntegrationAccountClient.ListIntegrationAccountGeneratedIcns(
                         resourceGroupName: this.ResourceGroupName,
                         integrationAccountName: this.Name,
-                        agreementType: (AgreementType)Enum.Parse(typeof(AgreementType), AgreementType, true)) as object :
+                        agreementType: (AgreementType)Enum.Parse(enumType: typeof(AgreementType), value: AgreementType, ignoreCase: true)) as object :
                     this.IntegrationAccountClient.GetIntegrationAccountGeneratedIcn(
                         resourceGroupName: this.ResourceGroupName,
                         integrationAccountName: this.Name,

src/ResourceManager/LogicApp/Commands.LogicApp/Cmdlets/IntegrationAccount/GetAzureIntegrationAccountReceivedIcnCommand.cs

@@ -77,15 +77,15 @@ public override void ExecuteCmdlet()
 
             if (string.IsNullOrEmpty(AgreementType))
             {
-                this.WriteWarning("By default, you are using the X12 agreement. Please provide a value for AgreementType if you would like to specify the agreement type. Possible values are X12 and Edifact.");
+                this.WriteWarning(Constants.NoAgreementTypeParameterWarningMessage);
             }
 
             this.WriteObject(
                 sendToPipeline: this.IntegrationAccountClient.GetIntegrationAccountReceivedControlNumber(
                     resourceGroupName: this.ResourceGroupName,
                     integrationAccountName: this.Name,
                     integrationAccountAgreementName: this.AgreementName,
-                    agreementType: (AgreementType)Enum.Parse(typeof(AgreementType), AgreementType, true),
+                    agreementType: (AgreementType)Enum.Parse(enumType: typeof(AgreementType), value: AgreementType, ignoreCase: true),
                     controlNumber: this.ControlNumberValue));
         }
     }

src/ResourceManager/LogicApp/Commands.LogicApp/Cmdlets/IntegrationAccount/RemoveAzureIntegrationAccountReceivedIcnCommand.cs

@@ -71,7 +71,7 @@ public override void ExecuteCmdlet()
 
             if (string.IsNullOrEmpty(AgreementType))
             {
-                this.WriteWarning("By default, you are using the X12 agreement. Please provide a value for AgreementType if you would like to specify the agreement type. Possible values are X12 and Edifact.");
+                this.WriteWarning(Constants.NoAgreementTypeParameterWarningMessage);
             }
 
             this.ConfirmAction(
@@ -82,7 +82,7 @@ public override void ExecuteCmdlet()
                         resourceGroupName: this.ResourceGroupName,
                         integrationAccountName: this.Name,
                         integrationAccountAgreementName: this.AgreementName,
-                        agreementType: (AgreementType)Enum.Parse(typeof(AgreementType), AgreementType, true),
+                        agreementType: (AgreementType)Enum.Parse(enumType: typeof(AgreementType), value: AgreementType, ignoreCase: true),
                         controlNumber: this.ControlNumberValue);
                 });
         }

src/ResourceManager/LogicApp/Commands.LogicApp/Cmdlets/IntegrationAccount/UpdateAzureIntegrationAccountGeneratedIcnCommand.cs

@@ -77,15 +77,15 @@ public override void ExecuteCmdlet()
 
             if (string.IsNullOrEmpty(AgreementType))
             {
-                this.WriteWarning("By default, you are using the X12 agreement. Please provide a value for AgreementType if you would like to specify the agreement type. Possible values are X12 and Edifact.");
+                this.WriteWarning(Constants.NoAgreementTypeParameterWarningMessage);
             }
 
             var integrationAccountGeneratedIcn = this.IntegrationAccountClient.GetIntegrationAccountGeneratedIcn(
                 resourceGroupName: this.ResourceGroupName,
                 integrationAccountName: this.Name,
                 integrationAccountAgreementName: this.AgreementName);
 
-            integrationAccountGeneratedIcn.MessageType = (MessageType)Enum.Parse(typeof(MessageType), AgreementType, true);
+            integrationAccountGeneratedIcn.MessageType = (MessageType)Enum.Parse(enumType: typeof(MessageType), value: AgreementType, ignoreCase: true);
             integrationAccountGeneratedIcn.ControlNumber = this.ControlNumber;
             integrationAccountGeneratedIcn.ControlNumberChangedTime = DateTime.UtcNow > integrationAccountGeneratedIcn.ControlNumberChangedTime ?
                 DateTime.UtcNow :

src/ResourceManager/LogicApp/Commands.LogicApp/Cmdlets/IntegrationAccount/UpdateAzureIntegrationAccountReceivedIcnCommand.cs

@@ -85,17 +85,17 @@ public override void ExecuteCmdlet()
 
             if (string.IsNullOrEmpty(AgreementType))
             {
-                this.WriteWarning("By default, you are using the X12 agreement. Please provide a value for AgreementType if you would like to specify the agreement type. Possible values are X12 and Edifact.");
+                this.WriteWarning(Constants.NoAgreementTypeParameterWarningMessage);
             }
 
             var integrationAccountReceivedIcn = this.IntegrationAccountClient.GetIntegrationAccountReceivedControlNumber(
                 resourceGroupName: this.ResourceGroupName,
                 integrationAccountName: this.Name,
                 integrationAccountAgreementName: this.AgreementName,
-                agreementType: (AgreementType)Enum.Parse(typeof(AgreementType), AgreementType, true),
+                agreementType: (AgreementType)Enum.Parse(enumType: typeof(AgreementType), value: AgreementType, ignoreCase: true),
                 controlNumber: this.ControlNumberValue);
 
-            integrationAccountReceivedIcn.MessageType = (MessageType)Enum.Parse(typeof(MessageType), AgreementType, true);
+            integrationAccountReceivedIcn.MessageType = (MessageType)Enum.Parse(enumType: typeof(MessageType), value: AgreementType, ignoreCase: true);
             integrationAccountReceivedIcn.ControlNumber = this.ControlNumberValue;
             integrationAccountReceivedIcn.IsMessageProcessingFailed = this.IsMessageProcessingFailed;
             integrationAccountReceivedIcn.ControlNumberChangedTime = DateTime.UtcNow > integrationAccountReceivedIcn.ControlNumberChangedTime ?
@@ -112,7 +112,7 @@ public override void ExecuteCmdlet()
                             resourceGroupName: this.ResourceGroupName,
                             integrationAccountName: this.Name,
                             integrationAccountAgreementName: this.AgreementName,
-                            agreementType: (AgreementType)Enum.Parse(typeof(AgreementType), AgreementType, true),
+                            agreementType: (AgreementType)Enum.Parse(enumType: typeof(AgreementType), value: AgreementType, ignoreCase: true),
                             integrationAccountControlNumber: integrationAccountReceivedIcn),
                         enumerateCollection: true);
                 });

src/ResourceManager/LogicApp/Commands.LogicApp/Utilities/Constants.cs

@@ -44,5 +44,7 @@ public class Constants
         /// Suffix in session id to represent is acknowledgement message
         /// </summary>
         public const string IsAcknowledgementSessionIdSuffix = "-ACK";
+
+        public const string NoAgreementTypeParameterWarningMessage = "By default, you are using the X12 agreement type. Please provide a value for AgreementType if you would like to specify the agreement type. Possible values are X12 and Edifact.";
     }
 }