rebased and PR comments

Author: henry416

src/Network/Network.Test/ScenarioTests/VirtualNetworkGatewayTests.ps1

@@ -688,7 +688,7 @@ function Test-VirtualNetworkGatewayRadius
 		$vnetIpConfig = New-AzVirtualNetworkGatewayIpConfig -Name $vnetGatewayConfigName -PublicIpAddress $publicip -Subnet $subnet
 
 		# Create & Get virtualnetworkgateway
-		New-AzVirtualNetworkGateway -ResourceGroupName $rgname -name $rname -location $location -IpConfigurations $vnetIpConfig -GatewayType Vpn -VpnType RouteBased -EnableBgp $false -GatewaySku VpnGw1 -VpnClientAddressPool 201.169.0.0/16 -VpnClientProtocol "IkeV2" -RadiusServers $radiusServers
+		New-AzVirtualNetworkGateway -ResourceGroupName $rgname -name $rname -location $location -IpConfigurations $vnetIpConfig -GatewayType Vpn -VpnType RouteBased -EnableBgp $false -GatewaySku VpnGw1 -VpnClientAddressPool 201.169.0.0/16 -VpnClientProtocol "IkeV2" -RadiusServerList $radiusServers
 		$actual = Get-AzVirtualNetworkGateway -ResourceGroupName $rgname -name $rname
         Assert-AreEqual $actual.VpnClientConfiguration.RadiusServers.Count 2 
 		Assert-AreEqual $actual.VpnClientConfiguration.RadiusServers[0].RadiusServerAddress $radiusServer1.RadiusServerAddress
@@ -698,7 +698,7 @@ function Test-VirtualNetworkGatewayRadius
 
 		# Update gateway radius settings
         $radiusServers = @($radiusServer3, $radiusServer1)
-		Set-AzVirtualNetworkGateway -VirtualNetworkGateway $actual -VpnClientAddressPool 201.169.0.0/16 -VpnClientProtocol "IkeV2" -RadiusServers $radiusServers
+		Set-AzVirtualNetworkGateway -VirtualNetworkGateway $actual -VpnClientAddressPool 201.169.0.0/16 -VpnClientProtocol "IkeV2" -RadiusServerList $radiusServers
 		$actual = Get-AzVirtualNetworkGateway -ResourceGroupName $rgname -name $rname
         Assert-AreEqual $actual.VpnClientConfiguration.RadiusServers.Count 2 
 		Assert-AreEqual $actual.VpnClientConfiguration.RadiusServers[0].RadiusServerAddress $radiusServer3.RadiusServerAddress

src/Network/Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.VirtualNetworkGatewayTests/VirtualNetworkGatewayRadiusTest.json

@@ -105,7 +105,7 @@ public class NewAzureRmVpnServerConfigurationCommand : VpnServerConfigurationBas
             ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByRadiusAuthentication,
             HelpMessage = "P2S External multiple radius servers.")]
         [ValidateNotNullOrEmpty]
-        public PSRadiusServer[] RadiusServers { get; set; }
+        public PSRadiusServer[] RadiusServerList { get; set; }
 
         [Parameter(
             Mandatory = false,
@@ -179,7 +179,7 @@ public override void Execute()
                 this.VpnClientRevokedCertificateFilesList,
                 this.RadiusServerAddress,
                 this.RadiusServerSecret,
-                this.RadiusServers,
+                this.RadiusServerList,
                 this.RadiusServerRootCertificateFilesList,
                 this.RadiusClientRootCertificateFilesList,
                 this.AadTenant,

src/Network/Network/Cortex/VpnServerConfiguration/NewAzureRmVpnServerConfigurationCommand.cs

@@ -200,7 +200,7 @@ public class UpdateAzureRmVpnServerConfigurationCommand : VpnServerConfiguration
             ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationResourceId + CortexParameterSetNames.ByRadiusAuthentication,
             HelpMessage = "P2S External multiple radius servers.")]
         [ValidateNotNullOrEmpty]
-        public PSRadiusServer[] RadiusServers { get; set; }
+        public PSRadiusServer[] RadiusServerList { get; set; }
 
         [Parameter(
             Mandatory = false,
@@ -389,7 +389,7 @@ public override void Execute()
                     vpnServerConfigurationToUpdate.RadiusServerSecret = SecureStringExtensions.ConvertToString(this.RadiusServerSecret);
                 }
 
-                vpnServerConfigurationToUpdate.RadiusServers = this.RadiusServers?.ToList();
+                vpnServerConfigurationToUpdate.RadiusServers = this.RadiusServerList?.ToList();
 
                 // Read the RadiusServerRootCertificates if present
                 if (this.RadiusServerRootCertificateFilesList != null)

src/Network/Network/Cortex/VpnServerConfiguration/UpdateAzureRmVpnServerConfigurationCommand.cs

@@ -250,7 +250,7 @@ public class NewAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBaseCmd
             ValueFromPipelineByPropertyName = true,
             ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
             HelpMessage = "P2S multiple external Radius server servers.")]
-        public PSRadiusServer[] RadiusServers { get; set; }
+        public PSRadiusServer[] RadiusServerList { get; set; }
 
         [Parameter(
             Mandatory = true,
@@ -440,9 +440,9 @@ private PSVirtualNetworkGateway CreateVirtualNetworkGateway()
                     vnetGateway.VpnClientConfiguration.RadiusServerSecret = SecureStringExtensions.ConvertToString(this.RadiusServerSecret);
                 }
 
-                if (this.RadiusServers != null && this.RadiusServers.Any())
+                if (this.RadiusServerList != null && this.RadiusServerList.Any())
                 {
-                    vnetGateway.VpnClientConfiguration.RadiusServers = this.RadiusServers?.ToList();
+                    vnetGateway.VpnClientConfiguration.RadiusServers = this.RadiusServerList?.ToList();
                 }
 
                 if (this.AadTenantUri != null)

src/Network/Network/VirtualNetworkGateway/NewAzureVirtualNetworkGatewayCommand.cs

@@ -175,7 +175,7 @@ public class SetAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBaseCmd
             ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration + VirtualNetworkGatewayParameterSets.UpdateResourceWithTags,
             HelpMessage = "P2S multiple external Radius servers.")]
         [ValidateNotNullOrEmpty]
-        public PSRadiusServer[] RadiusServers { get; set; }
+        public PSRadiusServer[] RadiusServerList { get; set; }
 
         [Parameter(
             Mandatory = true,
@@ -278,7 +278,7 @@ public override void Execute()
                  this.VpnClientRevokedCertificates != null ||
                  this.RadiusServerAddress != null ||
                  this.RadiusServerSecret != null ||
-                 this.RadiusServers != null ||
+                 this.RadiusServerList != null ||
                  (this.VpnClientIpsecPolicy != null && this.VpnClientIpsecPolicy.Length != 0) ||
                  this.AadTenantUri != null) &&
                 this.VirtualNetworkGateway.VpnClientConfiguration == null)
@@ -324,7 +324,7 @@ public override void Execute()
                     this.VirtualNetworkGateway.VpnClientConfiguration.RadiusServerSecret = SecureStringExtensions.ConvertToString(this.RadiusServerSecret);
                 }
 
-                this.VirtualNetworkGateway.VpnClientConfiguration.RadiusServers = this.RadiusServers?.ToList();
+                this.VirtualNetworkGateway.VpnClientConfiguration.RadiusServers = this.RadiusServerList?.ToList();
             }
 
             if (ParameterSetName.Contains(VirtualNetworkGatewayParameterSets.AadAuthenticationConfiguration))