Addressed comments.

Author: jobatzil

src/ResourceManager/Network/Commands.Network/ApplicationGateway/SslCertificate/AzureApplicationGatewaySslCertificateBase.cs

@@ -46,9 +46,7 @@ public PSApplicationGatewaySslCertificate NewObject()
 
             sslCertificate.Name = this.Name;
             sslCertificate.Data = Convert.ToBase64String(File.ReadAllBytes(this.CertificateFile));
-#pragma warning disable 0618
             sslCertificate.Password = this.Password;
-#pragma warning restore 0618
             sslCertificate.Id =
                 ApplicationGatewayChildResourceHelper.GetResourceNotSetId(
                     this.NetworkClient.NetworkManagementClient.SubscriptionId,

src/ResourceManager/Network/Commands.Network/ApplicationGateway/SslCertificate/SetAzureApplicationGatewaySslCertificateCommand.cs

@@ -39,10 +39,8 @@ public override void ExecuteCmdlet()
             {
                 throw new ArgumentException("Ssl certificate with the specified name does not exist");
             }
-
-#pragma warning disable 0618
-            X509Certificate2 cert = new X509Certificate2(CertificateFile, Password, X509KeyStorageFlags.Exportable);
-#pragma warning restore 0618
+            
+            X509Certificate2 cert = new X509Certificate2(this.CertificateFile, this.Password, X509KeyStorageFlags.Exportable);
 
             var newSslCertificate = base.NewObject();
 

src/ResourceManager/Network/documentation/current-breaking-changes.md

@@ -38,19 +38,4 @@
     https://github.com/Azure/azure-powershell/blob/dev/documentation/breaking-changes/breaking-change-template.md
 -->
 
-## Current Breaking Changes
-
-The following cmdlets were affected this release:
-
-**(Add/New/Set)-AzureRmApplicationGatewaySslCertificate**
-- Changed type of parameter ``-Password`` from ``String`` to ``SecureString``.
-
-```powershell
-
-# Old
-(Add/New/Set)-AzureRmApplicationGatewaySslCertificate [other required parameters] -Password "P@ssw0rd"
-
-# New
-$password = ConvertTo-SecureString "P@ssw0rd" -AsPlainText -Force
-(Add/New/Set)-AzureRmApplicationGatewaySslCertificate [other required parameters] -Password $password
-```
+## Current Breaking Changes

src/ResourceManager/Network/documentation/upcoming-breaking-changes.md

@@ -25,4 +25,18 @@
     https://github.com/Azure/azure-powershell/blob/dev/documentation/breaking-changes/breaking-change-template.md
 -->
 
-# Upcoming Breaking Changes
+# Upcoming Breaking Changes
+
+The following cmdlets were affected this release:
+
+**(Get/Set/New)-AzureRmApplicationGatewaySslCertificate**
+- Parameter "Password" being replaced in favor of a SecureString
+
+```powershell
+
+# Old
+# (Get/Set/New)-AzureRmApplicationGatewaySslCertificate [other required parameters] -Password "plain-text string"
+
+# New
+# (Get/Set/New)-AzureRmApplicationGatewaySslCertificate [other required parameters] -Password $SecureStringVariable
+```

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

@@ -680,4 +680,11 @@
 "Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmVmssConfigCommand","New-AzureRmVmssConfig","0","2000","The cmdlet 'New-AzureRmVmssConfig' no longer supports the parameter 'RecoveryPolicyMode' and no alias was found for the original parameter name.","Add the parameter 'RecoveryPolicyMode' back to the cmdlet 'New-AzureRmVmssConfig', or add an alias to the original parameter name."
 "Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmVmssConfigCommand","New-AzureRmVmssConfig","0","2080","The parameter 'AutoOSUpgrade' in parameter set '__AllParameterSets' for cmdlet 'New-AzureRmVmssConfig' no longer has the attribute 'ValueFromPipelineByPropertyName'.","Add the attribute 'ValueFromPipelineByPropertyName' back to parameter 'AutoOSUpgrade' in parameter set '__AllParameterSets'."
 "Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmVmssConfigCommand","New-AzureRmVmssConfig","0","2100","The parameter 'IdentityType' in cmdlet 'New-AzureRmVmssConfig' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'IdentityType' back to the parameter set '__AllParameterSets'."
-"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmVmssConfigCommand","New-AzureRmVmssConfig","0","2100","The parameter 'RecoveryPolicyMode' in cmdlet 'New-AzureRmVmssConfig' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'RecoveryPolicyMode' back to the parameter set '__AllParameterSets'."
+"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmVmssConfigCommand","New-AzureRmVmssConfig","0","2100","The parameter 'RecoveryPolicyMode' in cmdlet 'New-AzureRmVmssConfig' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'RecoveryPolicyMode' back to the parameter set '__AllParameterSets'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.AddAzureApplicationGatewayHttpListenerCommand","Add-AzureRmApplicationGatewayHttpListener","0","3000","The type of property 'Password' of type 'Microsoft.Azure.Commands.Network.Models.PSApplicationGatewaySslCertificate' has changed from 'System.String' to 'System.Security.SecureString'.","Change the type of property 'Password' back to 'System.String'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.SetAzureApplicationGatewayHttpListenerCommand","Set-AzureRmApplicationGatewayHttpListener","0","3000","The type of property 'Password' of type 'Microsoft.Azure.Commands.Network.Models.PSApplicationGatewaySslCertificate' has changed from 'System.String' to 'System.Security.SecureString'.","Change the type of property 'Password' back to 'System.String'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.AddAzureApplicationGatewaySslCertificateCommand","Add-AzureRmApplicationGatewaySslCertificate","0","2020","The cmdlet 'Add-AzureRmApplicationGatewaySslCertificate' no longer supports the type 'System.String' for parameter 'Password'.","Change the type for parameter 'Password' back to 'System.String'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureApplicationGatewaySslCertificate","Get-AzureRmApplicationGatewaySslCertificate","0","3000","The type of property 'Password' of type 'Microsoft.Azure.Commands.Network.Models.PSApplicationGatewaySslCertificate' has changed from 'System.String' to 'System.Security.SecureString'.","Change the type of property 'Password' back to 'System.String'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewaySslCertificateCommand","New-AzureRmApplicationGatewaySslCertificate","0","3000","The type of property 'Password' of type 'Microsoft.Azure.Commands.Network.Models.PSApplicationGatewaySslCertificate' has changed from 'System.String' to 'System.Security.SecureString'.","Change the type of property 'Password' back to 'System.String'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewaySslCertificateCommand","New-AzureRmApplicationGatewaySslCertificate","0","2020","The cmdlet 'New-AzureRmApplicationGatewaySslCertificate' no longer supports the type 'System.String' for parameter 'Password'.","Change the type for parameter 'Password' back to 'System.String'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.SetAzureApplicationGatewaySslCertificateCommand","Set-AzureRmApplicationGatewaySslCertificate","0","2020","The cmdlet 'Set-AzureRmApplicationGatewaySslCertificate' no longer supports the type 'System.String' for parameter 'Password'.","Change the type for parameter 'Password' back to 'System.String'."