Fix issue with ApprovedVerbs list that was slowing down SignatureVerifier (#3357)

cormacpayne · shahabhijeet · commit 52ee3a44657f · 2017-01-05T23:57:42.000-08:00
diff --git a/tools/StaticAnalysis/SignatureVerifier/CmdletSignatureMetadata.cs b/tools/StaticAnalysis/SignatureVerifier/CmdletSignatureMetadata.cs
@@ -118,9 +118,9 @@ public class CmdletSignatureMetadata
         #endregion
 
         #region ApprovedVerbs
-        private List<string> ApprovedVerbs;
+        private static List<string> ApprovedVerbs;
 
-        private List<string> GetApprovedVerbs()
+        private static List<string> GetApprovedVerbs()
         {
             if (ApprovedVerbs == null)
             {

Original file line number	Diff line number	Diff line change
`@@ -118,9 +118,9 @@ public class CmdletSignatureMetadata`
`118`	`118`	`#endregion`
`119`	`119`
`120`	`120`	`#region ApprovedVerbs`
`121`		`- private List<string> ApprovedVerbs;`
	`121`	`+ private static List<string> ApprovedVerbs;`
`122`	`122`
`123`		`- private List<string> GetApprovedVerbs()`
	`123`	`+ private static List<string> GetApprovedVerbs()`
`124`	`124`	`{`
`125`	`125`	`if (ApprovedVerbs == null)`
`126`	`126`	`{`