Added virtual network support for Batch cmdlets (#2724)

* Added new models mapping for ps generator

* Models regenerated for new job auto completion and vnets

* Added new models to csproj

* Updated new pool cmdlet with network configuration

* Added network configuration test

* Updated doc for network configuration

* Temporary for recording purposes

* Test fixes for new updates on the service

* Added recordings

* Fixed versioning for Batch cmdlets

* Updated ChangeLog.md for Batch

* Added global filter

* Added cert recordings as exceptions

* Added ShouldProcess

* Fixed test for ShouldProcess

Author: brnleehng

ChangeLog.md

@@ -34,10 +34,13 @@
   * ShouldContinue confirmation needed (suspress with -Force) only when there's data in the Container/Table to delete
     - Remove-AzureStorageContainer
     - Remove-AzureStorageTable
-	
-	
-	
-	
+* Azure Batch
+  * Add virtual network support
+    - New-AzureBatchPool
+  * Change -Tag parameter type from HashTable[] to HashTable
+    - Set-AzureRmBatchAccount
+    - New-AzureRmBatchAccount
+    - Get-AzureRmBatchAccount
 
 ##2016.07.11 version 1.6.0
 * **Behavioral change for -Force, –Confirm and $ConfirmPreference parameters for all cmdlets. We are changing this implementation to be in line with PowerShell guidelines. For most cmdlets, this means removing the Force parameter and to skip the ShouldProcess prompt, users will need to include the parameter: ‘-Confirm:$false’ in their PowerShell scripts.** This changes are addressing following issues:

src/ResourceManager/AzureBatch/BatchModelGenerator/Program.cs

@@ -93,6 +93,11 @@ public class Program
             {"Microsoft.Azure.Batch.WindowsConfiguration", "PSWindowsConfiguration"},
             {"Microsoft.Azure.Batch.ApplicationPackageReference", "PSApplicationPackageReference"},
             {"Microsoft.Azure.Batch.TaskDependencies", "PSTaskDependencies"},
+            {"Microsoft.Azure.Batch.NetworkConfiguration", "PSNetworkConfiguration"},
+            {"Microsoft.Azure.Batch.ExitConditions", "PSExitConditions"},
+            {"Microsoft.Azure.Batch.ExitOptions", "PSExitOptions"},
+            {"Microsoft.Azure.Batch.ExitCodeRangeMapping", "PSExitCodeRangeMapping"},
+            {"Microsoft.Azure.Batch.ExitCodeMapping", "PSExitCodeMapping"},
         };
 
 

src/ResourceManager/AzureBatch/Commands.Batch.Test/Commands.Batch.Test.csproj

@@ -44,9 +44,8 @@
     <Reference Include="Hyak.Common">
       <HintPath>..\..\..\packages\Hyak.Common.1.0.3\lib\portable-net403+win+wpa81\Hyak.Common.dll</HintPath>
     </Reference>
-    <Reference Include="Microsoft.Azure.Batch, Version=4.0.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Azure.Batch.4.0.1\lib\net45\Microsoft.Azure.Batch.dll</HintPath>
-      <Private>True</Private>
+    <Reference Include="Microsoft.Azure.Batch, Version=5.0.0.0, Culture=neutral, processorArchitecture=MSIL">
+      <HintPath>..\..\..\packages\Azure.Batch.5.0.0\lib\net45\Microsoft.Azure.Batch.dll</HintPath>
     </Reference>
     <Reference Include="Microsoft.Azure.Common">
       <HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.dll</HintPath>

src/ResourceManager/AzureBatch/Commands.Batch.Test/Jobs/SetBatchJobCommandTests.cs

@@ -23,6 +23,7 @@
 using System.Management.Automation;
 using Xunit;
 using BatchClient = Microsoft.Azure.Commands.Batch.Models.BatchClient;
+using OnAllTasksComplete = Microsoft.Azure.Batch.Common.OnAllTasksComplete;
 
 namespace Microsoft.Azure.Commands.Batch.Test.Jobs
 {
@@ -55,7 +56,8 @@ public void SetBatchJobParametersTest()
             Assert.Throws<ArgumentNullException>(() => cmdlet.ExecuteCmdlet());
 
             cmdlet.Job = new PSCloudJob(BatchTestHelpers.CreateFakeBoundJob(context));
-
+            cmdlet.Job.OnAllTasksComplete = OnAllTasksComplete.NoAction;
+            
             RequestInterceptor interceptor = BatchTestHelpers.CreateFakeServiceResponseInterceptor<
                 JobUpdateParameter,
                 JobUpdateOptions,

src/ResourceManager/AzureBatch/Commands.Batch.Test/Pools/NewBatchPoolCommandTests.cs

@@ -13,6 +13,7 @@
 // ----------------------------------------------------------------------------------
 
 using Microsoft.Azure.Batch;
+using Microsoft.Azure.Commands.Batch.Models;
 using Microsoft.Azure.Batch.Protocol;
 using Microsoft.Azure.Batch.Protocol.Models;
 using Microsoft.Rest.Azure;
@@ -68,5 +69,41 @@ public void NewBatchPoolParametersTest()
             // Verify no exceptions when required parameters are set
             cmdlet.ExecuteCmdlet();
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void NewBatchPoolNetworkConfigurationParameterTest()
+        {
+            BatchAccountContext context = BatchTestHelpers.CreateBatchContextWithKeys();
+            cmdlet.BatchContext = context;
+
+            var networkConfiguration = new PSNetworkConfiguration();
+            networkConfiguration.SubnetId = "fakeSubnetId";
+
+            cmdlet.Id = "testPool";
+            cmdlet.VirtualMachineSize = "small";
+            cmdlet.NetworkConfiguration = networkConfiguration;
+
+            commandRuntimeMock.Setup(f => f.ShouldProcess(It.IsAny<string>())).Returns(true);
+            
+            string subnetId = null;
+
+            Action<BatchRequest<
+                PoolAddParameter,
+                PoolAddOptions,
+                AzureOperationHeaderResponse<PoolAddHeaders>>> extractPoolAction =
+                (request) =>
+                {
+                    subnetId = request.Parameters.NetworkConfiguration.SubnetId;
+                };
+
+            RequestInterceptor interceptor = BatchTestHelpers.CreateFakeServiceResponseInterceptor(requestAction: extractPoolAction);
+
+            cmdlet.AdditionalBehaviors = new List<BatchClientBehavior>() { interceptor };
+
+            cmdlet.ExecuteCmdlet();
+
+            Assert.Equal(cmdlet.NetworkConfiguration.SubnetId, subnetId);
+        }
     }
 }

src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/PoolTests.cs

@@ -23,7 +23,7 @@ public class PoolTests : WindowsAzure.Commands.Test.Utilities.Common.RMTestBase
         private const string testPoolId = ScenarioTestHelpers.SharedPool;
 
         // Get from WATaskOSFamilyVersions table, which lags behind https://azure.microsoft.com/en-us/documentation/articles/cloud-services-guestos-update-matrix/
-        private const string specificOSVersion = "WA-GUEST-OS-4.27_201512-01";
+        private const string specificOSVersion = "WA-GUEST-OS-4.32_201605-01";
 
         public PoolTests(Xunit.Abstractions.ITestOutputHelper output)
         {