Merge pull request #7242 from Azure/maddieclayton-patch-1

Update piping-in-powershell.md

Author: Maddie Clayton

documentation/development-docs/piping-in-powershell.md

@@ -192,30 +192,27 @@ For example, you have a `Remove-AzureRmFoo` cmdlet with the following parameters
 
 ```cs
 [Parameter(ParameterSetName = "ByPropertyName", ValueFromPipelineByPropertyName = true)]
-public string Name { get; set; }
-
-[Parameter(ParameterSetName = "ByPropertyName", ValueFromPipelineByPropertyName = true)]
-public string ResourceGroupName { get; set; }
+public string ResourceId { get; set; }
 ```
 
 If there is a corresponding `Get-AzureRmFoo` cmdlet that returns a `PSFoo` object (that has properties `Name` and `ResourceGroupName`), the following scenario is enabled:
 
 ```powershell
 # --- Piping scenario ---
 # Remove an individual PSFoo object
-Get-AzureRmFoo -Name "FooName" -ResourceGroupName "RG" | Remove-AzureRmFoo
+Get-AzureRmResource -ResourceId <resourceId> | Remove-AzureRmFoo
 
 # Remove all PSFoo objects
-Get-AzureRmFoo | Remove-AzureRmFoo
+Get-AzureRmResource -ResourceType Foo | Remove-AzureRmFoo
 
 
 # --- Non-piping scenario ---
 # Remove an individual PSFoo object
-$foo = Get-AzureRmFoo -Name "FooName" -ResourceGroupName "RG"
-Remove-AzureRmFoo -Name $foo.Name -ResourceGroupName $foo.ResourceGroupName
+$foo = Get-AzureRmResource -ResourceId <resourceId>
+Remove-AzureRmFoo -ResourceId <resourceId>
 
 # Remove all PSFoo objects
-Get-AzureRmFoo | ForEach-Object { Remove-AzureRmFoo -Name $_.Name -ResourceGroupName $_.ResourceGroupName }
+Get-AzureRmFoo | ForEach-Object { Remove-AzureRmFoo -ResourceId <resourceId> }
 ```
 
 The `PSFoo` object(s) that is returned by the `Get-AzureRmFoo` call will be piped to the `Remove-AzureRmFoo` cmdlet, and because that cmdlet has parameters that accept their value from the pipeline by property name, PowerShell will check each of these parameters and see if it can find a corresponding property in the `PSFoo` object that it shares a name with, and bind the value.

tools/StaticAnalysis/Program.cs

@@ -1,4 +1,4 @@
-// ----------------------------------------------------------------------------------
+// ----------------------------------------------------------------------------------
 //
 // Copyright Microsoft Corporation
 // Licensed under the Apache License, Version 2.0 (the "License");
@@ -52,7 +52,7 @@ public static void Main(string[] args)
                 if (args.Any(a => a == "--package-directory" || a == "-p"))
                 {
                     int idx = Array.FindIndex(args, a => a == "--package-directory" || a == "-p");
-                    if (idx == args.Length)
+                    if (idx + 1 == args.Length)
                     {
                         throw new ArgumentException("No value provided for the --package-directory parameter.");
                     }
@@ -81,7 +81,7 @@ public static void Main(string[] args)
                 if (args.Any(a => a == "--reports-directory" || a == "-r"))
                 {
                     int idx = Array.FindIndex(args, a => a == "--reports-directory" || a == "-r");
-                    if (idx == args.Length)
+                    if (idx + 1 == args.Length)
                     {
                         throw new ArgumentException("No value provided for the --reports-directory parameter.");
                     }
@@ -98,12 +98,20 @@ public static void Main(string[] args)
                 if (args.Any(a => a == "--modules-to-analyze" || a == "-m"))
                 {
                     int idx = Array.FindIndex(args, a => a == "--modules-to-analyze" || a == "-m");
-                    if (idx == args.Length)
+                    if (idx + 1 == args.Length)
+                    {
+                        Console.WriteLine("No value provided for the --modules-to-analyze parameter.");
+                    }
+                    else
                     {
-                        throw new ArgumentException("No value provided for the --modules-to-analyze parameter.");
+                        modulesToAnalyze = args[idx + 1].Split(';').ToList();
                     }
+                }
 
-                    modulesToAnalyze = args[idx + 1].Split(';').ToList();
+                if (!modulesToAnalyze.Any())
+                {
+                    Console.WriteLine("No modules were found to analyze -- skipping Static Analysis check.");
+                    return;
                 }
 
                 bool useNetcore = args.Any(a => a == "--use-netcore" || a == "-u");