Skip to content

Commit 55ed2d4

Browse files
authored
Merge pull request #11364 from bashahee/master
Save sensitivity rank when classifying columns
2 parents 6d3ec97 + 6f09f8e commit 55ed2d4

16 files changed

+3595
-2014
lines changed

src/Network/Network/Network.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<ItemGroup>
1515
<PackageReference Include="AutoMapper" Version="6.2.2" />
1616
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.18.0-preview" />
17-
<PackageReference Include="Microsoft.Azure.Management.Sql" Version="1.40.0-preview" />
17+
<PackageReference Include="Microsoft.Azure.Management.Sql" Version="1.41.0-preview" />
1818
</ItemGroup>
1919

2020
<ItemGroup>

src/Sql/Sql.Test/ScenarioTests/DataClassificationTests.ps1

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,25 +238,29 @@ function Test-DataClassificationOnSqlDatabase
238238
$firstColumnName = $firstRecommendation.ColumnName
239239
$firstInformationType = $firstRecommendation.InformationType
240240
$firstSensitivityLabel = $firstRecommendation.SensitivityLabel
241+
$firstRank = $firstRecommendation.Rank
241242

242243
Assert-AreEqual "dbo" $firstSchemaName
243244
Assert-AreEqual "Persons" $firstTableName
244245
Assert-NotNullOrEmpty $firstColumnName
245246
Assert-NotNullOrEmpty $firstInformationType
246247
Assert-NotNullOrEmpty $firstSensitivityLabel
248+
Assert-NotNullOrEmpty $firstRank
247249

248250
$secondRecommendation = ($recommendations.SensitivityLabels)[1]
249251
$secondSchemaName = $secondRecommendation.SchemaName
250252
$secondTableName = $secondRecommendation.TableName
251253
$secondColumnName = $secondRecommendation.ColumnName
252254
$secondInformationType = $secondRecommendation.InformationType
253255
$secondSensitivityLabel = $secondRecommendation.SensitivityLabel
256+
$secondRank = $secondRecommendation.Rank
254257

255258
Assert-AreEqual "dbo" $secondSchemaName
256259
Assert-AreEqual "Persons" $secondTableName
257260
Assert-NotNullOrEmpty $secondColumnName
258261
Assert-NotNullOrEmpty $secondInformationType
259262
Assert-NotNullOrEmpty $secondSensitivityLabel
263+
Assert-NotNullOrEmpty $secondRank
260264

261265
# Set first two sensitivity labels as recommended and verify.
262266
# Second label is set using pipeline.
@@ -278,6 +282,7 @@ function Test-DataClassificationOnSqlDatabase
278282
Assert-AreEqual $firstColumnName $classification.ColumnName
279283
Assert-AreEqual $firstInformationType $classification.InformationType
280284
Assert-AreEqual $firstSensitivityLabel $classification.SensitivityLabel
285+
Assert-AreEqual $firstRank $classification.Rank
281286

282287
$secondClassification = Get-AzSqlDatabase -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName | Get-AzSqlDatabaseSensitivityClassification -SchemaName $secondSchemaName -TableName $secondTableName -ColumnName $secondColumnName
283288
Assert-AreEqual 1 ($secondClassification.SensitivityLabels).count
@@ -287,6 +292,7 @@ function Test-DataClassificationOnSqlDatabase
287292
Assert-AreEqual $secondColumnName $classification.ColumnName
288293
Assert-AreEqual $secondInformationType $classification.InformationType
289294
Assert-AreEqual $secondSensitivityLabel $classification.SensitivityLabel
295+
Assert-AreEqual $secondRank $classification.Rank
290296

291297
# Get, using pipeline, recommended sensitivity labels, and verify.
292298
$recommendations = Get-AzSqlDatabase -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName | Get-AzSqlDatabaseSensitivityRecommendation
@@ -503,6 +509,8 @@ function Create-SqlDataClassificationTestEnvironment ($testSuffix, $location = "
503509
New-AzSqlServer -ResourceGroupName $params.rgname -ServerName $params.serverName -ServerVersion $serverVersion -Location $location -SqlAdministratorCredentials $credentials
504510
New-AzSqlServerFirewallRule -ResourceGroupName $params.rgname -ServerName $params.serverName -StartIpAddress 0.0.0.0 -EndIpAddress 255.255.255.255 -FirewallRuleName "dcRule"
505511

512+
# Enable Advanced Data Security
513+
Enable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName -DoNotConfigureVulnerabilityAssessment
506514

507515
New-AzSqlDatabase -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName
508516

@@ -577,7 +585,7 @@ function Test-EnableDisableRecommendationsOnSqlDatabase
577585
Assert-NotNullOrEmpty $secondInformationType
578586
Assert-NotNullOrEmpty $secondSensitivityLabel
579587

580-
# Disable first two recommdationsd, second recommdation is disabled using pipeline.
588+
# Disable first two recommdations, second recommdation is disabled using pipeline.
581589
Disable-AzSqlDatabaseSensitivityRecommendation -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -SchemaName $firstSchemaName -TableName $firstTableName -ColumnName $firstColumnName
582590
Get-AzSqlDatabase -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName | Disable-AzSqlDatabaseSensitivityRecommendation -SchemaName $secondSchemaName -TableName $secondTableName -ColumnName $secondColumnName
583591

src/Sql/Sql.Test/SessionRecords/Microsoft.Azure.Commands.Sql.Test.ScenarioTests.DataClassificationTests/TestDataClassificationOnSqlDatabase.json

Lines changed: 1321 additions & 877 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)