move roleassignment warning message after roleassignment confirmed

VeryEarly · VeryEarly · commit 55f14fa8af7c · 2019-11-08T15:48:51.000+08:00
diff --git a/src/Resources/Resources/ActiveDirectory/Cmdlets/NewAzureADServicePrincipalCommand.cs b/src/Resources/Resources/ActiveDirectory/Cmdlets/NewAzureADServicePrincipalCommand.cs
@@ -334,7 +334,6 @@ private void CreateSimpleServicePrincipal()
                     Role = "Contributor";
                     WriteVerbose(string.Format("No role provided - using the default role '{0}'", Role));
                 }
-                WriteWarning(string.Format("Assigning role '{0}' over scope '{1}' to the new service principal.", this.Role, this.Scope));
 
                 shouldProcessMessage = string.Format("Adding a new service principal to be associated with an application " +
                                                       "having AppId '{0}' with '{1}' role over scope '{2}'.", createParameters.ApplicationId, this.Role, this.Scope);
@@ -352,6 +351,7 @@ private void CreateSimpleServicePrincipal()
                 }
 
                 var subscriptionId = DefaultContext.Subscription.Id;
+                WriteWarning(string.Format("Assigning role '{0}' over scope '{1}' to the new service principal.", this.Role, this.Scope));
                 FilterRoleAssignmentsOptions parameters = new FilterRoleAssignmentsOptions()
                 {
                     Scope = this.Scope,

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,6 @@ private void CreateSimpleServicePrincipal()`
`334`	`334`	`Role = "Contributor";`
`335`	`335`	`WriteVerbose(string.Format("No role provided - using the default role '{0}'", Role));`
`336`	`336`	`}`
`337`		`- WriteWarning(string.Format("Assigning role '{0}' over scope '{1}' to the new service principal.", this.Role, this.Scope));`
`338`	`337`
`339`	`338`	`shouldProcessMessage = string.Format("Adding a new service principal to be associated with an application " +`
`340`	`339`	`"having AppId '{0}' with '{1}' role over scope '{2}'.", createParameters.ApplicationId, this.Role, this.Scope);`
`@@ -352,6 +351,7 @@ private void CreateSimpleServicePrincipal()`
`352`	`351`	`}`
`353`	`352`
`354`	`353`	`var subscriptionId = DefaultContext.Subscription.Id;`
	`354`	`+ WriteWarning(string.Format("Assigning role '{0}' over scope '{1}' to the new service principal.", this.Role, this.Scope));`
`355`	`355`	`FilterRoleAssignmentsOptions parameters = new FilterRoleAssignmentsOptions()`
`356`	`356`	`{`
`357`	`357`	`Scope = this.Scope,`