Move Batch tests using a new instance of BatchController to on-demand

cormacpayne · cormacpayne · commit 59a65e5021a5 · 2018-02-26T14:03:20.000-08:00
diff --git a/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/BatchApplicationPackageTests.cs b/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/BatchApplicationPackageTests.cs
@@ -26,7 +26,6 @@ public class BatchApplicationPackageTests : WindowsAzure.Commands.Test.Utilities
         private const string version = "foo";
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestUploadApplicationPackage()
         {
             string id = "newApplicationPackage";
@@ -56,7 +55,6 @@ public void TestUploadApplicationPackage()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestUpdateApplicationPackage()
         {
             string id = "updateApplicationPackage";
@@ -86,7 +84,6 @@ public void TestUpdateApplicationPackage()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestCreatePoolWithApplicationPackage()
         {
             string id = "createPoolWithApplicationPackage";
@@ -115,7 +112,6 @@ public void TestCreatePoolWithApplicationPackage()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestUpdatePoolWithApplicationPackage()
         {
             string id = "updatePoolWithApplicationPackage";
diff --git a/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/CertificateTests.cs b/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/CertificateTests.cs
@@ -28,14 +28,12 @@ public CertificateTests(Xunit.Abstractions.ITestOutputHelper output)
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestCertificateCrudOperations()
         {
             BatchController.NewInstance.RunPsTest("Test-CertificateCrudOperations");
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestCancelCertificateDelete()
         {
             BatchController controller = BatchController.NewInstance;
diff --git a/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/ComputeNodeTests.cs b/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/ComputeNodeTests.cs
@@ -29,7 +29,6 @@ public ComputeNodeTests(Xunit.Abstractions.ITestOutputHelper output)
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestRemoveComputeNodes()
         {
             BatchController controller = BatchController.NewInstance;
@@ -52,7 +51,6 @@ public void TestRemoveComputeNodes()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestRebootAndReimageComputeNode()
         {
             BatchController controller = BatchController.NewInstance;
@@ -75,7 +73,6 @@ public void TestRebootAndReimageComputeNode()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestDisableAndEnableComputeNodeScheduling()
         {
             BatchController controller = BatchController.NewInstance;
@@ -95,7 +92,6 @@ public void TestDisableAndEnableComputeNodeScheduling()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestGetComputeNodeRemoteLoginSettings()
         {
             BatchController controller = BatchController.NewInstance;
diff --git a/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/FileTests.cs b/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/FileTests.cs
@@ -30,7 +30,6 @@ public FileTests(Xunit.Abstractions.ITestOutputHelper output)
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestGetNodeFileContentByTask()
         {
             BatchController controller = BatchController.NewInstance;
@@ -58,7 +57,6 @@ public void TestGetNodeFileContentByTask()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestGetNodeFileContentByComputeNode()
         {
             BatchController controller = BatchController.NewInstance;
@@ -77,7 +75,6 @@ public void TestGetNodeFileContentByComputeNode()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestGetRemoteDesktopProtocolFile()
         {
             BatchController controller = BatchController.NewInstance;
@@ -96,7 +93,6 @@ public void TestGetRemoteDesktopProtocolFile()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestDeleteNodeFileByTask()
         {
             BatchController controller = BatchController.NewInstance;
@@ -123,7 +119,6 @@ public void TestDeleteNodeFileByTask()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestDeleteNodeFileByComputeNode()
         {
             BatchController controller = BatchController.NewInstance;
diff --git a/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/JobScheduleTests.cs b/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/JobScheduleTests.cs
@@ -34,7 +34,6 @@ public void TestJobScheduleCRUD()
 
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestDisableEnableTerminateJobSchedule()
         {
             BatchController controller = BatchController.NewInstance;
diff --git a/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/JobTests.cs b/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/JobTests.cs
@@ -28,15 +28,13 @@ public JobTests(Xunit.Abstractions.ITestOutputHelper output)
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestJobCRUD()
         {
             BatchController.NewInstance.RunPsTest("Test-JobCRUD");
         }
 
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestDisableEnableTerminateJob()
         {
             BatchController controller = BatchController.NewInstance;
@@ -59,7 +57,6 @@ public void TestDisableEnableTerminateJob()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void IfJobSetsAutoFailure_ItCompletesWhenAnyTaskFails()
         {
             BatchController controller = BatchController.NewInstance;
diff --git a/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/PoolTests.cs b/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/PoolTests.cs
@@ -31,14 +31,12 @@ public PoolTests(Xunit.Abstractions.ITestOutputHelper output)
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestPoolCRUD()
         {
             BatchController.NewInstance.RunPsTest("Test-PoolCRUD");
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestResizeAndStopResizePool()
         {
             BatchController controller = BatchController.NewInstance;
@@ -60,7 +58,6 @@ public void TestResizeAndStopResizePool()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestAutoScaleActions()
         {
             BatchController controller = BatchController.NewInstance;
@@ -82,7 +79,6 @@ public void TestAutoScaleActions()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public  void TestChangeOSVersion()
         {
             BatchController controller = BatchController.NewInstance;
diff --git a/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/TaskTests.cs b/src/ResourceManager/AzureBatch/Commands.Batch.Test/ScenarioTests/TaskTests.cs
@@ -26,7 +26,6 @@ public TaskTests(Xunit.Abstractions.ITestOutputHelper output)
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestTaskCRUD()
         {
             BatchController controller = BatchController.NewInstance;
@@ -48,7 +47,6 @@ public void TestTaskCRUD()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestCreateTaskCollection()
         {
             BatchController controller = BatchController.NewInstance;
@@ -70,7 +68,6 @@ public void TestCreateTaskCollection()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestTerminateTask()
         {
             BatchController controller = BatchController.NewInstance;
@@ -97,7 +94,6 @@ public void TestTerminateTask()
         }
 
         [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestListAllSubtasks()
         {
             BatchController controller = BatchController.NewInstance;

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ public class BatchApplicationPackageTests : WindowsAzure.Commands.Test.Utilities`
`26`	`26`	`private const string version = "foo";`
`27`	`27`
`28`	`28`	`[Fact]`
`29`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`30`	`29`	`public void TestUploadApplicationPackage()`
`31`	`30`	`{`
`32`	`31`	`string id = "newApplicationPackage";`
`@@ -56,7 +55,6 @@ public void TestUploadApplicationPackage()`
`56`	`55`	`}`
`57`	`56`
`58`	`57`	`[Fact]`
`59`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`60`	`58`	`public void TestUpdateApplicationPackage()`
`61`	`59`	`{`
`62`	`60`	`string id = "updateApplicationPackage";`
`@@ -86,7 +84,6 @@ public void TestUpdateApplicationPackage()`
`86`	`84`	`}`
`87`	`85`
`88`	`86`	`[Fact]`
`89`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`90`	`87`	`public void TestCreatePoolWithApplicationPackage()`
`91`	`88`	`{`
`92`	`89`	`string id = "createPoolWithApplicationPackage";`
`@@ -115,7 +112,6 @@ public void TestCreatePoolWithApplicationPackage()`
`115`	`112`	`}`
`116`	`113`
`117`	`114`	`[Fact]`
`118`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`119`	`115`	`public void TestUpdatePoolWithApplicationPackage()`
`120`	`116`	`{`
`121`	`117`	`string id = "updatePoolWithApplicationPackage";`
Original file line number	Diff line number	Diff line change
`@@ -28,14 +28,12 @@ public CertificateTests(Xunit.Abstractions.ITestOutputHelper output)`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`[Fact]`
`31`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`32`	`31`	`public void TestCertificateCrudOperations()`
`33`	`32`	`{`
`34`	`33`	`BatchController.NewInstance.RunPsTest("Test-CertificateCrudOperations");`
`35`	`34`	`}`
`36`	`35`
`37`	`36`	`[Fact]`
`38`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`39`	`37`	`public void TestCancelCertificateDelete()`
`40`	`38`	`{`
`41`	`39`	`BatchController controller = BatchController.NewInstance;`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ public ComputeNodeTests(Xunit.Abstractions.ITestOutputHelper output)`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`[Fact]`
`32`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`33`	`32`	`public void TestRemoveComputeNodes()`
`34`	`33`	`{`
`35`	`34`	`BatchController controller = BatchController.NewInstance;`
`@@ -52,7 +51,6 @@ public void TestRemoveComputeNodes()`
`52`	`51`	`}`
`53`	`52`
`54`	`53`	`[Fact]`
`55`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`56`	`54`	`public void TestRebootAndReimageComputeNode()`
`57`	`55`	`{`
`58`	`56`	`BatchController controller = BatchController.NewInstance;`
`@@ -75,7 +73,6 @@ public void TestRebootAndReimageComputeNode()`
`75`	`73`	`}`
`76`	`74`
`77`	`75`	`[Fact]`
`78`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`79`	`76`	`public void TestDisableAndEnableComputeNodeScheduling()`
`80`	`77`	`{`
`81`	`78`	`BatchController controller = BatchController.NewInstance;`
`@@ -95,7 +92,6 @@ public void TestDisableAndEnableComputeNodeScheduling()`
`95`	`92`	`}`
`96`	`93`
`97`	`94`	`[Fact]`
`98`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`99`	`95`	`public void TestGetComputeNodeRemoteLoginSettings()`
`100`	`96`	`{`
`101`	`97`	`BatchController controller = BatchController.NewInstance;`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ public FileTests(Xunit.Abstractions.ITestOutputHelper output)`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`[Fact]`
`33`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`34`	`33`	`public void TestGetNodeFileContentByTask()`
`35`	`34`	`{`
`36`	`35`	`BatchController controller = BatchController.NewInstance;`
`@@ -58,7 +57,6 @@ public void TestGetNodeFileContentByTask()`
`58`	`57`	`}`
`59`	`58`
`60`	`59`	`[Fact]`
`61`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`62`	`60`	`public void TestGetNodeFileContentByComputeNode()`
`63`	`61`	`{`
`64`	`62`	`BatchController controller = BatchController.NewInstance;`
`@@ -77,7 +75,6 @@ public void TestGetNodeFileContentByComputeNode()`
`77`	`75`	`}`
`78`	`76`
`79`	`77`	`[Fact]`
`80`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`81`	`78`	`public void TestGetRemoteDesktopProtocolFile()`
`82`	`79`	`{`
`83`	`80`	`BatchController controller = BatchController.NewInstance;`
`@@ -96,7 +93,6 @@ public void TestGetRemoteDesktopProtocolFile()`
`96`	`93`	`}`
`97`	`94`
`98`	`95`	`[Fact]`
`99`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`100`	`96`	`public void TestDeleteNodeFileByTask()`
`101`	`97`	`{`
`102`	`98`	`BatchController controller = BatchController.NewInstance;`
`@@ -123,7 +119,6 @@ public void TestDeleteNodeFileByTask()`
`123`	`119`	`}`
`124`	`120`
`125`	`121`	`[Fact]`
`126`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`127`	`122`	`public void TestDeleteNodeFileByComputeNode()`
`128`	`123`	`{`
`129`	`124`	`BatchController controller = BatchController.NewInstance;`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ public void TestJobScheduleCRUD()`
`34`	`34`
`35`	`35`
`36`	`36`	`[Fact]`
`37`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`38`	`37`	`public void TestDisableEnableTerminateJobSchedule()`
`39`	`38`	`{`
`40`	`39`	`BatchController controller = BatchController.NewInstance;`
Original file line number	Diff line number	Diff line change
`@@ -28,15 +28,13 @@ public JobTests(Xunit.Abstractions.ITestOutputHelper output)`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`[Fact]`
`31`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`32`	`31`	`public void TestJobCRUD()`
`33`	`32`	`{`
`34`	`33`	`BatchController.NewInstance.RunPsTest("Test-JobCRUD");`
`35`	`34`	`}`
`36`	`35`
`37`	`36`
`38`	`37`	`[Fact]`
`39`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`40`	`38`	`public void TestDisableEnableTerminateJob()`
`41`	`39`	`{`
`42`	`40`	`BatchController controller = BatchController.NewInstance;`
`@@ -59,7 +57,6 @@ public void TestDisableEnableTerminateJob()`
`59`	`57`	`}`
`60`	`58`
`61`	`59`	`[Fact]`
`62`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`63`	`60`	`public void IfJobSetsAutoFailure_ItCompletesWhenAnyTaskFails()`
`64`	`61`	`{`
`65`	`62`	`BatchController controller = BatchController.NewInstance;`
Original file line number	Diff line number	Diff line change
`@@ -31,14 +31,12 @@ public PoolTests(Xunit.Abstractions.ITestOutputHelper output)`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`[Fact]`
`34`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`35`	`34`	`public void TestPoolCRUD()`
`36`	`35`	`{`
`37`	`36`	`BatchController.NewInstance.RunPsTest("Test-PoolCRUD");`
`38`	`37`	`}`
`39`	`38`
`40`	`39`	`[Fact]`
`41`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`42`	`40`	`public void TestResizeAndStopResizePool()`
`43`	`41`	`{`
`44`	`42`	`BatchController controller = BatchController.NewInstance;`
`@@ -60,7 +58,6 @@ public void TestResizeAndStopResizePool()`
`60`	`58`	`}`
`61`	`59`
`62`	`60`	`[Fact]`
`63`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`64`	`61`	`public void TestAutoScaleActions()`
`65`	`62`	`{`
`66`	`63`	`BatchController controller = BatchController.NewInstance;`
`@@ -82,7 +79,6 @@ public void TestAutoScaleActions()`
`82`	`79`	`}`
`83`	`80`
`84`	`81`	`[Fact]`
`85`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`86`	`82`	`public void TestChangeOSVersion()`
`87`	`83`	`{`
`88`	`84`	`BatchController controller = BatchController.NewInstance;`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ public TaskTests(Xunit.Abstractions.ITestOutputHelper output)`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`[Fact]`
`29`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`30`	`29`	`public void TestTaskCRUD()`
`31`	`30`	`{`
`32`	`31`	`BatchController controller = BatchController.NewInstance;`
`@@ -48,7 +47,6 @@ public void TestTaskCRUD()`
`48`	`47`	`}`
`49`	`48`
`50`	`49`	`[Fact]`
`51`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`52`	`50`	`public void TestCreateTaskCollection()`
`53`	`51`	`{`
`54`	`52`	`BatchController controller = BatchController.NewInstance;`
`@@ -70,7 +68,6 @@ public void TestCreateTaskCollection()`
`70`	`68`	`}`
`71`	`69`
`72`	`70`	`[Fact]`
`73`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`74`	`71`	`public void TestTerminateTask()`
`75`	`72`	`{`
`76`	`73`	`BatchController controller = BatchController.NewInstance;`
`@@ -97,7 +94,6 @@ public void TestTerminateTask()`
`97`	`94`	`}`
`98`	`95`
`99`	`96`	`[Fact]`
`100`		`- [Trait(Category.AcceptanceType, Category.CheckIn)]`
`101`	`97`	`public void TestListAllSubtasks()`
`102`	`98`	`{`
`103`	`99`	`BatchController controller = BatchController.NewInstance;`