Merge pull request #9332 from wastoresh/filestorage

[Storage] Support Account Kind FileStorage, and Skuname Premium_ZRS

Author: markcowl

src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.cs

@@ -121,6 +121,13 @@ public void TestGetAzureStorageLocationUsage()
             TestRunner.RunTestScript("Test-GetAzureStorageLocationUsage");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestNewAzureStorageAccountFileStorage()
+        {
+            TestRunner.RunTestScript("Test-NewAzureStorageAccountFileStorage");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestPipingNewUpdateAccount()

src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.ps1

@@ -668,6 +668,43 @@ function Test-GetAzureStorageLocationUsage
         Assert-AreNotEqual 0 $usage.CurrentValue;      
 }
 
+<#
+.SYNOPSIS
+Test New-AzStorageAccountFileStorage
+.DESCRIPTION
+Smoke[Broken]Test
+#>
+function Test-NewAzureStorageAccountFileStorage
+{
+    # Setup
+    $rgname = Get-StorageManagementTestResourceName;
+
+    try
+    {
+        # Test
+        $stoname = 'sto' + $rgname;
+        $stotype = 'Premium_LRS';
+        $kind = 'FileStorage'
+
+        $loc = Get-ProviderLocation ResourceManagement;
+        New-AzResourceGroup -Name $rgname -Location $loc;
+		
+        New-AzStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -Type $stotype -Kind $kind;
+        $sto = Get-AzStorageAccount -ResourceGroupName $rgname  -Name $stoname;
+        Assert-AreEqual $stoname $sto.StorageAccountName;
+        Assert-AreEqual $stotype $sto.Sku.Name;
+        Assert-AreEqual $loc.ToLower().Replace(" ", "") $sto.Location;
+        Assert-AreEqual $kind $sto.Kind; 
+        
+        Retry-IfException { Remove-AzStorageAccount -Force -ResourceGroupName $rgname -Name $stoname; }
+    }
+    finally
+    {
+        # Cleanup
+        Clean-ResourceGroup $rgname
+    }
+}
+
 <#
 .SYNOPSIS
 Test Get-AzStorageAccount | New/Set-AzStorageAccount

src/Storage/Storage.Management.Test/SessionRecords/Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests.StorageAccountTests/TestNewAzureStorageAccountFileStorage.json

@@ -18,6 +18,8 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Support Kind FileStorage and SkuName Premium_ZRS when create Storage account
+    - New-AzStorageAccount
 * Clarified description of blob immutability cmdlet
     -  Remove-AzRmStorageContainerImmutabilityPolicy
 

src/Storage/Storage.Management/ChangeLog.md

@@ -56,6 +56,7 @@ public class NewAzureStorageAccountCommand : StorageAccountBaseCmdlet
             StorageModels.SkuName.StandardGRS,
             StorageModels.SkuName.StandardRAGRS,
             StorageModels.SkuName.PremiumLRS,
+            StorageModels.SkuName.PremiumZRS,
             IgnoreCase = true)]
         public string SkuName { get; set; }
 
@@ -75,6 +76,7 @@ public class NewAzureStorageAccountCommand : StorageAccountBaseCmdlet
             StorageModels.Kind.StorageV2,
             StorageModels.Kind.BlobStorage,
             StorageModels.Kind.BlockBlobStorage,
+            StorageModels.Kind.FileStorage,
             IgnoreCase = true)]
         public string Kind
         {

src/Storage/Storage.Management/StorageAccount/NewAzureStorageAccount.cs

@@ -185,13 +185,15 @@ The acceptable values for this parameter are:
 - Storage. General purpose Storage account that supports storage of Blobs, Tables, Queues, Files and Disks.
 - StorageV2. General Purpose Version 2 (GPv2) Storage account that supports Blobs, Tables, Queues, Files, and Disks, with advanced features like data tiering.
 - BlobStorage. Blob Storage account which supports storage of Blobs only.
-The default value is Storage.
+- BlockBlobStorage. Block Blob Storage account which supports storage of Block Blobs only.
+- FileStorage. File Storage account which supports storage of Files only.
+The default value is StorageV2.
 
 ```yaml
 Type: System.String
 Parameter Sets: (All)
 Aliases:
-Accepted values: Storage, StorageV2, BlobStorage, BlockBlobStorage
+Accepted values: Storage, StorageV2, BlobStorage, BlockBlobStorage, FileStorage
 
 Required: False
 Position: Named
@@ -268,12 +270,13 @@ The acceptable values for this parameter are:
 - Standard_GRS. Geo-redundant storage.
 - Standard_RAGRS. Read access geo-redundant storage.
 - Premium_LRS. Premium locally-redundant storage.
+- Premium_ZRS. Premium zone-redundant storage.
 
 ```yaml
 Type: System.String
 Parameter Sets: (All)
 Aliases: StorageAccountType, AccountType, Type
-Accepted values: Standard_LRS, Standard_ZRS, Standard_GRS, Standard_RAGRS, Premium_LRS
+Accepted values: Standard_LRS, Standard_ZRS, Standard_GRS, Standard_RAGRS, Premium_LRS, Premium_ZRS
 
 Required: True
 Position: 2

src/Storage/Storage.Management/help/New-AzStorageAccount.md

@@ -73,6 +73,8 @@ New-AzStorageContext [-Local] [<CommonParameters>]
 
 ## DESCRIPTION
 The **New-AzStorageContext** cmdlet creates an Azure Storage context.
+The default Authentication of a Storage Context is OAuth (Azure AD), if only input Storage account name.
+See details of authentication of the Storage Service in https://docs.microsoft.com/en-us/rest/api/storageservices/authorization-for-the-azure-storage-services.
 
 ## EXAMPLES
 
@@ -159,7 +161,7 @@ PS C:\>Connect-AzAccount
 PS C:\> $Context = New-AzStorageContext -StorageAccountName "myaccountname" -UseConnectedAccount
 ```
 
-This command creates a context by using the OAuth Authentication.
+This command creates a context by using the OAuth (Azure AD)  Authentication.
 
 ## PARAMETERS
 
@@ -316,7 +318,7 @@ Accept wildcard characters: False
 ```
 
 ### -UseConnectedAccount
-Indicates that this cmdlet creates an Azure Storage context with OAuth Authentication.
+Indicates that this cmdlet creates an Azure Storage context with OAuth (Azure AD) Authentication.
 The cmdlet will use OAuth Authentication by default, when other anthentication not specified.
 
 ```yaml