Merge pull request #5985 from darshanhs90/preview1

Include deleted users/groups/serviceprincipals for Get-AzureRmRoleAssignment calls

Author: markcowl

src/ResourceManager/Resources/ChangeLog.md

@@ -20,6 +20,7 @@
 ## Current Release
 * Set minimum dependency of module to PowerShell 5.0
 * Remove obsolete parameter -AtScopeAndBelow from Get-AzureRmRoledefinition call
+* Include assignments to deleted USers/Groups/ServicePrincipals in Get-AzureRmRoleAssignment result
 
 ## Version 5.5.2
 * Updated to the latest version of the Azure ClientRuntime

src/ResourceManager/Resources/Commands.Resources.Test/Commands.Resources.Test.csproj

@@ -683,6 +683,9 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.RoleAssignmentTests\RaById.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.RoleAssignmentTests\RaDeletedPrincipals.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.RoleDefinitionTests\RdNegativeScenarios.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>

src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/RoleAssignmentTests.cs

@@ -44,6 +44,13 @@ public void RaClassicAdmins()
             ResourcesController.NewInstance.RunPsTest("Test-RaClassicAdmins");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void RaDeletedPrincipals()
+        {
+            ResourcesController.NewInstance.RunPsTest("Test-RaDeletedPrincipals");
+        }
+	
         [Fact]
         [Trait(Category.AcceptanceType, Category.Flaky)]
         public void RaPropertiesValidation() {

src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/RoleAssignmentTests.ps1

@@ -29,6 +29,22 @@ function Test-RaClassicAdmins
     Assert-True { $classic.Length -ge 1 }
 }
 
+<#
+.SYNOPSIS
+Tests retrieval of assignments to deleted principals/Users/Groups
+This test will fail if the objectId is changed or the role assignment deleted
+#>
+function Test-RaDeletedPrincipals
+{
+    $objectId = "d49bc32d-d030-4ab6-8c98-e90a5b88f602"
+    $assignment = Get-AzureRmRoleAssignment -ObjectId $objectId
+    Assert-NotNull $assignment
+    Assert-NotNull $assignment.ObjectType
+    Assert-AreEqual $assignment.ObjectType "Unknown"
+    Assert-NotNull $assignment.ObjectId
+    Assert-AreEqual $assignment.ObjectId $objectId      
+}
+
 <#
 .SYNOPSIS
 Tests verifies negative scenarios for RoleAssignments