{AzureNetworking} fixes #19436 Support for -WhatIf parameter (#20473)

* {AzureNetworking} fixes #19436 Support for -WhatIf parameter

fixes #19436 Support for -WhatIf parameter

All 'AzIpGroup' cmdlets that make changes support the -whatIf parameters. New-AzIpGroup and Remove-AzIpGroup honor this, displaying a "What If: " message and not making changes.

Set-AzIpGroup supports -whatif according to the documentation and accepts the parameter, but ignores it and changes the configuration of the resource instead. This PR fixes a Bug for Set-AzIpGroup to support the -whatif parameter.

* Update ChangeLog.md

Author: navba-MSFT

src/Network/Network/ChangeLog.md

@@ -20,6 +20,7 @@
 
 ## Upcoming Release
 * Fixed a bug that added Ddos related properties when viewing PublicIpAddress and DdosProtectionPlan objects
+* Fixed a Bug for Set-AzIpGroup cmdlet to support the -whatif parameter
 
 ## Version 5.2.0
 * Added optional parameters `CustomBlockResponseStatusCode` and `CustomBlockResponseBody` parameter to `AzApplicationGatewayFirewallPolicySettings`

src/Network/Network/IpGroup/SetIpGroupCommand.cs

@@ -35,22 +35,25 @@ public class SetIpGroupsCommand : IpGroupBaseCmdlet
 
         public override void Execute()
         {
-            base.Execute();
-
-            if (!this.IsIpGroupsPresent(this.IpGroup.ResourceGroupName, this.IpGroup.Name))
+            if (ShouldProcess(this.IpGroup.Name, "Updating IpGroup"))
             {
-                throw new System.ArgumentException(string.Format(Microsoft.Azure.Commands.Network.Properties.Resources.ResourceNotFound, this.IpGroup.Name));
-            }
+                base.Execute();
 
-            // Map to the sdk object
-            var ipGroupSdkObject = NetworkResourceManagerProfile.Mapper.Map<MNM.IpGroup>(this.IpGroup);
-            ipGroupSdkObject.Tags = TagsConversionHelper.CreateTagDictionary(this.IpGroup.Tag, validate: true);
+                if (!this.IsIpGroupsPresent(this.IpGroup.ResourceGroupName, this.IpGroup.Name))
+                {
+                    throw new System.ArgumentException(string.Format(Microsoft.Azure.Commands.Network.Properties.Resources.ResourceNotFound, this.IpGroup.Name));
+                }
 
-            // Execute the PUT IpGroups call
-            this.IpGroupsClient.CreateOrUpdate(this.IpGroup.ResourceGroupName, this.IpGroup.Name, ipGroupSdkObject);
+                // Map to the sdk object
+                var ipGroupSdkObject = NetworkResourceManagerProfile.Mapper.Map<MNM.IpGroup>(this.IpGroup);
+                ipGroupSdkObject.Tags = TagsConversionHelper.CreateTagDictionary(this.IpGroup.Tag, validate: true);
 
-            var getIpGroups = this.GetIpGroup(this.IpGroup.ResourceGroupName, this.IpGroup.Name);
-            WriteObject(getIpGroups);
+                // Execute the PUT IpGroups call
+                this.IpGroupsClient.CreateOrUpdate(this.IpGroup.ResourceGroupName, this.IpGroup.Name, ipGroupSdkObject);
+
+                var getIpGroups = this.GetIpGroup(this.IpGroup.ResourceGroupName, this.IpGroup.Name);
+                WriteObject(getIpGroups);
+            }
         }
     }
-}
+}