Merge pull request #9035 from MiYanni/securitytools-changes

Add SecurityTools (CredScan, BinSkim, PoliCheck) to PR builds in ADO

Author: markcowl

.azure-pipelines/windows-powershell.yml

@@ -19,6 +19,36 @@ jobs:
       testFramework: ${{ variables.TestFramework }}
       configuration: ${{ variables.Configuration }}
 
+- job: Analyze
+  displayName: Analyze
+  dependsOn: Build
+  condition: succeeded()
+  pool:
+    vmImage: ${{ variables.WindowsImage }}
+
+  steps:
+  - template: util/analyze-steps.yml
+    parameters:
+      osName: ${{ variables.WindowsName }}
+      configuration: ${{ variables.Configuration }}
+  - task: PowerShell@2
+    displayName: 'Cleanup Build'
+    inputs:
+      targetType: filePath
+      filePath: tools/CleanupBuild.ps1
+      pwsh: true
+  - task: NuGetCommand@2
+    displayName: 'Download BinSkim'
+    inputs:
+      command: custom
+      arguments: 'install Microsoft.CodeAnalysis.BinSkim -OutputDirectory $(System.DefaultWorkingDirectory)/tools/SecurityTools'
+  - task: PowerShell@2
+    displayName: 'Run BinSkim'
+    inputs:
+      targetType: filePath
+      filePath: tools/SecurityTools/RunBinSkim.ps1
+      pwsh: true
+
 - job: Test
   displayName: Test
   dependsOn: Build

src/HDInsight/HDInsight.Test/UnitTests/DataLakeStoreTests.cs

@@ -29,9 +29,6 @@ namespace Commands.HDInsight.Test.UnitTests
     public class DataLakeStoreTests : HDInsightTestBase
     {
         private NewAzureHDInsightClusterCommand cmdlet;
-        private const string StorageName = "dummystorage.blob.core.windows.net";
-        private const string StorageKey = "O9EQvp3A3AjXq/W27rst1GQfLllhp01qlJMJfSU1hVW2K42gUeiUUn2D8zX2lU3taiXSSfqkZlcPv+nQcYYwUx==";
-        private const int ClusterSize = 4;
         private Guid ObjectId = new Guid("11111111-1111-1111-1111-111111111111");
         private Guid AadTenantId = new Guid("11111111-1111-1111-1111-111111111111");
         private string Certificate = "";