Service fabric Managed Clusters - Update managed .net sdk for api version 2021-05-01 (#14807)

* update managed sdk to ga version and update cmdlets

* update managed tests

* runtest agains the test region and add params to PS objects

* record managed cluster tests

* record managed app tests and update changelog

* rename plural parameters and update help documents

* fix change log param names

* breaking change and signature issue exceptions

* add breaking change message for PSManagedService

Co-authored-by: Alfredo Santamaria Gomez <[email protected]>

Author: a-santamaria

src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersApplicationTests.ps1

@@ -248,14 +248,12 @@ function Test-ManagedService
 	Assert-AreEqual $standByReplicaKeepDuration $statefulService.Properties.StandByReplicaKeepDuration
 	Assert-AreEqual $servicePlacementTimeLimit $statefulService.Properties.ServicePlacementTimeLimit
 
-	$instanceCloseDelayDuration = "00:11:00"
 	$minInstancePercentage = 20
 	$minInstanceCount = 2
 
-	$statelessService = $statelessServiceFromGet | Set-AzServiceFabricManagedClusterService -Stateless -InstanceCloseDelayDuration $instanceCloseDelayDuration -MinInstancePercentage $minInstancePercentage `
+	$statelessService = $statelessServiceFromGet | Set-AzServiceFabricManagedClusterService -Stateless -MinInstancePercentage $minInstancePercentage `
 		-MinInstanceCount $minInstanceCount -Verbose
 	Assert-AreEqual "Succeeded" $statelessService.Properties.ProvisioningState
-	Assert-AreEqual $instanceCloseDelayDuration $statelessService.Properties.InstanceCloseDelayDuration
 	Assert-AreEqual $minInstancePercentage $statelessService.Properties.MinInstancePercentage
 	Assert-AreEqual $minInstanceCount $statelessService.Properties.MinInstanceCount
 

src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersTests.ps1

@@ -17,22 +17,25 @@ function Test-CreateBasicCluster
 	$resourceGroupName = "sfmcps-rg-" + (getAssetname)
 	$clusterName = "sfmcps-" + (getAssetname)
 	$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
-	$location = "northeurope"
+	$location = "southcentralus"
 	$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
 	Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"
 
 	$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
 		-AdminPassword $pass -Sku Basic -ClientCertThumbprint $testClientTp -Verbose
-	Assert-AreEqual  "Succeeded" $cluster.ProvisioningState
-	Assert-AreEqual  "WaitingForNodes" $cluster.ClusterState
+	Assert-AreEqual "Succeeded" $cluster.ProvisioningState
+	Assert-AreEqual "Automatic" $cluster.ClusterUpgradeMode
+	Assert-AreEqual "Wave0" $cluster.ClusterUpgradeCadence
+
+	$pnt = New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -DiskType Standard_LRS -Primary
+	Assert-AreEqual 5 $pnt.VmInstanceCount
+	Assert-AreEqual "Standard_LRS" $pnt.DataDiskType
 
-	$pnt = New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary
-	
 	# shouldn't be allowed to remove the only primary node type in the cluster
 	Assert-ThrowsContains { $pnt | Remove-AzServiceFabricManagedNodeType } "InvalidParameter"
 
 	$cluster = Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName
-	Assert-AreEqual  "Deploying" $cluster.ClusterState
+	Assert-AreEqual "Deploying" $cluster.ClusterState
 
 	# scale primary node type
 	$pnt = Set-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 6
@@ -48,22 +51,32 @@ function Test-NodeTypeOperations
 {
 	$resourceGroupName = "sfmcps-rg-" + (getAssetname)
 	$clusterName = "sfmcps-" + (getAssetname)
-	$location = "northeurope"
+	$location = "southcentralus"
 	$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
 	$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
 	Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"
 
-	$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
+	$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -UpgradeMode Automatic -UpgradeCadence Wave1 -Location $location `
 		-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
-	Assert-AreEqual  "Succeeded" $cluster.ProvisioningState
-	Assert-AreEqual  "WaitingForNodes" $cluster.ClusterState
+	Assert-AreEqual "Succeeded" $cluster.ProvisioningState
+	Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
+	Assert-AreEqual "Automatic" $cluster.ClusterUpgradeMode
+	Assert-AreEqual "Wave1" $cluster.ClusterUpgradeCadence
 
-	New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary -AsJob
-	New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt -InstanceCount 6 -AsJob
+	New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary -DiskType Premium_LRS -VmSize "Standard_DS2" -AsJob
+	New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt -InstanceCount 6 -IsStateless -AsJob
 
 	#wait for nodetypes
 	WaitForAllJob
 
+	$pnt = Get-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt
+	Assert-AreEqual "Premium_LRS" $pnt.DataDiskType
+	Assert-False { $pnt.IsStateless }
+
+	$snt = Get-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt
+	Assert-AreEqual "StandardSSD_LRS" $snt.DataDiskType
+	Assert-True { $snt.IsStateless }
+
 	$restart = Restart-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt -NodeName snt_0, snt_1 -PassThru
 	Assert-True { $restart }
 
@@ -85,15 +98,15 @@ function Test-CertAndExtension
 {
 	$resourceGroupName = "sfmcps-rg-" + (getAssetname)
 	$clusterName = "sfmcps-" + (getAssetname)
-	$location = "northeurope"
+	$location = "southcentralus"
 	$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
 	$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
 	Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"
 
 	$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
 		-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
-	Assert-AreEqual  "Succeeded" $cluster.ProvisioningState
-	Assert-AreEqual  "WaitingForNodes" $cluster.ClusterState
+	Assert-AreEqual "Succeeded" $cluster.ProvisioningState
+	Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
 
 	$pnt = New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary
 

src/ServiceFabric/ServiceFabric.Test/ServiceFabric.Test.csproj

@@ -14,7 +14,7 @@
     <PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.1" />
     <PackageReference Include="Microsoft.Azure.KeyVault.WebKey" Version="3.0.1" />
     <PackageReference Include="Microsoft.Azure.Management.ServiceFabric" Version="1.3.0" />
-    <PackageReference Include="Microsoft.Azure.Management.ServiceFabricManagedClusters" Version="1.0.0-beta.1" />
+    <PackageReference Include="Microsoft.Azure.Management.ServiceFabricManagedClusters" Version="1.0.0" />
   </ItemGroup>
 
   <ItemGroup>