Validations for create protection profile object cmdlet added

Customer storage account validation added

Author: NehaRaje

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/PSRecoveryServicesClient/PSRecoveryServicesClientHelper.cs

@@ -14,9 +14,12 @@
 
 using System;
 using System.Collections.Generic;
+using System.Collections.ObjectModel;
+using System.Management.Automation;
 using Microsoft.WindowsAzure;
 using Microsoft.WindowsAzure.Commands.Common;
 using Microsoft.WindowsAzure.Commands.Common.Models;
+using Microsoft.WindowsAzure.Commands.ServiceManagement.Model;
 using Microsoft.WindowsAzure.Management.Storage;
 using Microsoft.WindowsAzure.Management.Storage.Models;
 
@@ -78,17 +81,22 @@ public static void ValidateStorageAccountAssociation(string azureStorageAccount)
 
             bool associatedAccount = false;
 
-            SubscriptionCloudCredentials creds 
-                = AzureSession.AuthenticationFactory.GetSubscriptionCloudCredentials(AzureSession.CurrentContext);
-            StorageManagementClient storageManagementClient = new StorageManagementClient(creds);
-
-            StorageAccountListResponse storageAccounts = storageManagementClient.StorageAccounts.List();
-            foreach (StorageAccount storage in storageAccounts)
+            using (System.Management.Automation.PowerShell powerShellInstance = System.Management.Automation.PowerShell.Create())
             {
-                if (azureStorageAccount.Equals(storage.Name, StringComparison.OrdinalIgnoreCase))
+                powerShellInstance.AddCommand("Get-AzureStorageAccount");
+                Collection<PSObject> powershellOutput = powerShellInstance.Invoke();
+
+                foreach (var storage in powershellOutput)
                 {
-                    associatedAccount = true;
-                    break;
+                    if (storage.BaseObject is StorageServicePropertiesOperationContext)
+                    {
+                        StorageServicePropertiesOperationContext storageAccount = (StorageServicePropertiesOperationContext)storage.BaseObject;
+                        if (azureStorageAccount.Equals(storageAccount.StorageAccountName, StringComparison.OrdinalIgnoreCase))
+                        {
+                            associatedAccount = true;
+                            break;
+                        }
+                    }
                 }
             }
 
@@ -108,6 +116,11 @@ SubscriptionCloudCredentials creds
         /// <returns>A UShort corresponding to the value.</returns>
         public static ushort ConvertReplicationFrequencyToUshort(string replicationFrequencyString)
         {
+            if (replicationFrequencyString == null)
+            {
+                return 0;
+            }
+
             ushort replicationFrequency;
 
             if (!ushort.TryParse(replicationFrequencyString, out replicationFrequency))

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Service/CreateAzureSiteRecoveryProtectionProfileObject.cs

@@ -152,12 +152,12 @@ public override void ExecuteCmdlet()
         {
             try
             {
-                switch (this.ReplicationProvider)
+                switch (this.ParameterSetName)
                 {
-                    case Constants.HyperVReplica:
+                    case ASRParameterSets.EnterpriseToEnterprise:
                         this.EnterpriseToEnterpriseProtectionProfileObject();
                         break;
-                    case Constants.HyperVReplicaAzure:
+                    case ASRParameterSets.EnterpriseToAzure:
                         this.EnterpriseToAzureProtectionProfileObject();
                         break;
                 }
@@ -183,12 +183,20 @@ protected override void StopProcessing()
         /// </summary>
         private void EnterpriseToAzureProtectionProfileObject()
         {
-            //// Verify whether the storage account is associated with the account or not.
-            //// PSRecoveryServicesClientHelper.ValidateStorageAccountAssociation(this.RecoveryAzureStorageAccount);
+            if (string.Compare(this.ReplicationProvider, Constants.HyperVReplicaAzure, StringComparison.OrdinalIgnoreCase) != 0)
+            {
+                throw new InvalidOperationException(
+                    string.Format(
+                    Properties.Resources.IncorrectReplicationProvider,
+                    this.ReplicationProvider));
+            }
 
             // Verify whether the subscription is associated with the account or not.
             PSRecoveryServicesClientHelper.ValidateSubscriptionAccountAssociation(this.RecoveryAzureSubscription);
 
+            // Verify whether the storage account is associated with the account or not.
+            PSRecoveryServicesClientHelper.ValidateStorageAccountAssociation(this.RecoveryAzureStorageAccount);
+
             PSRecoveryServicesClientHelper.ValidateReplicationStartTime(this.ReplicationStartTime);
 
             ushort replicationFrequencyInSeconds = PSRecoveryServicesClientHelper.ConvertReplicationFrequencyToUshort(this.ReplicationFrequencyInSeconds);
@@ -217,6 +225,14 @@ private void EnterpriseToAzureProtectionProfileObject()
         /// </summary>
         private void EnterpriseToEnterpriseProtectionProfileObject()
         {
+            if (string.Compare(this.ReplicationProvider, Constants.HyperVReplica, StringComparison.OrdinalIgnoreCase) != 0)
+            {
+                throw new InvalidOperationException(
+                    string.Format(
+                    Properties.Resources.IncorrectReplicationProvider,
+                    this.ReplicationProvider));
+            }
+
             PSRecoveryServicesClientHelper.ValidateReplicationStartTime(this.ReplicationStartTime);
 
             ushort replicationFrequencyInSeconds = PSRecoveryServicesClientHelper.ConvertReplicationFrequencyToUshort(this.ReplicationFrequencyInSeconds);