Using nullOrEmpty check for policyId instead of just the null check

dragonfly91 · dragonfly91 · commit 6637b20604f5 · 2016-04-25T18:11:42.000+05:30
diff --git a/src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Helpers/Conversions/ConversionHelpers.cs b/src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Helpers/Conversions/ConversionHelpers.cs
@@ -189,11 +189,11 @@ public static AzureRmRecoveryServicesBackupItemBase GetItemModel(ProtectedItemRe
                 {
                     string policyName = null;
                     string policyId = ((AzureIaaSVMProtectedItem)protectedItem.Properties).PolicyId;
-                    if (policyId != null)
+                    if (!string.IsNullOrEmpty(policyId))
                     {
-                        Dictionary<UriEnums, string> keyVauleDict =
+                        Dictionary<UriEnums, string> keyValueDict =
                         HelperUtils.ParseUri(policyId);
-                        policyName = HelperUtils.GetPolicyNameFromPolicyId(keyVauleDict, policyId);
+                        policyName = HelperUtils.GetPolicyNameFromPolicyId(keyValueDict, policyId);
                     }
                     itemModel = new AzureRmRecoveryServicesBackupIaasVmItem(protectedItem, container, policyName);
                 }

Original file line number	Diff line number	Diff line change
`@@ -189,11 +189,11 @@ public static AzureRmRecoveryServicesBackupItemBase GetItemModel(ProtectedItemRe`
`189`	`189`	`{`
`190`	`190`	`string policyName = null;`
`191`	`191`	`string policyId = ((AzureIaaSVMProtectedItem)protectedItem.Properties).PolicyId;`
`192`		`- if (policyId != null)`
	`192`	`+ if (!string.IsNullOrEmpty(policyId))`
`193`	`193`	`{`
`194`		`- Dictionary<UriEnums, string> keyVauleDict =`
	`194`	`+ Dictionary<UriEnums, string> keyValueDict =`
`195`	`195`	`HelperUtils.ParseUri(policyId);`
`196`		`- policyName = HelperUtils.GetPolicyNameFromPolicyId(keyVauleDict, policyId);`
	`196`	`+ policyName = HelperUtils.GetPolicyNameFromPolicyId(keyValueDict, policyId);`
`197`	`197`	`}`
`198`	`198`	`itemModel = new AzureRmRecoveryServicesBackupIaasVmItem(protectedItem, container, policyName);`
`199`	`199`	`}`