Merge branch 'preview' into praries880-patch-1

Author: Maddie Clayton

ModuleMappings.json

@@ -155,6 +155,9 @@
     "src/ResourceManager/Scheduler/": [
       "AzureRM.Scheduler"
     ],
+    "src/ResourceManager/Search/": [
+      "AzureRM.Search"
+    ],
     "src/ResourceManager/ServiceBus/": [
       "AzureRM.ServiceBus"
     ],
@@ -191,6 +194,9 @@
     "src/Storage/Commands.Storage/": [
       "Azure.Storage"
     ],
+    "src/ResourceManager/StorageSync/": [
+      "AzureRM.StorageSync"
+    ],
     "tools/": [
     ]
   }

TestMappings.json

@@ -164,6 +164,9 @@
   "src/ResourceManager/Scheduler/": [
     ".\\src\\ResourceManager\\Scheduler\\Commands.Scheduler.Test\\bin\\Debug\\Microsoft.Azure.Commands.Scheduler.Test.dll"
   ],
+  "src/ResourceManager/Search/": [
+    ".\\src\\ResourceManager\\Search\\Commands.Management.Search.Test\\bin\\Debug\\Microsoft.Azure.Commands.Management.Search.Test.dll"
+  ],
   "src/ResourceManager/ServiceBus/": [
     ".\\src\\ResourceManager\\ServiceBus\\Commands.ServiceBus.Test\\bin\\Debug\\Microsoft.Azure.Commands.ServiceBus.Test.dll"
   ],
@@ -176,6 +179,9 @@
   "src/ResourceManager/Storage/Commands.Management.Storage.Test/": [
     ".\\src\\ResourceManager\\Storage\\Commands.Management.Storage.Test\\bin\\Debug\\Microsoft.Azure.Commands.Management.Storage.Test.dll"
   ],
+  "src/ResourceManager/StorageSync": [
+    ".\\src\\ResourceManager\\StorageSync\\Commands.StorageSync.Test\\bin\\Debug\\Microsoft.Azure.Commands.StorageSync.Test.dll"  
+  ],
   "src/ResourceManager/StreamAnalytics/": [
     ".\\src\\ResourceManager\\StreamAnalytics\\Commands.StreamAnalytics.Test\\bin\\Debug\\Microsoft.Azure.Commands.StreamAnalytics.Test.dll"
   ],

build.proj

@@ -260,7 +260,8 @@
   <Target Name="Build" DependsOnTargets="RestoreNugetPackages;BuildMsBuildTask;FilterBuild">
 
     <Message Importance="high" Text="Building Cmdlets for scope $(Scope)..." />
-    <CallTarget targets="ChangeLogCheck" ContinueOnError="false" />
+    <!-- Investigate why the ChangeLogCheck target removes the 8080th character -->
+    <!-- <CallTarget targets="ChangeLogCheck" ContinueOnError="false" /> -->
 
     <MakeDir  Directories="$(PackageDirectory)"
               Condition="'$(Scope)' != 'Stack'" />
@@ -666,7 +667,8 @@
     <MSBuild  Projects="build.proj"
               Targets="InvokeXUnit"
               Properties="XUnitTests=%(XUnitTests.Identity);TestOutputDirectory=$(TestOutputDirectory)"
-      ContinueOnError="false" />
+              Condition="'@(XunitTests->Count())' != '0'"
+              ContinueOnError="false" />
 
     <CallTarget Targets="TestFailureCheck" />
   </Target>

documentation/development-docs/azure-powershell-design-guidelines.md

@@ -41,6 +41,10 @@
     - [InputObject](#inputobject)
 - [AsJob Parameter](#asjob-parameter)
 
+## Expected Patterns for Standard Cmdlets
+
+For information and examples on standard cmdlet implementation (`Get-*`, `New-*`, `Remove-*` and `Set/Update-*`) for resources and child resources, please see our [Expected Patterns for Standard Cmdlets](./patterns-for-standard-cmdlets.md) document.
+
 ## Cmdlet Guidelines
 
 ### Cmdlet Naming Conventions
@@ -154,7 +158,7 @@ Parameters of type `bool` are _strongly_ discouraged in PowerShell. The `SwitchP
 If there is a closed set of values applicable for a given parameter, use either a `ValidateSet`, enumeration type, or an `ArgumentCompleter`. This functionality allows users to tab through the different values they can provide. From the [Strongly Encouraged Development Guidelines](https://msdn.microsoft.com/en-us/library/dd878270(v=vs.85).aspx):
 
 > _There are two ways to create a parameter whose value can be selected from a set of options._
-> 
+>
 > - _Define an enumeration type (or use an existing type) that specifies the valid values. Then, use the enumeration type to create a parameter of that type._
 > - _Add the **ValidateSet** attribute to the parameter declaration._
 
@@ -192,7 +196,7 @@ For PowerShell to determine which parameter set a user is intending to use with
 
 It is possibile to call a PowerShell cmdlet without providing the parameter names, but just the values you would like to pass through. This is done by specifying the position at which the value of each parameter should be provided by using the `Position` property for a parameter.  However, when there are too many positional parameters in a single parameter set, it can be difficult for the user to remember the exact ordering in which the parameter values should be provided. From the remarks section of [Parameter Attribute Declaration](https://msdn.microsoft.com/en-us/library/ms714348(v=vs.85).aspx):
 
-> _When you specify positional parameters, limit the number of positional parameters in a parameter set to less than five. And, positional parameters do not have to be contiguous. Positions 5, 100, and 250 work the same as positions 0, 1, and 2._ 
+> _When you specify positional parameters, limit the number of positional parameters in a parameter set to less than five. And, positional parameters do not have to be contiguous. Positions 5, 100, and 250 work the same as positions 0, 1, and 2._
 
 In addition, there should be no two parameters with the same position in the same parameter set. From the remarks section of [Parameter Attribute Declaration](https://msdn.microsoft.com/en-us/library/ms714348(v=vs.85).aspx):
 
@@ -218,7 +222,7 @@ The interactive parameter set **will always be the default parameter set** for a
 
 This parameter set should be implemented by _every_ cmdlet - the user is able to provide a `ResourceId` string or GUID from the Azure Portal, or from one of the generic resources cmdlets (more information about that below in the piping section), and act upon the given resource associated with the id. The typical `Name` and `ResourceGroupName` parameters are replaced by a single `ResourceId` parameter of type string.
 
-#### InputObject Parameter Set 
+#### InputObject Parameter Set
 
 This parameter should be implemented by _most_ cmdlets - the user is able to take the object returned from the `Get`, `New`, or `Set` cmdlets (or other cmdlets that return the common resource) and provide it to the `InputObject` parameter for a cmdlet that acts upon the same resource. The typical `Name` and `ResourceGroupName` parameters are retrieved from the `InputObject` that the user is passing through.
 
@@ -236,7 +240,7 @@ In this scenario, the user is able to pipe the result of a generic resources cmd
 Find-AzureRmResource -ResourceType Microsoft.Foo/foo | Remove-AzureRmFoo
 ```
 
-For more information on enabling the `ResourceId` piping scenario and more examples, please see the ["Using the `ResourceId` parameter"](./piping-in-powershell.md#using-the-resourceid-parameter) section of the _Piping in PowerShell_ document. 
+For more information on enabling the `ResourceId` piping scenario and more examples, please see the ["Using the `ResourceId` parameter"](./piping-in-powershell.md#using-the-resourceid-parameter) section of the _Piping in PowerShell_ document.
 
 ### InputObject
 

documentation/development-docs/help-generation.md

@@ -65,6 +65,11 @@ $PathToHelpFolder = "../../help" # Full path to help folder containing markdown
 Update-MarkdownHelpModule -Path $PathToHelpFolder -RefreshModulePage -AlphabeticParamsOrder
 ```
 
+Because the -UseFullTypeName parameter is not yet available in Update-MarkdownHelpModule (it will be enabled in the upcoming release of PlatyPS), you will need to run this command to modify the help files to use full type names:
+```
+Get-ChildItem -Path $PathToHelpFolder | Update-MarkdownHelp -AlphabeticParamsOrder -UseFullTypeName
+```
+
 This will update all of the markdown files with public interface changes made to corresponding cmdlets, add markdown files for any new cmdlets, remove markdown files for any deleted cmdlets, and update the module page (_e.g.,_ `AzureRM.Profile.md`) with any added or removed cmdlets.
 
 #### Updating a single markdown file
@@ -76,7 +81,7 @@ $PathToModuleManifest = "../../<module>.psd1" # Full path to the module manifest
 Import-Module -Name $PathToModuleManifest
 
 $PathToMarkdownFile = "../../<cmdlet>.md" # Full path to the markdown file to be updated
-Update-MarkdownHelp -Path $PathToMarkdownFile -AlphabeticParamsOrder
+Update-MarkdownHelp -Path $PathToMarkdownFile -AlphabeticParamsOrder -UseFullTypeName
 ```
 
 #### Generating and viewing the MAML help
@@ -101,4 +106,4 @@ $help = Get-HelpPreview -Path $PathToMAML
 
 # Get the help for a specific cmdlet
 $help | where { $_.Name -eq "<cmdlet>" }
-```
+```