Use Unknown for encryption status for issue Azure/WALinuxAgent#388

Author: Kamran Khan

src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/AzureDiskEncryptionExtensionConstants.cs

@@ -24,6 +24,8 @@ public static class AzureDiskEncryptionExtensionConstants
         public const string enableEncryptionOperation = "EnableEncryption";
         public const string disableEncryptionOperation = "DisableEncryption";
         public const string queryEncryptionStatusOperation = "QueryEncryptionStatus";
+        public const string encryptionResultOsKey = "os";
+        public const string encryptionResultDataKey = "data";
         public const string aadClientIDKey = "AADClientID";
         public const string aadClientSecretKey = "AADClientSecret";
         public const string aadClientCertThumbprintKey = "AADClientCertThumbprint";

src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/GetAzureDiskEncryptionStatus.cs

@@ -162,7 +162,14 @@ private string GetExtensionStatusMessage(OSType currentOSType, bool returnSubsta
 
                 if (returnSubstatusMessage)
                 {
-                    return context.SubStatuses[0].Message;
+                    if(context.SubStatuses != null)
+                    {
+                        return context.SubStatuses[0].Message;
+                    }
+                    else
+                    {
+                        throw new KeyNotFoundException(string.Format(CultureInfo.CurrentUICulture, "Invalid extension substatus"));
+                    }
                 }
 
                 return context.Statuses[0].Message;
@@ -367,13 +374,25 @@ public override void ExecuteCmdlet()
                             this.Name,
                             parameters).GetAwaiter().GetResult();
 
-                        string encryptionStatusJson = GetExtensionStatusMessage(osType, returnSubstatusMessage: true);
-                        Dictionary<string, string> encryptionStatusParsed = JsonConvert.DeserializeObject<Dictionary<string, string>>(encryptionStatusJson);
+                        Dictionary<string, string> encryptionStatusParsed = null;
+                        try
+                        {
+                            string encryptionStatusJson = GetExtensionStatusMessage(osType, returnSubstatusMessage: true);
+                            encryptionStatusParsed = JsonConvert.DeserializeObject<Dictionary<string, string>>(encryptionStatusJson);
+                        }
+                        catch(KeyNotFoundException)
+                        {
+                            encryptionStatusParsed = new Dictionary<string, string>()
+                            {
+                                { AzureDiskEncryptionExtensionConstants.encryptionResultOsKey, EncryptionStatus.Unknown.ToString() },
+                                { AzureDiskEncryptionExtensionConstants.encryptionResultDataKey, EncryptionStatus.Unknown.ToString() }
+                            };
+                        }
 
                         encryptionStatus = new AzureDiskEncryptionStatusContext
                         {
-                            OsVolumeEncrypted = (EncryptionStatus) Enum.Parse(typeof(EncryptionStatus), encryptionStatusParsed["os"]),
-                            DataVolumesEncrypted = (EncryptionStatus)Enum.Parse(typeof(EncryptionStatus), encryptionStatusParsed["data"]),
+                            OsVolumeEncrypted = (EncryptionStatus)Enum.Parse(typeof(EncryptionStatus), encryptionStatusParsed[AzureDiskEncryptionExtensionConstants.encryptionResultOsKey]),
+                            DataVolumesEncrypted = (EncryptionStatus)Enum.Parse(typeof(EncryptionStatus), encryptionStatusParsed[AzureDiskEncryptionExtensionConstants.encryptionResultDataKey]),
                             OsVolumeEncryptionSettings = osVolumeEncryptionSettings,
                             ProgressMessage = GetExtensionStatusMessage(osType)
                         };