Skip to content

Commit 6bf6846

Browse files
hyonholeehyonholee
committed
Remove Update-AzProximityPlacementGroup and update format file.
1 parent 318ecdf commit 6bf6846

File tree

10 files changed

+143
-337
lines changed

10 files changed

+143
-337
lines changed

‎src/Accounts/Accounts/AzureRmAlias/Mappings.json

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,7 @@
478478
"Remove-AzVMSecret": "Remove-AzureRmVMSecret",
479479
"Remove-AzVMNetworkInterface": "Remove-AzureRmVMNetworkInterface",
480480
"Remove-AzVMDataDisk": "Remove-AzureRmVMDataDisk",
481-
"Set-AzVMBootDiagnostic": "Set-AzureRmVMBootDiagnostic",
481+
"Set-AzVMBootDiagnostics": "Set-AzureRmVMBootDiagnostics",
482482
"Set-AzVMDataDisk": "Set-AzureRmVMDataDisk",
483483
"Set-AzVMPlan": "Set-AzureRmVMPlan",
484484
"Set-AzVMSourceImage": "Set-AzureRmVMSourceImage",
@@ -594,7 +594,7 @@
594594
"Get-AzVmssDiskEncryption": "Get-AzureRmVmssDiskEncryption",
595595
"Get-AzVmssVMDiskEncryption": "Get-AzureRmVmssVMDiskEncryption",
596596
"Export-AzLogAnalyticRequestRateByInterval": "Export-AzureRmLogAnalyticRequestRateByInterval",
597-
"Export-AzLogAnalyticThrottledRequest": "Export-AzureRmLogAnalyticThrottledRequest",
597+
"Export-AzLogAnalyticThrottledRequests": "Export-AzureRmLogAnalyticThrottledRequests",
598598
"Repair-AzVmssServiceFabricUpdateDomain": "Repair-AzureRmVmssServiceFabricUpdateDomain",
599599
"New-AzVMDataDisk": "New-AzureRmVMDataDisk",
600600
"Update-AzVmssVM": "Update-AzureRmVmssVM",
@@ -616,11 +616,7 @@
616616
"Remove-AzVmssVMDataDisk": "Remove-AzureRmVmssVMDataDisk",
617617
"Get-AzVmssDiskEncryptionStatus": "Get-AzureRmVmssDiskEncryptionStatus",
618618
"Get-AzVmssVMDiskEncryptionStatus": "Get-AzureRmVmssVMDiskEncryptionStatus",
619-
"Repair-AzVmssServiceFabricUD": "Repair-AzureRmVmssServiceFabricUD",
620-
"New-AzProximityPlacementGroup": "New-AzureRmProximityPlacementGroup",
621-
"Update-AzProximityPlacementGroup": "Update-AzureRmProximityPlacementGroup",
622-
"Get-AzProximityPlacementGroup": "Get-AzureRmProximityPlacementGroup",
623-
"Remove-AzProximityPlacementGroup": "Remove-AzureRmProximityPlacementGroup"
619+
"Repair-AzVmssServiceFabricUD": "Repair-AzureRmVmssServiceFabricUD"
624620
},
625621
"Az.Compute.ManagedService": {
626622
"ConvertTo-AzVhd": "ConvertTo-AzureRmVhd"

‎src/Compute/Compute.Test/ScenarioTests/PPGTests.ps1

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,16 +48,6 @@ function Test-ProximityPlacementGroup
4848
$ppgs = Get-AzProximityPlacementGroup;
4949
Assert-True { $ppgs.Count -ge 1 };
5050

51-
Update-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname -Tag @{key1 = "val2"};
52-
53-
$ppg = Get-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname;
54-
Assert-AreEqual $rgname $ppg.ResourceGroupName;
55-
Assert-AreEqual $ppgname $ppg.Name;
56-
Assert-AreEqual $loc $ppg.Location;
57-
Assert-AreEqual "Standard" $ppg.ProximityPlacementGroupType;
58-
Assert-True { $ppg.Tags.Keys.Contains("key1") };
59-
Assert-AreEqual "val2" $ppg.Tags["key1"];
60-
6151
Remove-AzProximityPlacementGroup -ResourceGroupName $rgname -Name $ppgname -Force;
6252

6353
$ppgs = Get-AzProximityPlacementGroup -ResourceGroupName $rgname;

‎src/Compute/Compute/ChangeLog.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
* Proximity placement group feature.
2323
- The following new cmdlets are added:
2424
New-AzProximityPlacementGroup
25-
Update-AzProximityPlacementGroup
2625
Get-AzProximityPlacementGroup
2726
Remove-AzProximityPlacementGroup
2827
- The new parameter, ProximityPlacementGroupId, is added to the following cmdlets:
@@ -36,7 +35,6 @@
3635
- Set-AzVMBootDiagnostics is changed to Set-AzVMBootDiagnostic.
3736
- Export-AzLogAnalyticThrottledRequests is changed to Export-AzLogAnalyticThrottledRequests.
3837

39-
4038
## Version 1.8.0
4139
* Fix issue with AEM installation if resource ids of disks had lowercase resourcegroups in resource id
4240
* Updated cmdlets with plural nouns to singular, and deprecated plural names.

‎src/Compute/Compute/Compute.Automation.generated.format.ps1xml

Lines changed: 105 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,111 @@
213213
</CustomEntries>
214214
</CustomControl>
215215
</View>
216+
<View>
217+
<Name>Microsoft.Azure.Commands.Compute.Automation.Models.PSProximityPlacementGroup</Name>
218+
<ViewSelectedBy>
219+
<TypeName>Microsoft.Azure.Commands.Compute.Automation.Models.PSProximityPlacementGroup</TypeName>
220+
</ViewSelectedBy>
221+
<CustomControl>
222+
<CustomEntries>
223+
<CustomEntry>
224+
<CustomItem>
225+
<ExpressionBinding>
226+
<ScriptBlock>[Microsoft.Azure.Commands.Compute.Automation.ComputeAutomationBaseCmdlet]::FormatObject($_)</ScriptBlock>
227+
</ExpressionBinding>
228+
</CustomItem>
229+
</CustomEntry>
230+
</CustomEntries>
231+
</CustomControl>
232+
</View>
233+
<View>
234+
<Name>Microsoft.Azure.Commands.Compute.Automation.Models.PSProximityPlacementGroup</Name>
235+
<ViewSelectedBy>
236+
<TypeName>Microsoft.Azure.Commands.Compute.Automation.Models.PSProximityPlacementGroup</TypeName>
237+
</ViewSelectedBy>
238+
<TableControl>
239+
<TableHeaders>
240+
<TableColumnHeader>
241+
<Label>ResourceGroupName</Label>
242+
<Alignment>Left</Alignment>
243+
</TableColumnHeader>
244+
<TableColumnHeader>
245+
<Label>Name</Label>
246+
<Alignment>Right</Alignment>
247+
</TableColumnHeader>
248+
<TableColumnHeader>
249+
<Label>Location</Label>
250+
<Alignment>Right</Alignment>
251+
</TableColumnHeader>
252+
<TableColumnHeader>
253+
<Label>Type</Label>
254+
<Alignment>Right</Alignment>
255+
</TableColumnHeader>
256+
</TableHeaders>
257+
<TableRowEntries>
258+
<TableRowEntry>
259+
<TableColumnItems>
260+
<TableColumnItem>
261+
<ScriptBlock>$_.ResourceGroupName</ScriptBlock>
262+
</TableColumnItem>
263+
<TableColumnItem>
264+
<ScriptBlock>$_.Name</ScriptBlock>
265+
</TableColumnItem>
266+
<TableColumnItem>
267+
<ScriptBlock>$_.Location</ScriptBlock>
268+
</TableColumnItem>
269+
<TableColumnItem>
270+
<ScriptBlock>$_.ProximityPlacementGroupType</ScriptBlock>
271+
</TableColumnItem>
272+
</TableColumnItems>
273+
</TableRowEntry>
274+
</TableRowEntries>
275+
</TableControl>
276+
</View>
277+
<View>
278+
<Name>Microsoft.Azure.Commands.Compute.Automation.Models.PSProximityPlacementGroupList</Name>
279+
<ViewSelectedBy>
280+
<TypeName>Microsoft.Azure.Commands.Compute.Automation.Models.PSProximityPlacementGroupList</TypeName>
281+
</ViewSelectedBy>
282+
<TableControl>
283+
<TableHeaders>
284+
<TableColumnHeader>
285+
<Label>ResourceGroupName</Label>
286+
<Alignment>Left</Alignment>
287+
</TableColumnHeader>
288+
<TableColumnHeader>
289+
<Label>Name</Label>
290+
<Alignment>Right</Alignment>
291+
</TableColumnHeader>
292+
<TableColumnHeader>
293+
<Label>Location</Label>
294+
<Alignment>Right</Alignment>
295+
</TableColumnHeader>
296+
<TableColumnHeader>
297+
<Label>Type</Label>
298+
<Alignment>Right</Alignment>
299+
</TableColumnHeader>
300+
</TableHeaders>
301+
<TableRowEntries>
302+
<TableRowEntry>
303+
<TableColumnItems>
304+
<TableColumnItem>
305+
<ScriptBlock>$_.ResourceGroupName</ScriptBlock>
306+
</TableColumnItem>
307+
<TableColumnItem>
308+
<ScriptBlock>$_.Name</ScriptBlock>
309+
</TableColumnItem>
310+
<TableColumnItem>
311+
<ScriptBlock>$_.Location</ScriptBlock>
312+
</TableColumnItem>
313+
<TableColumnItem>
314+
<ScriptBlock>$_.ProximityPlacementGroupType</ScriptBlock>
315+
</TableColumnItem>
316+
</TableColumnItems>
317+
</TableRowEntry>
318+
</TableRowEntries>
319+
</TableControl>
320+
</View>
216321
<View>
217322
<Name>Microsoft.Azure.Commands.Compute.Automation.Models.PSResourceSku</Name>
218323
<ViewSelectedBy>

‎src/Compute/Compute/Generated/ProximityPlacementGroup/ProximityPlacementGroupDeleteMethod.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ public override void ExecuteCmdlet()
7070
EndTime = DateTime.Now
7171
};
7272

73-
if (result != null && result.Request != null && result.Request.RequestUri != null)
73+
if (result != null)
7474
{
75-
output.Name = GetOperationIdFromUrlString(result.Request.RequestUri.ToString());
75+
output.Name = result.RequestId;
7676
}
7777

7878
WriteObject(output);

‎src/Compute/Compute/Generated/ProximityPlacementGroup/ProximityPlacementGroupUpdateMethod.cs

Lines changed: 0 additions & 112 deletions
This file was deleted.

‎src/Compute/Compute/help/Az.Compute.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -557,9 +557,6 @@ Update a gallery image version.
557557
### [Update-AzImage](Update-AzImage.md)
558558
Updates an image.
559559

560-
### [Update-AzProximityPlacementGroup](Update-AzProximityPlacementGroup.md)
561-
Update Proximity Placement Group resource.
562-
563560
### [Update-AzSnapshot](Update-AzSnapshot.md)
564561
Updates a snapshot.
565562

‎src/Compute/Compute/help/Get-AzProximityPlacementGroup.md

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,21 +31,43 @@ This cmdlet will get or list Proximity Placement Group resource(s).
3131

3232
### Example 1
3333
```
34-
PS C:\> Get-AzureRmProximityPlacementGroup -ResourceGroupName $resourceGroupName -Name $proximityPlacementGroupName
34+
PS C:\> Get-AzureRmProximityPlacementGroup -ResourceGroupName $resourceGroupName -Name $proximityPlacementGroupName
35+
36+
ResourceGroupName : rg0
37+
ProximityPlacementGroupType : Standard
38+
VirtualMachines : {}
39+
VirtualMachineScaleSets : {}
40+
AvailabilitySets : {}
41+
Id : /subscriptions/5393f919-a68a-43d0-9063-4b2bda6bffdf/resourceGroups/rg0/providers/Microsoft.Compute/proximityPlacementGroups/ppg0
42+
Name : ppg0
43+
Type : Microsoft.Compute/proximityPlacementGroups
44+
Location : westcentralus
45+
Tags : {[key1, val1]}
3546
```
3647

3748
This command gets the proximity placement group
3849

3950
### Example 2
4051
```
41-
PS C:\> Get-AzureRmProximityPlacementGroup -ResourceGroupName $resourceGroupName
52+
PS C:\> Get-AzureRmProximityPlacementGroup -ResourceGroupName $resourceGroupName
53+
54+
ResourceGroupName Name Location Type
55+
----------------- ---- -------- ----
56+
rg0 ppg0 westcentralus Standard
57+
rg0 ppg1 westcentralus Standard
4258
```
4359

4460
This command list all proximity placement groups under the given resource group.
4561

4662
### Example 3
4763
```
4864
PS C:\> Get-AzureRmProximityPlacementGroup
65+
66+
ResourceGroupName Name Location Type
67+
----------------- ---- -------- ----
68+
rg0 ppg0 westcentralus Standard
69+
rg0 ppg1 westcentralus Standard
70+
rg1 ppg2 centralus Standard
4971
```
5072

5173
This command list all proximity placement groups under the subscription.

‎src/Compute/Compute/help/New-AzProximityPlacementGroup.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,15 @@ This cmdlet will create Proximity Placement Group resource.
2525

2626
### Example 1
2727
```
28-
PS C:\> New-AzureRmProximityPlacementGroup -ResourceGroupName $resourceGroupName -Name $proximityPlacementGroupName -Location $location
28+
PS C:\> New-AzureRmProximityPlacementGroup -ResourceGroupName $resourceGroupName -Name $proximityPlacementGroupName -Location $location -Tag @{key1 = "val1"}
29+
30+
ResourceGroupName : rg0
31+
ProximityPlacementGroupType : Standard
32+
Id : /subscriptions/5393f919-a68a-43d0-9063-4b2bda6bffdf/resourceGroups/rg0/providers/Microsoft.Compute/proximityPlacementGroups/ppg0
33+
Name : ppg0
34+
Type : Microsoft.Compute/proximityPlacementGroups
35+
Location : westcentralus
36+
Tags : {"key1":"val1"}
2937
```
3038

3139
This command creates a proximity place group in the given location.

0 commit comments

Comments
 (0)