Change the exception message.

Author: Tiano2017

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Handlers/RetryHandler.cs

@@ -57,14 +57,14 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
         {
             HttpResponseMessage response = null;
 
-            for (int attempt = 0; attempt < RetryHandler.MaxAttempts; ++attempt)
+            for (int attempt = 1; attempt <= RetryHandler.MaxAttempts; ++attempt)
             {
                 try
                 {
                     response = await base.SendAsync(request: request, cancellationToken: cancellationToken)
                         .ConfigureAwait(continueOnCapturedContext: false);
 
-                    if (attempt == RetryHandler.MaxAttempts - 1 ||
+                    if (attempt == RetryHandler.MaxAttempts ||
                         (!response.StatusCode.IsServerFailureRequest() &&
                          response.StatusCode != HttpStatusCode.RequestTimeout &&
                          response.StatusCode != HttpStatusCodeExt.TooManyRequests))
@@ -74,7 +74,7 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
                 }
                 catch (Exception ex)
                 {
-                    if (ex.IsFatal() || attempt == RetryHandler.MaxAttempts - 1)
+                    if (ex.IsFatal() || attempt == RetryHandler.MaxAttempts)
                     {
                         throw;
                     }
@@ -89,6 +89,7 @@ await Task.Delay(delay: RetryHandler.GetDelay(attempt), cancellationToken: cance
                     .ConfigureAwait(continueOnCapturedContext: false);
             }
 
+            /// should never reach here. 
             return null;
         }
 

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Properties/Resources.Designer.cs

@@ -396,4 +396,7 @@
   <data name="UpdatedResourceGroup" xml:space="preserve">
     <value>Updated resource group '{0}' in location '{1}'</value>
   </data>
+  <data name="OperationFailedWithTimeOut" xml:space="preserve">
+    <value>Operation failed because a request time out.</value>
+  </data>
 </root>

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Properties/Resources.resx

@@ -14,17 +14,18 @@
 
 namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.RestClients
 {
+    using System;
+    using System.Net.Http;
+    using System.Text;
+    using System.Threading;
+    using System.Threading.Tasks;
     using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
     using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Entities.ErrorResponses;
     using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Extensions;
     using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Utilities;
     using Newtonsoft.Json;
     using Newtonsoft.Json.Linq;
-    using System;
-    using System.Net.Http;
-    using System.Text;
-    using System.Threading;
-    using System.Threading.Tasks;
+    using ProjectResources = Microsoft.Azure.Commands.ResourceManager.Cmdlets.Properties.Resources;
 
     /// <summary>
     /// A base class for Azure clients.
@@ -247,7 +248,7 @@ protected async Task<HttpResponseMessage> SendRequestAsync(HttpRequestMessage re
                 {
                     if (exception is OperationCanceledException && !cancellationToken.IsCancellationRequested)
                     {
-                        throw new TimeoutException("A request times out.");
+                        throw new Exception(ProjectResources.OperationFailedWithTimeOut);
                     }
 
                     throw;