Add culture info to version parsing (#13343)

* fix parsing bug

* add default values

* add culture info

* update changelog

Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>

Author: 3 people

src/Resources/Resources/ChangeLog.md

@@ -20,6 +20,7 @@
 ## Upcoming Release
 * Fixed an issue where What-If shows two resource group scopes with different casing
 * Updated `Export-AzResourceGroup` to use the SDK.
+* Added culture info to parse methods
 
 ## Version 3.0.0
 * Fixed parsing bug

src/Resources/Resources/RoleAssignments/NewAzureRoleAssignmentCommand.cs

@@ -20,6 +20,7 @@
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
 using Newtonsoft.Json;
 using System;
+using System.Globalization;
 using System.IO;
 using System.Management.Automation;
 
@@ -273,7 +274,7 @@ public override void ExecuteCmdlet()
             }
             // ensure that if ConditionVersion is empty in any way, it becomes null
             ConditionVersion = string.IsNullOrEmpty(ConditionVersion) ? null : string.IsNullOrWhiteSpace(ConditionVersion) ? null : ConditionVersion; 
-            double _conditionVersion = double.Parse(ConditionVersion ?? "2.0");
+            double _conditionVersion = double.Parse(ConditionVersion ?? "2.0", CultureInfo.InvariantCulture);
             if (_conditionVersion < 2.0)
             {
                 WriteExceptionError(new ArgumentException("Argument -ConditionVersion must be greater or equal than 2.0"));