Skip to content

Commit 74b7217

Browse files
authored
add 2 tests (#23874)
1 parent 3fe20be commit 74b7217

File tree

4 files changed

+466
-599
lines changed

4 files changed

+466
-599
lines changed

src/Resources/Resources.Test/ScenarioTests/RoleAssignmentTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public void RaByResource()
9292
}
9393

9494
[Fact]//(Skip = "Test indicates Graph call is not recorded when it actually is, refer to https://github.com/Azure/azure-powershell/issues/14632 for more details, test passes in record mode")]
95-
[Trait(Category.AcceptanceType, Category.LiveOnly)]
95+
[Trait(Category.AcceptanceType, Category.CheckIn)]
9696
public void RaByServicePrincipal()
9797
{
9898
TestRunner.RunTestScript("Test-RaByServicePrincipal");
@@ -155,7 +155,7 @@ public void RaGetByUPNWithExpandPrincipalGroups()
155155
}
156156

157157
[Fact]
158-
[Trait(Category.AcceptanceType, Category.LiveOnly)]
158+
[Trait(Category.AcceptanceType, Category.CheckIn)]
159159
public void RaCreatedBySP()
160160
{
161161
TestRunner.RunTestScript("Test-RaCreatedBySP");

src/Resources/Resources.Test/ScenarioTests/RoleAssignmentTests.ps1

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -241,18 +241,18 @@ Tests verifies creation and deletion of a RoleAssignments for Service principal
241241
function Test-RaByServicePrincipal
242242
{
243243
# Setup
244-
$servicePrincipals = "7059a716-3bd8-405e-ac54-4fe098aba140" # powershell-test-uami
244+
$servicePrincipals = "3d9979c5-7de9-4cc5-bc9c-d63d365c5b5c"
245245

246246
$definitionName = 'Reader'
247-
$Scope = '/subscriptions/4004a9fd-d58e-48dc-aeb2-4a4aec58606f'
247+
$Scope = '/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590'
248248

249249
# Test
250-
$newAssignment1 = New-AzRoleAssignment -ObjectId $servicePrincipals -RoleDefinitionName $definitionName -Scope $scope
250+
$newAssignment1 = New-AzRoleAssignmentWithId -ObjectId $servicePrincipals -RoleDefinitionName $definitionName -Scope $scope -RoleAssignmentId 238799bf-1a93-45d7-120d-f3edbaeb3bc7
251251

252252
$definitionName = 'Contributor'
253253
# Test
254-
$appId = "306d85f9-f885-4bdf-a20e-36d6ee8eddad" # PowershellTestingApp
255-
$newAssignment2 = New-AzRoleAssignment -ApplicationId $appId -RoleDefinitionName $definitionName -Scope $scope
254+
$appId = "2076eb2d-7a68-41f8-9645-4a77d9057d94"
255+
$newAssignment2 = New-AzRoleAssignmentWithId -ApplicationId $appId -RoleDefinitionName $definitionName -Scope $scope -RoleAssignmentId 238799bf-1593-45d7-120d-f3edbceb3bc7
256256

257257
$assignments = Get-AzRoleAssignment -ObjectId $newAssignment2.ObjectId
258258
Assert-NotNull $assignments
@@ -267,7 +267,6 @@ function Test-RaByServicePrincipal
267267
Assert-NotNull $newAssignment2
268268
Assert-AreEqual $definitionName $newAssignment2.RoleDefinitionName
269269
Assert-AreEqual $scope $newAssignment2.Scope
270-
# Assert-AreEqual $servicePrincipals[0].DisplayName $newAssignment2.DisplayName
271270

272271
#Start-TestSleep -Seconds 300
273272

@@ -622,10 +621,10 @@ function Test-RaCreatedBySP
622621
# Prerequisite: Conect to azure with SP
623622
# Create role assignment
624623
# powershell-testmember's PrincipalId
625-
$testUser = "e9da4467-12ff-4334-8179-c99abf0ffd5a"
626-
$Scope = '/subscriptions/4004a9fd-d58e-48dc-aeb2-4a4aec58606f'
624+
$testUser = "3d9979c5-7de9-4cc5-bc9c-d63d365c5b5c"
625+
$Scope = '/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590'
627626

628-
$assignment = New-AzRoleAssignment -ObjectId $testUser -RoleDefinitionName 'Reader' -Scope $Scope
627+
$assignment = New-AzRoleAssignmentWithId -ObjectId $testUser -RoleDefinitionName 'Reader' -Scope $Scope -RoleAssignmentId 3d9979c5-7de9-4cc5-bc9c-d63d365c5b44
629628

630629
Assert-NotNull $assignment
631630
}

0 commit comments

Comments
 (0)