Merge pull request #5615 from Azure/release-2018-02-23

[5.4.0] Merge release --> master

Author: cormacpayne

.github/ISSUE_TEMPLATE.md

@@ -1,16 +1,51 @@
-### Cmdlet(s)
+<!--
 
-### PowerShell Version
-Instructions: to get PowerShell version, type `$PSVersionTable` and look for the value associated with `PSVersion`
+If this issue is a bug report:
+- Upgrade to the latest version of AzureRM and verify you are able to reproduce the issue
+    - You can install the latest version of AzureRM from the PowerShell Gallery
+        - https://www.powershellgallery.com/packages/AzureRM
+    - You can also install the latest version from the Releases section
+        - https://github.com/Azure/azure-powershell/releases
+- Ensure that you repro the issue with $DebugPreference = "Continue" to receive the debug stream
+- If this bug involves an exception being thrown, please run Resolve-AzureRmError to receive extended information on the error
+- Fill out the below template
 
-### Module Version
+If this issue is not a bug report, please remove the below template
 
-### OS Version
-Instructions: to get OS version, type `$PSversionTable` and look for value associated with `BuildVersion`
+-->
 
 ### Description
 
-### Debug Output
-Instructions: to get Debug Output, set `$DebugPreference="Continue"` and then execute the cmdlet or script causing the issue
+<!-- Please provide a description of the issue you are facing -->
 
 ### Script/Steps for Reproduction
+
+<!-- Please provide the necessary script(s) that reproduce the issue -->
+
+```powershell
+
+```
+
+### Module Version
+
+<!-- Please run (Get-Module -Name AzureRM -ListAvailable) to get the version(s) of AzureRM installed on your machine -->
+
+```powershell
+Get-Module -Name AzureRM -ListAvailable
+```
+
+### Environment Data
+
+<!-- Please run $PSVersionTable to get the necessary environment data -->
+
+```powershell
+$PSVersionTable
+```
+
+### Debug Output
+
+<!-- Please run the above script with $DebugPreference = "Continue" and paste the resulting debug stream in the below code block -->
+
+```
+
+```

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,34 +1,16 @@
 <!-- DO NOT DELETE THIS TEMPLATE -->
 
 ## Description
-<!--
-Please add an informative description that covers the changes made by the pull request.
 
-If applicable, reference the bug/issue that this pull request fixes here.
--->
+<!-- Please add a brief description of the changes made in this PR -->
 
----
+## Checklist
 
-This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices [here](https://msdn.microsoft.com/en-us/library/dd878270(v=vs.85).aspx).
-
-- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md).**
-- [ ] **If changes were made to any cmdlet, the XML help was regenerated using the [platyPSHelp module](https://github.com/Azure/azure-powershell/blob/preview/documentation/help-generation.md).**
-- [ ] **If any large changes are made to a service, they are reflected in the respective [change log](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log).**
-
-### [General Guidelines](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#general-guidelines)
-- [ ] Title of the pull request is clear and informative.
-- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/preview/documentation/cleaning-up-commits.md).
-- [ ] The pull request does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md) (unless a major version change occurs in the assembly and module).
-
-### [Testing Guidelines](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#testing-guidelines)
-- [ ] Pull request includes test coverage for the included changes.
-- [ ] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.
-
-### [Cmdlet Signature Guidelines](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#cmdlet-signature-guidelines)
-- [ ] New cmdlets that make changes or have side effects should implement `ShouldProcess` and have `SupportShouldProcess=true` specified in the cmdlet attribute. You can find more information on `ShouldProcess` [here](https://github.com/Azure/azure-powershell/wiki/PowerShell-Cmdlet-Design-Guidelines#supportsshouldprocess).
-- [ ] Cmdlet specifies `OutputType` attribute if any output is produced - if the cmdlet produces no output, it should implement a `PassThru` parameter.
-
-### [Cmdlet Parameter Guidelines](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#cmdlet-parameter-guidelines)
-- [ ] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
-- [ ] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
-- [ ] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.
+- [ ] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#making-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)
+- [ ] The title of the PR is clear and informative
+- [ ] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)
+- [ ] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)
+- [ ] If applicable, the changes made in the PR have proper test coverage
+- [ ] For public API changes to cmdlets:
+    - [ ] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr)
+    - [ ] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)

CONTRIBUTING.md

@@ -45,7 +45,7 @@ Before cloning this repository, please make sure you have started in our [docume
 
 #### GitHub Workflow
 
-If you don't have experience with Git and GitHub, some of the terminology and process can be confusing. [Here is a guide to understanding the GitHub flow](https://guides.github.com/introduction/flow/) and [here is a guide to understanding the basic Git commands](https://services.github.com/kit/downloads/github-git-cheat-sheet.pdf).
+If you don't have experience with Git and GitHub, some of the terminology and process can be confusing. [Here is a guide to understanding the GitHub flow](https://guides.github.com/introduction/flow/) and [here is a guide to understanding the basic Git commands](https://education.github.com/git-cheat-sheet-education.pdf).
 
 #### Forking the Azure/azure-powershell repository
 
@@ -65,7 +65,7 @@ To suggest a new feature or changes that could be made to Azure PowerShell, file
 
 You can find the code complete and release dates of the next three Azure PowerShell releases in the [Milestones](https://github.com/Azure/azure-powershell/milestones) section of the Issue page. Each milestone will display the issues that are being worked on for the corresponding release. 
 
-## Making Changes
+## Submitting Changes
 
 ### Pull Requests
 
@@ -83,15 +83,15 @@ To open your own pull request, click [here](https://github.com/Azure/azure-power
 
 ### SDK for .NET
 
-Before making any changes to the Azure PowerShell repository, the corresponding NuGet packages must have been published from the [Azure SDK for .NET](https://github.com/Azure/azure-sdk-for-net) repository.
+If your changes require a new version of an Azure management library, please ensure that the corresponding NuGet package has been published from the [Azure SDK for .NET repository](https://github.com/Azure/azure-sdk-for-net).
 
-For more information on how to make changes to the SDK for .NET repository and publish the corresponding packages to NuGet, click [here](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/README.md).
+For more information on how to make changes to the SDK for .NET repository and publish packages to NuGet, please see the [`README.md`](https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/README.md) in the Azure SDK for .NET repository.
 
 ### Pull Request Guidelines
 
 A pull request template will automatically be included as a part of your PR. Please fill out the checklist as specified. Pull requests **will not be reviewed** unless they include a properly completed checklist.
 
-The following is a list of guidelines that pull requests opened in the Azure PowerShell repository must adhere to. You can find a more complete discussion of PowerShell cmdlet best practices [here](https://msdn.microsoft.com/en-us/library/dd878270(v=vs.85).aspx).
+The following is a list of guidelines that pull requests opened in the Azure PowerShell repository must adhere to. You can find a more complete discussion of Azure PowerShell design guidelines [here](./documentation/development-docs/azure-powershell-design-guidelines.md).
 
 #### Cleaning up Commits
 
@@ -107,13 +107,13 @@ For more information on cleaning up the commits in a pull request, such as how t
 
 #### Updating the change log
 
-Any public API changes that are made to a service must be reflected in the respecitve change log. This change log will allow customers to easily track what has been changed between releases of a service.
+Any changes that are made must be reflected in the respecitve service's change log. This change log will allow customers to easily track what has been changed between releases of a service.
 
-For ResourceManager services, the change log is located at `src\ResourceManager\SERVICE\ChangeLog.md`.
+For ARM service projects, the change log is located at `src\ResourceManager\{{service}}\ChangeLog.md`.
 
-For ServiceManagement services, the change log is located at `src\ServiceManagement\Services\Commands.Utilities\ChangeLog.md`.
+For RDFE service projects, the change log is located at `src\ServiceManagement\ChangeLog.md`.
 
-For Storage, this change log is located at `src\Storage\ChangeLog.md`.
+For the Storage data plane project, this change log is located at `src\Storage\ChangeLog.md`.
 
 #### Breaking Changes
 
@@ -152,9 +152,9 @@ The following guidelines must be followed in pull requests that add, edit, or re
     - Note that you can see a list of all approved PowerShell verbs by running `Get-Verb` in PowerShell
     - When a verb you would like to use is not in the list of approved verbs, or to get ideas on how to use verbs, consult the [Approved Verbs for Windows PowerShell Commands](https://msdn.microsoft.com/en-us/library/ms714428\(v=vs.85\).aspx) documentation where you will find descriptions of approved verbs as well as related verbs in the comments so that you can find one appropriate for your command
 - Cmdlet noun name uses the AzureRm prefix for management cmdlets, and the Azure prefix for data plane cmdlets
-- Cmdlet specifies the `OutputType` attribute if any output is produced; if the cmdlet produces no output, it should implement a `PassThrough` parameter
+- Cmdlet specifies the `OutputType` attribute; if the cmdlet produces no output, it should have an `OutputType` of `bool` and implement a `PassThrough` parameter
 - If the cmdlet makes changes or has side effects, it should implement `ShouldProcess` and have `SupportsShouldProcess = true` specified in the cmdlet attribute. See a discussion about correct `ShouldProcess` implementation [here](https://gist.github.com/markcowl/338e16fe5c8bbf195aff9f8af0db585d#what-is-the-change).
-- Cmdlets should derive from AzureRmCmdlet for management cmdlets, and AzureDataCmdlet for data cmdlets
+- Cmdlets should derive from [`AzureRmCmdlet`](src/ResourceManager/Common/Commands.ResourceManager.Common/AzureRMCmdlet.cs) class for management cmdlets, and [`AzureDataCmdlet`](src/Common/Commands.Common/AzureDataCmdlet.cs) for data cmdlets
 - If multiple parameter sets are implemented, the cmdlet should specify a `DefaultParameterSetName` in its cmdlet attribute
 
 #### Cmdlet parameter guidelines

ChangeLog.md

@@ -1,4 +1,53 @@
-## 5.3.0 - February 2018
+## 5.4.0 - February 2018
+#### AzureRM.Automation
+* Added alias from New-AzureRmAutomationModule to Import-AzureRmAutomationModule
+
+#### AzureRM.Compute
+* Fix ErrorAction issue for some of Get cmdlets.
+
+#### AzureRM.ContainerInstance
+* Apply Azure Container Instance SDK 2018-02-01
+    - Support DNS name label
+
+#### AzureRM.DevTestLabs
+* Fixed all of the GET cmdlets which previously weren't working.
+
+#### AzureRM.EventHub
+* Fix bug in Get-AzureRmEventHubGeoDRConfiguration help
+
+#### AzureRM.Network
+* Added cmdlet to create a new connection monitor
+    - New-AzureRmNetworkWatcherConnectionMonitor
+* Added cmdlet to update a connection monitor
+    - Set-AzureRmNetworkWatcherConnectionMonitor
+* Added cmdlet to get connection monitor or connection monitor list
+    - Get-AzureRmNetworkWatcherConnectionMonitor
+* Added cmdlet to query connection monitor
+    - Get-AzureRmNetworkWatcherConnectionMonitorReport
+* Added cmdlet to start connection monitor
+    - Start-AzureRmNetworkWatcherConnectionMonitor
+* Added cmdlet to stop connection monitor
+    - Stop-AzureRmNetworkWatcherConnectionMonitor
+* Added cmdlet to remove connection monitor
+    - Remove-AzureRmNetworkWatcherConnectionMonitor
+* Updated Set-AzureRmApplicationGatewayBackendAddressPool documentation to remove deprecated example
+* Added EnableHttp2 flag to Application Gateway
+    - Updated New-AzureRmApplicationGateway: Added optional parameter -EnableHttp2
+* Add IpTags to PublicIpAddress
+    - Updated New-AzureRmPublicIpAddress: Added IpTags
+    - New-AzureRmPublicIpTag to add Iptag
+* Add DisableBgpRoutePropagation property in RouteTable and effectiveRoute.
+
+#### AzureRM.Resources
+* Register-AzureRmProviderFeature: Added missing example in the docs
+* Register-AzureRmResourceProvider: Added missing example in the docs
+
+#### AzureRM.Storage
+* Obsolete following parameters in new and set Storage Account cmdlets: EnableEncryptionService and DisableEncryptionService, since Encryption at Rest is enabled by default and can't be disabled.
+    - New-AzureRmStorageAccount
+    - Set-AzureRmStorageAccount
+
+## 5.3.0 - February 2018
 #### AzureRM.Profile
 * Added deprecation warning for PowerShell 3 and 4
 * 'Add-AzureRmAccount' has been renamed as 'Connect-AzureRmAccount'; an alias has been added for the old cmdlet name, and other aliases ('Login-AzAccount' and 'Login-AzureRmAccount') have been redirected to the new cmdlet name.