Change the FIPS issue fixing code with the feedback

Author: blueww

src/Storage/ChangeLog.md

@@ -18,7 +18,10 @@
         - Additional information about change #1
 -->
 ## Current Release
-
+* Fix the issue that upload Blob and upload File cmdlets fail on FIPS policy enabled machines
+	- Set-AzureStorageBlobContent
+	- Set-AzureStorageFileContent
+	
 ## Version 4.2.0
 * Support Soft-Delete feature
 	- Enable-AzureStorageDeleteRetentionPolicy

src/Storage/Commands.Storage/Blob/Cmdlet/SetAzureStorageBlobContent.cs

@@ -501,7 +501,7 @@ public override void ExecuteCmdlet()
             }
 
             // if FIPS policy is enabled, must use native MD5
-            if (FIPSEnabled)
+            if (fipsEnabled)
             {
                 CloudStorageAccount.UseV1MD5 = false;
             }

src/Storage/Commands.Storage/Common/StorageCloudCmdletBase.cs

@@ -626,28 +626,19 @@ protected override void StopProcessing()
         /// <summary>
         /// true if FIPS policy is enabled on the current machine
         /// </summary>
-        protected static bool FIPSEnabled
+        public static bool fipsEnabled { get; } = IsFIPSEnabled();
+
+        internal static bool IsFIPSEnabled()
         {
-            get
+            try
             {
-                if (fIPSEnabled.HasValue)
-                {
-                    return fIPSEnabled.Value;
-                }
-
-                try
-                {
-                    System.Security.Cryptography.MD5.Create();
-                }
-                catch (System.Reflection.TargetInvocationException)
-                {
-                    fIPSEnabled = true;
-                    return true;
-                }
-                fIPSEnabled = false;
+                System.Security.Cryptography.MD5.Create();
                 return false;
             }
+            catch (System.Reflection.TargetInvocationException)
+            {
+                return true;
+            }
         }
-        private static bool? fIPSEnabled = null;
     }
 }

src/Storage/Commands.Storage/File/Cmdlet/SetAzureStorageFileContent.cs

@@ -81,7 +81,7 @@ public override void ExecuteCmdlet()
             }
 
             // if FIPS policy is enabled, must use native MD5
-            if (FIPSEnabled)
+            if (fipsEnabled)
             {
                 CloudStorageAccount.UseV1MD5 = false;
             }