Merge pull request #6050 from maddieclayton/tagchange

Breaking changes to DataLakeAnalytics

Author: Maddie Clayton

src/ResourceManager/DataLakeAnalytics/ChangeLog.md

@@ -19,6 +19,9 @@
 -->
 ## Current Release
 * Set minimum dependency of module to PowerShell 5.0
+* Remove deprecated `Tags` alias from cmdlets
+    - `New-AzureRmDataLakeAnalyticsAccount`
+    - `Set-AzureRmDataLakeAnalyticsAccount`
 
 ## Version 4.2.3
 * Updated to the latest version of the Azure ClientRuntime

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/ScenarioTests/AdlaAliasTests.ps1

@@ -375,7 +375,7 @@ function Test-DataLakeAnalyticsAccount
 
 		# Updating Account
 		$tagsToUpdate = @{"TestTag" = "TestUpdate"}
-		$accountUpdated = Set-AdlAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $accountName -Tags $tagsToUpdate
+		$accountUpdated = Set-AdlAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $accountName -Tag $tagsToUpdate
 
 		Assert-AreEqual $accountName $accountUpdated.Name
 		Assert-AreEqual $location $accountUpdated.Location
@@ -714,7 +714,7 @@ function Test-NegativeDataLakeAnalyticsAccount
 
 		# attempt to update a non-existent account
 		$tagsToUpdate = @{"TestTag" = "TestUpdate"}
-		Assert-Throws {Set-AdlAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $fakeaccountName -Tags $tagsToUpdate}
+		Assert-Throws {Set-AdlAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $fakeaccountName -Tag $tagsToUpdate}
 
 		# attempt to get a non-existent account
 		Assert-Throws {Get-AdlAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $fakeaccountName}

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/ScenarioTests/AdlaTests.ps1

@@ -262,7 +262,7 @@ function Test-DataLakeAnalyticsAccount
 
 		# Updating Account
 		$tagsToUpdate = @{"TestTag" = "TestUpdate"}
-		$accountUpdated = Set-AzureRmDataLakeAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $accountName -Tags $tagsToUpdate
+		$accountUpdated = Set-AzureRmDataLakeAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $accountName -Tag $tagsToUpdate
 
 		Assert-AreEqual $accountName $accountUpdated.Name
 		Assert-AreEqual $location $accountUpdated.Location
@@ -713,7 +713,7 @@ function Test-NegativeDataLakeAnalyticsAccount
 
 		# attempt to update a non-existent account
 		$tagsToUpdate = @{"TestTag" = "TestUpdate"}
-		Assert-Throws {Set-AzureRmDataLakeAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $fakeaccountName -Tags $tagsToUpdate}
+		Assert-Throws {Set-AzureRmDataLakeAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $fakeaccountName -Tag $tagsToUpdate}
 
 		# attempt to get a non-existent account
 		Assert-Throws {Get-AzureRmDataLakeAnalyticsAccount -ResourceGroupName $resourceGroupName -Name $fakeaccountName}

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/NewAzureRmDataLakeAnalyticsAccount.cs

@@ -51,8 +51,6 @@ public class NewAzureDataLakeAnalyticsAccount : DataLakeAnalyticsCmdletBase
 
         [Parameter(ValueFromPipelineByPropertyName = true, Position = 4, Mandatory = false,
             HelpMessage = "A string,string dictionary of tags associated with this account")]
-        [Obsolete("New-AzureRmDataLakeAnalyticsAccount: -Tags will be removed in favor of -Tag in an upcoming breaking change release.  Please start using the -Tag parameter to avoid breaking scripts.")]
-        [Alias("Tags")]
         [ValidateNotNull]
         public Hashtable Tag { get; set; }
 

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/SetAzureRmDataLakeAnalyticsAccount.cs

@@ -34,8 +34,6 @@ public class SetAzureDataLakeAnalyticsAccount : DataLakeAnalyticsCmdletBase
             HelpMessage =
                 "A string,string dictionary of tags associated with this account that should replace the current set of tags"
             )]
-        [Obsolete("Set-AzureRmDataLakeAnalyticsAccount: -Tags will be removed in favor of -Tag in an upcoming breaking change release.  Please start using the -Tag parameter to avoid breaking scripts.")]
-        [Alias("Tags")]
         [ValidateNotNull]
         public Hashtable Tag { get; set; }
 

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/help/New-AzureRmDataLakeAnalyticsAccount.md

@@ -162,7 +162,7 @@ A string,string dictionary of tags associated with this account
 ```yaml
 Type: Hashtable
 Parameter Sets: (All)
-Aliases: Tags
+Aliases:
 
 Required: False
 Position: 4

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/help/Set-AzureRmDataLakeAnalyticsAccount.md

@@ -162,7 +162,7 @@ A string,string dictionary of tags associated with this account that should repl
 ```yaml
 Type: Hashtable
 Parameter Sets: (All)
-Aliases: Tags
+Aliases:
 
 Required: False
 Position: 1

src/ResourceManager/DataLakeAnalytics/documentation/upcoming-breaking-changes.md

@@ -25,4 +25,12 @@
     https://github.com/Azure/azure-powershell/blob/dev/documentation/breaking-changes/breaking-change-template.md
 -->
 
-# Upcoming Breaking Changes
+# Upcoming Breaking Changes
+
+The following cmdlets were affected this release:
+
+**New-AzureRmDataLakeAnalyticsAccount**
+- The parameter alias `Tags` is being removed
+
+**Set-AzureRmDataLakeAnalyticsAccount**
+- The parameter alias `Tags` is being removed

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

@@ -1515,6 +1515,8 @@
 "Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.SetAzureKeyVaultSecretAttribute","Set-AzureKeyVaultSecretAttribute","0","1050","The parameter set 'InputObject' for cmdlet 'Set-AzureKeyVaultSecretAttribute' has been removed.","Add parameter set 'InputObject' back to cmdlet 'Set-AzureKeyVaultSecretAttribute'."
 "Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.SetAzureKeyVaultSecretAttribute","Set-AzureKeyVaultSecretAttribute","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Set-AzureKeyVaultSecretAttribute' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Set-AzureKeyVaultSecretAttribute'."
 "Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.Commands.GetAzureKeyVaultCertificatePolicy","Get-AzureKeyVaultCertificatePolicy","0","1050","The parameter set 'VaultAndCertName' for cmdlet 'Get-AzureKeyVaultCertificatePolicy' has been removed.","Add parameter set 'VaultAndCertName' back to cmdlet 'Get-AzureKeyVaultCertificatePolicy'."
+"Microsoft.Azure.Commands.DataLakeAnalytics.dll","Microsoft.Azure.Commands.DataLakeAnalytics.NewAzureDataLakeAnalyticsAccount","New-AzureRmDataLakeAnalyticsAccount","0","2010","The cmdlet 'New-AzureRmDataLakeAnalyticsAccount' no longer supports the alias 'Tags' for parameter 'Tag'.","Add the alias 'Tags' back to parameter 'Tag'."
+"Microsoft.Azure.Commands.DataLakeAnalytics.dll","Microsoft.Azure.Commands.DataLakeAnalytics.SetAzureDataLakeAnalyticsAccount","Set-AzureRmDataLakeAnalyticsAccount","0","2010","The cmdlet 'Set-AzureRmDataLakeAnalyticsAccount' no longer supports the alias 'Tags' for parameter 'Tag'.","Add the alias 'Tags' back to parameter 'Tag'."
 "Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.UpdateAzureKeyVaultManagedStorageAccountKey","Update-AzureKeyVaultManagedStorageAccountKey","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzureKeyVaultManagedStorageAccountKey' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzureKeyVaultManagedStorageAccountKey'."
 "Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.RemoveAzureKeyVaultManagedStorageAccount","Remove-AzureKeyVaultManagedStorageAccount","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Remove-AzureKeyVaultManagedStorageAccount' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Remove-AzureKeyVaultManagedStorageAccount'."
 "Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.RemoveAzureKeyVaultSasDefinition","Remove-AzureKeyVaultManagedStorageSasDefinition","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Remove-AzureKeyVaultManagedStorageSasDefinition' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Remove-AzureKeyVaultManagedStorageSasDefinition'."