Skip to content

Commit 7a97f9b

Browse files
committed
Merge branch 'UpdateCmdlets3' into UpdateCmdlets4
2 parents e84ecfe + 6600231 commit 7a97f9b

File tree

8 files changed

+28
-11
lines changed

8 files changed

+28
-11
lines changed

src/ServiceManagement/RemoteApp/Commands.RemoteApp/Collection/UpdateAzureRemoteAppCollection.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,8 @@ public class UpdateAzureRemoteAppCollection : RdsCmdlet
3535
ValueFromPipelineByPropertyName = true,
3636
HelpMessage = "The name of the RemoteApp template image."
3737
)]
38-
[ValidatePattern(TemplateImageNameValidatorString)]
3938
public string ImageName { get; set; }
4039

41-
[Parameter(Mandatory = false,
42-
HelpMessage = "Immediately log off users after update has successfully completed")]
43-
public SwitchParameter ForceLogoffWhenUpdateComplete { get; set; }
44-
4540
public override void ExecuteCmdlet()
4641
{
4742
CollectionCreationDetails details = null;

src/ServiceManagement/RemoteApp/Commands.RemoteApp/Commands.RemoteApp.Designer.cs

Lines changed: 19 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ServiceManagement/RemoteApp/Commands.RemoteApp/Commands.RemoteApp.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<root>
33
<!--
44
Microsoft ResX Schema
5-
5+
66
Version 2.0
77
88
The primary goals of this format is to allow a simple XML format
@@ -232,7 +232,7 @@
232232
<value>Publish RemoteApp</value>
233233
</data>
234234
<data name="Publishing" xml:space="preserve">
235-
<value>Publishing Application use Get-Job to view status</value>
235+
<value>Publishing application; use Get-Job to view status</value>
236236
</data>
237237
<data name="UpdateCollection" xml:space="preserve">
238238
<value>Update collection</value>

src/ServiceManagement/RemoteApp/Commands.RemoteApp/Common/RemoteAppRegEx.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ public abstract partial class RdsCmdlet
3030

3131
protected const string UserPrincipalValdatorString = UserNameValidatorString + "@" + DomainNameValidatorString;
3232

33-
protected const string TemplateImageNameValidatorString = @"^[()A-Za-z][() ._\-A-Za-z0-9]{1,61}[A-Z-a-z0-9()]$";
33+
protected const string ListTemplateImageNameValidatorString = @"^[()A-Za-z][() ._\-A-Za-z0-9]{1,61}[A-Z-a-z0-9()]$";
34+
35+
protected const string TemplateImageNameValidatorString = @"^[A-Za-z][ ._\-A-Za-z0-9]{1,61}[A-Z-a-z0-9]$";
3436

3537
protected const string IPv4ValidatorString = @"^(?:(?:25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])\.){3}(?:25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])$";
3638

src/ServiceManagement/RemoteApp/Commands.RemoteApp/TemplateImage/GetAzureRemoteAppTemplateImage.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class GetAzureRemoteAppTemplateImage : GoldImage
2727
Position = 0,
2828
ValueFromPipeline = true,
2929
HelpMessage = "Template image name. Wildcards are permitted.")]
30-
[ValidateNotNullOrEmpty()]
30+
[ValidatePattern(ListTemplateImageNameValidatorString)]
3131
public string ImageName { get; set; }
3232

3333
private bool showAllImages = false;

src/ServiceManagement/RemoteApp/Commands.RemoteApp/TemplateImage/NewAzureRemoteAppTemplateImage.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public class NewAzureRemoteAppTemplateImage : GoldImage
4343
Position = 0,
4444
ValueFromPipeline = true,
4545
HelpMessage = "Template image name")]
46+
[ValidatePattern(TemplateImageNameValidatorString)]
4647
public string ImageName { get; set; }
4748

4849
[Parameter(Mandatory = true,

src/ServiceManagement/RemoteApp/Commands.RemoteApp/TemplateImage/RemoveAzureRemoteAppTemplateImage.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class RemoveAzureRemoteAppTemplateImage : GoldImage
2727
Position = 0,
2828
ValueFromPipeline = true,
2929
HelpMessage = "Template image name")]
30-
30+
[ValidatePattern(TemplateImageNameValidatorString)]
3131
public string ImageName { get; set; }
3232

3333
public override void ExecuteCmdlet()

src/ServiceManagement/RemoteApp/Commands.RemoteApp/TemplateImage/RenameAzureRemoteAppTemplateImage.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public class RenameAzureRemoteAppTemplateImage : GoldImage
2727
Position = 0,
2828
ValueFromPipeline = true,
2929
HelpMessage = "Template image name")]
30+
[ValidatePattern(TemplateImageNameValidatorString)]
3031
public string ImageName { get; set; }
3132

3233
[Parameter(Mandatory = true,

0 commit comments

Comments
 (0)