Addressed PR comments

1. Removed mstest tests
2. Move exception string to resource
3. Remove an else

Author: felixcho-work

src/ResourceManager/Automation/Commands.Automation.Test/UnitTests/NewAzureAutomationRunbookTest.cs

@@ -14,7 +14,6 @@
 
 using Microsoft.Azure.Commands.Automation.Cmdlet;
 using Microsoft.Azure.Commands.Automation.Common;
-using Microsoft.Azure.Management.Automation.Models;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using Microsoft.WindowsAzure.Commands.Common.Test.Mocks;
 using Microsoft.WindowsAzure.Commands.Test.Utilities.Common;
@@ -70,47 +69,5 @@ public void NewAzureAutomationRunbookByNameSuccessful()
             // Assert
             this.mockAutomationClient.Verify(f => f.CreateRunbookByName(resourceGroupName, accountName, runbookName, description, tags, null, null, null, false), Times.Once());
         }
-
-        [TestMethod]
-        public void NewAzureAutomationRunbookTypeValueDifferentFromSdk()
-        {
-            string resourceGroupName = "resourceGroup";
-            string accountName = "automation";
-            string runbookName = "runbook";
-            string type = "GraphicalPowerShell";
-
-            this.mockAutomationClient.Setup(
-                f => f.CreateRunbookByName(resourceGroupName, accountName, runbookName, null, null, RunbookTypeEnum.GraphPowerShell, null, null, false));
-
-            this.cmdlet.ResourceGroupName = resourceGroupName;
-            this.cmdlet.AutomationAccountName = accountName;
-            this.cmdlet.Name = runbookName;
-            this.cmdlet.Type = type;
-            this.cmdlet.SetParameterSet("ByRunbookName");
-            this.cmdlet.ExecuteCmdlet();
-
-            this.mockAutomationClient.Verify(f => f.CreateRunbookByName(resourceGroupName, accountName, runbookName, null, null, RunbookTypeEnum.GraphPowerShell, null, null, false), Times.Once());
-        }
-
-        [TestMethod]
-        public void NewAzureAutomationRunbookTypeValueSameAsSdk()
-        {
-            string resourceGroupName = "resourceGroup";
-            string accountName = "automation";
-            string runbookName = "runbook";
-            string type = "PowerShellWorkflow";
-
-            this.mockAutomationClient.Setup(
-                f => f.CreateRunbookByName(resourceGroupName, accountName, runbookName, null, null, RunbookTypeEnum.PowerShellWorkflow, null, null, false));
-
-            this.cmdlet.ResourceGroupName = resourceGroupName;
-            this.cmdlet.AutomationAccountName = accountName;
-            this.cmdlet.Name = runbookName;
-            this.cmdlet.Type = type;
-            this.cmdlet.SetParameterSet("ByRunbookName");
-            this.cmdlet.ExecuteCmdlet();
-
-            this.mockAutomationClient.Verify(f => f.CreateRunbookByName(resourceGroupName, accountName, runbookName, null, null, RunbookTypeEnum.PowerShellWorkflow, null, null, false), Times.Once());
-        }
     }
 }

src/ResourceManager/Automation/Commands.Automation/Cmdlet/NewAzureAutomationSchedule.cs

@@ -19,6 +19,7 @@
 using System.Security.Permissions;
 using Microsoft.Azure.Commands.Automation.Common;
 using Microsoft.Azure.Commands.Automation.Model;
+using Microsoft.Azure.Commands.Automation.Properties;
 using DayOfWeek = Microsoft.Azure.Commands.Automation.Model.DayOfWeek;
 
 namespace Microsoft.Azure.Commands.Automation.Cmdlet
@@ -192,7 +193,7 @@ private Schedule CreateMonthlyScheduleModel()
             var dayOfWeek = this.DayOfWeek.HasValue ? this.DayOfWeek.ToString() : null;
             if ((!string.IsNullOrWhiteSpace(dayOfWeek) && this.DayOfWeekOccurrence == 0) || (string.IsNullOrWhiteSpace(dayOfWeek) && this.DayOfWeekOccurrence != 0))
             {
-                throw new Exception("for monthly occurrence, both day of week and occurrence need to be specified");
+                throw new ArgumentException(Resources.MonthlyScheduleNeedsDayOfWeekAndOccurrence);
             }
 
             var newSchedule = new Schedule

src/ResourceManager/Automation/Commands.Automation/Common/RunbookTypeSdkValue.cs

@@ -29,10 +29,8 @@ public static string Resolve(string commandValue)
             {
                 return RunbookTypeEnum.GraphPowerShellWorkflow;
             }
-            else
-            {
-                return commandValue;
-            }
+
+            return commandValue;
         }
     }
 }

src/ResourceManager/Automation/Commands.Automation/Properties/Resources.Designer.cs

@@ -439,4 +439,8 @@
   <data name="JobTerminalState" xml:space="preserve">
     <value>"Job terminal state : Id {0}, state {1}, time {2}"</value>
   </data>
+  <data name="MonthlyScheduleNeedsDayOfWeekAndOccurrence" xml:space="preserve">
+    <value>For monthly occurrence, both day of week and occurrence need to be specified.</value>
+    <comment>Automation</comment>
+  </data>
 </root>