Fix the following issues:

1. Null exception issue for Get-AzRemoteDesktopFile
2. UltraSSD issue for New-AzVM and Update-AzVM
3. VHD seek stream issue

Author: hyonholee

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.cs

@@ -262,5 +262,12 @@ public void TestVirtualMachineStop()
         {
             TestRunner.RunTestScript("Test-VirtualMachineStop");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestVirtualMachineRemoteDesktop()
+        {
+            TestRunner.RunTestScript("Test-VirtualMachineRemoteDesktop");
+        }
     }
 }

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.ps1

@@ -3632,3 +3632,83 @@ function Test-VirtualMachineStop
         Clean-ResourceGroup $rgname
     }
 }
+
+<#
+.SYNOPSIS
+Test Virtual Machine Managed Disk
+#>
+function Test-VirtualMachineRemoteDesktop
+{
+    # Setup
+    $rgname = Get-ComputeTestResourceName
+
+    try
+    {
+        $loc = Get-ComputeVMLocation;
+        New-AzResourceGroup -Name $rgname -Location $loc -Force;
+
+        # VM Profile & Hardware
+        $vmsize = 'Standard_DS2_v2';
+        $vmname = 'vm' + $rgname;
+
+        $p = New-AzVMConfig -VMName $vmname -VMSize $vmsize -EnableUltraSSD -Zone "1";
+
+        # NRP
+        $subnet = New-AzVirtualNetworkSubnetConfig -Name ('subnet' + $rgname) -AddressPrefix "10.0.0.0/24";
+        $vnet = New-AzVirtualNetwork -Force -Name ('vnet' + $rgname) -ResourceGroupName $rgname -Location $loc -AddressPrefix "10.0.0.0/16" -Subnet $subnet;
+        $vnet = Get-AzVirtualNetwork -Name ('vnet' + $rgname) -ResourceGroupName $rgname;
+        $subnetId = $vnet.Subnets[0].Id;
+        $nic = New-AzNetworkInterface -Force -Name ('nic' + $rgname) -ResourceGroupName $rgname -Location $loc -SubnetId $subnetId
+        $nic = Get-AzNetworkInterface -Name ('nic' + $rgname) -ResourceGroupName $rgname;
+        $nicId = $nic.Id;
+
+        $p = Add-AzVMNetworkInterface -VM $p -Id $nicId;
+
+        # OS & Image
+        $user = "Foo2";
+        $password = $PLACEHOLDER;
+        $securePassword = ConvertTo-SecureString $password -AsPlainText -Force;
+        $cred = New-Object System.Management.Automation.PSCredential ($user, $securePassword);
+        $computerName = 'test';
+
+        $p = Set-AzVMOperatingSystem -VM $p -Windows -ComputerName $computerName -Credential $cred;
+
+        $imgRef = Get-DefaultCRPImage -loc $loc;
+        $p = ($imgRef | Set-AzVMSourceImage -VM $p);
+
+        # Virtual Machine
+        Assert-ThrowsContains { `
+            New-AzVM -ResourceGroupName $rgname -Location $loc -VM $p; } `
+            "'Microsoft.Compute/UltraSSD' feature is not enabled for this subscription.";
+
+        $p.AdditionalCapabilities.UltraSSDEnabled = $false;
+        New-AzVM -ResourceGroupName $rgname -Location $loc -VM $p;
+
+        # Get VM
+        $vm = Get-AzVM -ResourceGroupName $rgname -Name $vmname;
+        Assert-False {$vm.AdditionalCapabilities.UltraSSDEnabled};
+        $vmstate = Get-AzVM -ResourceGroupName $rgname -Name $vmname -Status;
+
+        Assert-ThrowsContains { `
+            Get-AzRemoteDesktopFile -ResourceGroupName $rgname -Name $vmname -LocalPath ".\file.rdp"; } `
+            "The RDP file cannot be generated because the network interface of the virtual machine does not reference a PublicIP or an InboundNatRule of a public load balancer.";
+
+        $pubip = New-AzPublicIpAddress -Force -Name ('pubip' + $rgname) -ResourceGroupName $rgname -Location $loc -Zone "1" -Sku "Standard" -AllocationMethod "Static" -DomainNameLabel ('pubip' + $rgname);
+        $pubip = Get-AzPublicIpAddress -Name ('pubip' + $rgname) -ResourceGroupName $rgname;
+        $pubipId = $pubip.Id;
+
+        $nic = Get-AzNetworkInterface -Name ('nic' + $rgname) -ResourceGroupName $rgname;
+        $nic | Set-AzNetworkInterfaceIpConfig -Name 'ipconfig1' -SubnetId $subnetId -PublicIpAddressId $pubip.Id | Set-AzNetworkInterface;
+
+        # Get VM
+        $vm = Get-AzVM -ResourceGroupName $rgname -Name $vmname;
+        $vmstate = Get-AzVM -ResourceGroupName $rgname -Name $vmname -Status;
+
+        Get-AzRemoteDesktopFile -ResourceGroupName $rgname -Name $vmname -LocalPath ".\file.rdp";
+    }
+    finally
+    {
+        # Cleanup
+        Clean-ResourceGroup $rgname
+    }
+}

src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineTests/TestVirtualMachineRemoteDesktop.json

@@ -19,6 +19,9 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fix the null exception for Get-AzRemoteDesktopFile.
+* Fix VHD Seek method for end-relative position.
+* Fix UltraSSD issue for New-AzVM and Update-AzVM.
 
 ## Version 2.5.0
 * Add VmssId to New-AzVMConfig cmdlet

src/Compute/Compute/ChangeLog.md

@@ -106,7 +106,7 @@ public override void ExecuteCmdlet()
                     // Get PublicIPAddress resource if present
                     address = this.GetAddressFromPublicIPResource(nic.IpConfigurations.First().PublicIPAddress.Id);
                 }
-                else if (nic.IpConfigurations.First().LoadBalancerInboundNatRules.Any())
+                else if (nic.IpConfigurations.First().LoadBalancerInboundNatRules !=  null && nic.IpConfigurations.First().LoadBalancerInboundNatRules.Any())
                 {
                     address = string.Empty;
 

src/Compute/Compute/RemoteDesktop/GetAzureRemoteDesktopFileCommand.cs

@@ -224,7 +224,7 @@ public override long Seek(long offset, SeekOrigin origin)
                     this.Position += offset;
                     break;
                 case SeekOrigin.End:
-                    this.Position -= offset;
+                    this.Position = this.Length + offset;
                     break;
                 default:
                     throw new NotSupportedException();

src/Compute/Compute/VhdManagement/VirtualDiskStream.cs

@@ -535,7 +535,8 @@ public void DefaultExecuteCmdlet()
                         Zones = this.Zone ?? this.VM.Zones,
                         ProximityPlacementGroup = this.VM.ProximityPlacementGroup,
                         Host = this.VM.Host,
-                        VirtualMachineScaleSet = this.VM.VirtualMachineScaleSet
+                        VirtualMachineScaleSet = this.VM.VirtualMachineScaleSet,
+                        AdditionalCapabilities = this.VM.AdditionalCapabilities
                     };
 
                     Dictionary<string, List<string>> auxAuthHeader = null;

src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

@@ -139,7 +139,8 @@ public override void ExecuteCmdlet()
                         Zones = (this.VM.Zones != null && this.VM.Zones.Count > 0) ? this.VM.Zones : null,
                         ProximityPlacementGroup = this.VM.ProximityPlacementGroup,
                         Host = this.VM.Host,
-                        VirtualMachineScaleSet = this.VM.VirtualMachineScaleSet                    
+                        VirtualMachineScaleSet = this.VM.VirtualMachineScaleSet,
+                        AdditionalCapabilities = this.VM.AdditionalCapabilities
                     };
 
                     if (this.IsParameterBound(c => c.IdentityType))