Refresh Service Fabric cmdlets

  - Updated ARM templates
  - Failed operations no longer rollback
  - Add-AzureRmServiceFabricNodeType
    - VMs default to managed disks
    - Existing VMSS subnet used
    - All operations are idempotent
  - Remove-AzureRmServiceFabricNodeType cleans up partially created VMSS and/or cluster node types
  - Added new unit tests
    - Test-NewAzureRmServiceFabricCluster
    - Test-AddAzureRmServiceFabricNode
    - Test-RemoveAzureRmServiceFabricNode
    - Test-RemoveAzureRmServiceFabricNodeType
  - Updated Test-UpdateAzureRmServiceFabricReliability to test Silver to Bronze reliability downgrade
  - Updated Test-UpdateAzureRmServiceFabricDurability to test Bronze to Silver durability upgrade
  - Fixed output of PSCluster object for complex property types
  - Updated to Microsoft.Azure.Management.Compute.17.3.0
  - Updated to Microsoft.Rest.ClientRuntime.Azure.TestFramework.1.7.2
  - Updated to Microsoft.Azure.Management.Network.15.1.0-preview
  - Created resource strings for exception messages
  - Moved test VM image to Windows Server 2016 with Containers
  - Cleaned up duplicate references in unit test project
  - Isolated SFRP client calls
  - Removed redundant cluster read operations

Author: juhacket

src/ResourceManager/ServiceFabric/ChangeLog.md

@@ -18,6 +18,15 @@
         - Additional information about change #1
 -->
 ## Current Release
+* Service Fabric cmdlet refresh
+  - Updated ARM templates
+  - Failed operations no longer rollback
+  - Add-AzureRmServiceFabricNodeType
+    - VMs default to managed disks
+    - Existing VMSS subnet used
+    - All operations are idempotent
+  - Remove-AzureRmServiceFabricNodeType cleans up partially created VMSS and/or cluster node types
+  - Fixed output of PSCluster object for complex property types
 
 ## Version 0.3.1
 * Added Location Completer to -Location parameters allowing tab completion through valid Locations

src/ResourceManager/ServiceFabric/Commands.ServiceFabric.Test/Commands.ServiceFabric.Test.csproj

@@ -1,12 +1,12 @@
 {
-  "$schema": "http://schema.management.azure.com/schemas/2015-01-01/deploymentParameters.json#",
+  "$schema": "http://schema.management.azure.com/schemas/2015-01-01/deploymentParameters.json",
   "contentVersion": "1.0.0.0",
   "parameters": {
     "clusterLocation": {
-      "value": "southcentralus"
+      "value": "westus"
     },
     "clusterName": {
-      "value": "newcreatedps1cluster"
+      "value": "azurermsfcluster2"
     },
     "adminUserName": {
       "value": "username"
@@ -21,7 +21,7 @@
       "value": "WindowsServer"
     },
     "vmImageSku": {
-      "value": "2012-R2-Datacenter"
+      "value": "2016-Datacenter-with-Containers"
     },
     "vmImageVersion": {
       "value": "latest"
@@ -32,20 +32,20 @@
     "loadBalancedAppPort2": {
       "value": 8081
     },
+    "clusterProtectionLevel": {
+      "value": "EncryptAndSign"
+    },
     "certificateStorevalue": {
       "value": "My"
     },
     "certificateThumbprint": {
-      "value": "99912345o458045827c723047234"
+      "value": "GEN-CUSTOM-DOMAIN-SSLCERT-THUMBPRINT"
     },
     "sourceVaultvalue": {
-      "value": "/subscriptions/<Sub ID>/resourceGroups/<Resource group name>/providers/Microsoft.KeyVault/vaults/<vault name>"
+      "value": "GEN-KEYVAULT-RESOURCE-ID"
     },
     "certificateUrlvalue": {
-      "value": "https://<name of the vault>.vault.azure.net:443/secrets/<exact location>"
-    },
-    "clusterProtectionLevel": {
-      "value": "EncryptAndSign"
+      "value": "GEN-KEYVAULT-SSL-SECRET-URI"
     },
     "storageAccountType": {
       "value": "Standard_LRS"
@@ -58,6 +58,9 @@
     },
     "nt0InstanceCount": {
       "value": 5
+    },
+    "vmNodeType0Size": {
+      "value": "Standard_D2_V2"
     }
   }
 }