Skip to content

Commit 848cf83

Browse files
committed
Responding to review feedback on websites changes
1 parent 05fc7f0 commit 848cf83

File tree

5 files changed

+6
-7
lines changed

5 files changed

+6
-7
lines changed

src/ResourceManager/Websites/AzureRM.Websites.psd1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# RootModule = ''
1313

1414
# Version number of this module.
15-
ModuleVersion = '5.0.0'
15+
ModuleVersion = '4.2.2'
1616

1717
# Supported PSEditions
1818
# CompatiblePSEditions = @()
@@ -141,7 +141,7 @@ PrivateData = @{
141141
# External dependent modules of this module
142142
# ExternalModuleDependencies = @()
143143

144-
Prerelease = 'preview'
144+
# Prerelease = ''
145145

146146
} # End of PSData hashtable
147147

src/ResourceManager/Websites/ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
-->
2020
## Current Release
2121
* Set minimum dependency of module to PowerShell 5.0
22+
* Upgrade to latest version of the Websites SDK
23+
* Added -AssignIdentity & -Httpsonly properties for SetAzureWebApp
2224

2325
## Version 4.2.2
2426
* Updated to the latest version of the Azure ClientRuntime

src/ResourceManager/Websites/Commands.Websites.Test/Commands.Websites.Test.csproj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,6 @@
8383
<SpecificVersion>False</SpecificVersion>
8484
<HintPath>..\..\..\packages\Microsoft.IdentityModel.Clients.ActiveDirectory.2.28.3\lib\net45\Microsoft.IdentityModel.Clients.ActiveDirectory.WindowsForms.dll</HintPath>
8585
</Reference>
86-
<Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
87-
<HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.10\lib\net452\Microsoft.Rest.ClientRuntime.dll</HintPath>
88-
</Reference>
8986
<Reference Include="Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
9087
<HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.3.3.10\lib\net452\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath>
9188
</Reference>
@@ -309,5 +306,7 @@
309306
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
310307
</ItemGroup>
311308
<ItemGroup />
309+
<Import Project="..\..\..\packages\Microsoft.Bcl.Build.1.0.14\tools\Microsoft.Bcl.Build.targets" Condition="Exists('..\..\..\packages\Microsoft.Bcl.Build.1.0.14\tools\Microsoft.Bcl.Build.targets')" />
310+
<Import Project="..\..\..\..\tools\Common.Dependencies.Test.targets" />
312311
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
313312
</Project>

src/ResourceManager/Websites/Commands.Websites.Test/packages.config

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
<package id="Microsoft.Bcl.Build" version="1.0.14" targetFramework="net45" />
1515
<package id="Microsoft.IdentityModel.Clients.ActiveDirectory" version="2.28.3" targetFramework="net45" />
1616
<package id="Microsoft.Net.Http" version="2.2.29" targetFramework="net45" />
17-
<package id="Microsoft.Rest.ClientRuntime" version="2.3.10" targetFramework="net452" />
1817
<package id="Microsoft.Rest.ClientRuntime.Azure" version="3.3.10" targetFramework="net452" />
1918
<package id="Microsoft.Rest.ClientRuntime.Azure.TestFramework" version="1.5.0-preview" targetFramework="net45" />
2019
<package id="Moq" version="4.2.1510.2205" targetFramework="net45" />

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1144,7 +1144,6 @@
11441144
"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.Automation.SetAzureRmVmssStorageProfileCommand","Set-AzureRmVmssStorageProfile","0","3030","The generic type for 'parameter ManagedDisk' has been changed from 'System.Nullable`1[Microsoft.Azure.Management.Compute.Models.StorageAccountTypes]' to 'System.Nullable`1[Microsoft.Azure.Commands.Compute.Models.PSStorageAccountTypes]'. ","Change the generic type for 'parameter ManagedDisk' back to 'System.Nullable`1[Microsoft.Azure.Management.Compute.Models.StorageAccountTypes]'."
11451145
"Microsoft.Azure.Commands.Subscription.dll","Microsoft.Azure.Commands.Subscription.Cmdlets.NewAzureRmSubscriptionDefinition","New-AzureRmSubscriptionDefinition","0","1000","The cmdlet 'New-AzureRmSubscriptionDefinition' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'New-AzureRmSubscriptionDefinition' back to the module, or add an alias to the original cmdlet name."
11461146
"Microsoft.Azure.Commands.Subscription.dll","Microsoft.Azure.Commands.Subscription.Cmdlets.GetAzureRmSubscriptionDefinition","Get-AzureRmSubscriptionDefinition","0","1000","The cmdlet 'Get-AzureRmSubscriptionDefinition' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'Get-AzureRmSubscriptionDefinition' back to the module, or add an alias to the original cmdlet name."
1147-
"Microsoft.Azure.Commands.Resources.dll","Microsoft.Azure.Commands.Resources.GetAzureRoleDefinitionCommand","Get-AzureRmRoleDefinition","0","2000","The cmdlet 'Get-AzureRmRoleDefinition' no longer supports the parameter 'AtScopeAndBelow' and no alias was found for the original parameter name.","Add the parameter 'AtScopeAndBelow' back to the cmdlet 'Get-AzureRmRoleDefinition', or add an alias to the original parameter name."
11481147
"Microsoft.Azure.Commands.Resources.dll","Microsoft.Azure.Commands.Resources.GetAzureRoleDefinitionCommand","Get-AzureRmRoleDefinition","0","1050","The parameter set 'RoleDefinitionNameParameterSet' for cmdlet 'Get-AzureRmRoleDefinition' has been removed.","Add parameter set 'RoleDefinitionNameParameterSet' back to cmdlet 'Get-AzureRmRoleDefinition'."
11491148
"Microsoft.Azure.Commands.Resources.dll","Microsoft.Azure.Commands.Resources.GetAzureRoleDefinitionCommand","Get-AzureRmRoleDefinition","0","1050","The parameter set 'RoleDefinitionCustomParameterSet' for cmdlet 'Get-AzureRmRoleDefinition' has been removed.","Add parameter set 'RoleDefinitionCustomParameterSet' back to cmdlet 'Get-AzureRmRoleDefinition'."
11501149
"Microsoft.Azure.Commands.ApiManagement.dll","Microsoft.Azure.Commands.ApiManagement.Commands.NewAzureApiManagement","New-AzureRmApiManagement","0","2010","The cmdlet 'New-AzureRmApiManagement' no longer supports the alias 'Tags' for parameter 'Tag'.","Add the alias 'Tags' back to parameter 'Tag'."

0 commit comments

Comments
 (0)