Extract common logic for Instance sku prefixes

Author: jaredmoo

src/Sql/Sql.Test/UnitTests/AzureSqlInstanceUnitTests.cs

@@ -0,0 +1,46 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using Microsoft.Azure.Commands.Sql.ElasticPool.Cmdlet;
+using Microsoft.Azure.Commands.Sql.Test.Utilities;
+using Microsoft.Azure.ServiceManagement.Common.Models;
+using Microsoft.WindowsAzure.Commands.ScenarioTest;
+using System;
+using Microsoft.Azure.Commands.Sql.ElasticPool.Services;
+using Microsoft.Azure.Commands.Sql.ManagedInstance.Adapter;
+using Xunit;
+using Xunit.Abstractions;
+
+namespace Microsoft.Azure.Commands.Sql.Test.UnitTests
+{
+    public class AzureSqlInstanceUnitTests
+    {
+        public AzureSqlInstanceUnitTests(ITestOutputHelper output)
+        {
+            XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
+        }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void GetInstanceSkuPrefix()
+        {
+            Assert.Equal(
+                "GP",
+                AzureSqlManagedInstanceAdapter.GetInstanceSkuPrefix("GeneralPurpose"));
+            Assert.Equal(
+                "BC",
+                AzureSqlManagedInstanceAdapter.GetInstanceSkuPrefix("BusinessCritical"));
+        }
+    }
+}

src/Sql/Sql/ManagedInstance/Cmdlet/NewAzureSqlManagedInstance.cs

@@ -22,6 +22,7 @@
 using System.Linq;
 using System.Management.Automation;
 using System.Security;
+using Microsoft.Azure.Commands.Sql.ManagedInstance.Adapter;
 
 namespace Microsoft.Azure.Commands.Sql.ManagedInstance.Cmdlet
 {
@@ -221,7 +222,7 @@ public override void ExecuteCmdlet()
             }
             else if (string.Equals(this.ParameterSetName, NewByEditionAndComputeGenerationParameterSet, System.StringComparison.OrdinalIgnoreCase))
             {
-                string editionShort = Edition.Equals(Constants.GeneralPurposeEdition) ? "GP" : Edition.Equals(Constants.BusinessCriticalEdition) ? "BC" : "Unknown";
+                string editionShort = AzureSqlManagedInstanceAdapter.GetInstanceSkuPrefix(Edition);
                 Sku.Name = editionShort + "_" + ComputeGeneration;
             }
 

src/Sql/Sql/ManagedInstance/Cmdlet/SetAzureSqlManagedInstance.cs

@@ -22,6 +22,7 @@
 using System.Security;
 using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
+using Microsoft.Azure.Commands.Sql.ManagedInstance.Adapter;
 using Microsoft.Azure.Commands.Sql.ManagedInstance.Model;
 
 namespace Microsoft.Azure.Commands.Sql.ManagedInstance.Cmdlet
@@ -172,7 +173,7 @@ public class SetAzureSqlManagedInstance : ManagedInstanceCmdletBase
             if (Edition != null)
             {
                 string computeGeneration = existingInstance.Sku.Name.Contains(Constants.ComputeGenerationGen4) ? Constants.ComputeGenerationGen4 : Constants.ComputeGenerationGen5;
-                string editionShort = Edition.Equals(Constants.GeneralPurposeEdition) ? "GP" : Edition.Equals(Constants.BusinessCriticalEdition) ? "BC" : "Unknown";
+                string editionShort = AzureSqlManagedInstanceAdapter.GetInstanceSkuPrefix(Edition);
                 Sku.Name = editionShort + "_" + computeGeneration;
                 Sku.Tier = Edition;
             }

src/Sql/Sql/ManagedInstance/Services/AzureSqlManagedInstanceAdapter.cs

@@ -22,6 +22,7 @@
 using System.Security.Permissions;
 using Microsoft.Azure.Commands.ResourceManager.Common.Tags;
 using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
+using Microsoft.Azure.Commands.Sql.Common;
 using Microsoft.WindowsAzure.Commands.Common;
 
 namespace Microsoft.Azure.Commands.Sql.ManagedInstance.Adapter
@@ -183,5 +184,23 @@ private static AzureSqlManagedInstanceModel CreateManagedInstanceModelFromRespon
 
             return managedInstance;
         }
+
+        /// <summary>
+        /// Get instance sku name based on edition
+        ///    Edition              | SkuName
+        ///    GeneralPurpose       | GP
+        ///    BusinessCritical     | BC
+        /// </summary>
+        /// <param name="tier">Azure Sql database edition</param>
+        /// <returns>The sku name</returns>
+        public static string GetInstanceSkuPrefix(string tier)
+        {
+            if (string.IsNullOrWhiteSpace(tier))
+            {
+                return null;
+            }
+
+            return SqlSkuUtils.GetVcoreSkuPrefix(tier) ?? "Unknown";
+        }
     }
 }