Merge branch 'master' of https://github.com/Azure/azure-powershell into jikma/adddataflow

Author: jackmagic313

.github/ISSUE_TEMPLATE/az-preview-bug-report.md

@@ -0,0 +1,66 @@
+---
+name:  Az 4.x preview bug report 
+about: Report errors or unexpected behaviors specifically for the Az 4.0  module in preview
+title: ''
+labels: 'Az 4.x Preview', 'Azure PS Team'
+assignees: ''
+---
+
+<!--
+
+- This issue is specifically for reporting issues related to the preview versions of the Az 4.0 PowerShell module
+- Please search the existing issues to see if there has been a similar issue filed
+- For issue related to importing a module, please refer to our troubleshooting guide:
+    - https://github.com/Azure/azure-powershell/blob/master/documentation/troubleshoot-module-load.md
+
+-->
+
+## Description
+
+
+
+## Steps to reproduce
+
+```powershell
+
+```
+
+## Environment data
+
+<!-- Please run $PSVersionTable and paste the output in the below code block -->
+
+```
+
+```
+
+## Module version
+
+<!-- Please run (Get-Module  -ListAvailable) and paste the output in the below code block -->
+
+```powershell
+
+```
+
+## Azure Profile
+
+<!-- Please indicate the selected Azure profile, if any -->
+
+```powershell
+
+```
+
+## Debug output
+
+<!-- Set $DebugPreference='Continue' before running the repro and paste the resulting debug stream in the below code block -->
+
+```
+
+```
+
+## Error output
+
+<!-- Please run Resolve-AzError and paste the output in the below code block -->
+
+```
+
+```

ChangeLog.md

@@ -1,3 +1,132 @@
+## 2.7.0 - September 2019
+#### Az.ApiManagement
+* Update '-Format' parameter description in 'Set-AzApiManagementPolicy' reference documentation
+* Removed references of deprecated cmdlet 'Update-AzApiManagementDeployment' from reference documentation. Use 'Set-AzApiManagement' instead.
+
+#### Az.Automation
+* Fixed example typo in reference documentation for 'Register-AzAutomationDscNode'
+* Added clarification on OS restriction to Register-AzAutomationDSCNode
+* Fixed Start-AzAutomationRunbook cmdlet Null reference exception for -Wait option.
+
+#### Az.Compute
+* Add UploadSizeInBytes parameter tp New-AzDiskConfig
+* Add Incremental parameter to New-AzSnapshotConfig
+* Add a low priority virtual machine feature:
+    - MaxPrice, EvictionPolicy and Priority parameters are added to New-AzVMConfig.
+    - MaxPrice parameter is added to New-AzVmssConfig, Update-AzVM and Update-AzVmss cmdlets.
+* Fix VM reference issue for Get-AzAvailabilitySet cmdlet when it lists all availability sets in the subscription.
+* Fix the null exception for Get-AzRemoteDesktopFile.
+* Fix VHD Seek method for end-relative position.
+* Fix UltraSSD issue for New-AzVM and Update-AzVM.
+
+#### Az.DataFactory
+* Adding 3 new commands for ADF V2 - Add-AzDataFactoryV2TriggerSubscription, Remove-AzDataFactoryV2TriggerSubscription, and Get-AzDataFactoryV2TriggerSubscriptionStatus
+* Updated ADF .Net SDK version to 4.1.3
+
+#### Az.HDInsight
+* Call out breaking changes
+
+#### Az.IotHub
+* Add support to invoke failover for an IotHub to the geo-paired disaster recovery region.
+* Add support to manage message enrichment for an IotHub. New cmdlets are:
+	- Add-AzIotHubMessageEnrichment
+	- Get-AzIotHubMessageEnrichment
+	- Remove-AzIotHubMessageEnrichment
+	- Set-AzIotHubMessageEnrichment
+
+#### Az.Monitor
+* Pointing to the most recent Monitor SDK, i.e. 0.24.1-preview
+   - Adds non-braking changes to the Metrics cmdlets, i.e. the Unit enumeration supports several new values. These are read-only cmdlets, so there would be no change in the input of the cmdlets.
+   - The api-version of the **ActionGroups** requests is now **2019-06-01**, before it was **2018-03-01**. The scenario tests have been updated to accommodate for this change.
+   - The constructors for the classes **EmailReceiver** and **WebhookReceiver** added one new mandatory argument, i.e. a Boolean value called **useCommonAlertSchema**. Currently, the value is fixed to **false** to hide this breaking change from the cmdlets. **NOTE**: this is a temporary change that must be validated by the Alerts team.
+   - The order of the arguments for the constructor of the class **Source** (related to the **ScheduledQueryRuleSource** class) changed from the previous SDK. This change required two unit tests to the be fixed: they compiled, but failed to pass the tests.
+   - The order of the arguments for the constructor of the class **AlertingAction** (related to the **ScheduledQueryRuleSource** class) changed from the previous SDK. This change required two unit tests to the be fixed: they compiled, but failed to pass the tests.
+* Support Dynamic Threshold criteria for metric alert V2
+	- New-AzMetricAlertRuleV2Criteria: now creats dynamic threshold criteria also
+	- Add-AzMetricAlertRuleV2: now accept dynamic threshold criteria also
+* Improvements in Scheduled Query Rule cmdlets (SQR)
+ - Cmdlets will accept 'Location' paramater in both formats, either the location (e.g. eastus) or the location display name (e.g. East US)
+ - Illustrated 'Enabled' parameter in help files properly
+ - Added examples for 'ActionGroup' optional parameter
+ - Overall improved help files
+* Fix bug in determining scope type for 'Set-AzActionRule'
+
+#### Az.Network
+* Fix incorrect example in 'New-AzApplicationGateway' reference documentation 
+* Add note in 'Get-AzNetworkWatcherPacketCapture' reference documentation about retrieving all properties for a packet capture
+* Fixed example in 'Test-AzNetworkWatcherIPFlow' reference documentation to correctly enumerate NICs
+* Improved cloud exception parsing to display additional details if they are present
+* Improved cloud exception parsing to handle additional type of SDK exception
+* Fixed incorrect mapping of Security Rule models
+* Added properties to network interface for private ip feature
+    - Added property 'PrivateEndpoint' as type of PSResourceId to PSNetworkInterface
+    - Added property 'PrivateLinkConnectionProperties' as type of PSIpConfigurationConnectivityInformation to PSNetworkInterfaceIPConfiguration
+    - Added new model class PSIpConfigurationConnectivityInformation
+* Added new ApplicationRuleProtocolType 'mssql' for Azure Firewall resource
+* MultiLink support in Virtual WAN
+    - New cmdlets
+        - New-AzVpnSiteLink
+        - New-AzVpnSiteLinkConnection
+    - Updated cmdlet:
+        - New-VpnSite
+        - Update-VpnSite
+        - New-VpnConnection
+        - Update-VpnConnection
+* Fixed documents for some PowerShell examples to use Az cmdlets instead of AzureRM cmdlets
+
+#### Az.RecoveryServices
+* Update AzureVMpolicy Object with ProtectedItemsCount Attribute
+* Added Tests for VM policy and Original Storage Account Restore
+
+#### Az.Resources
+* Fix bug where New-AzRoleAssignment could not be called without parameter Scope.
+
+#### Az.ServiceFabric
+* Fixed typo in example for 'Update-AzServiceFabricReliability' reference documentation
+* Adding new cmdlets to manage appliaction and services:
+    - New-AzServiceFabricApplication
+    - New-AzServiceFabricApplicationType
+    - New-AzServiceFabricApplicationTypeVersion
+    - New-AzServiceFabricService
+    - Update-AzServiceFabricApplication
+    - Get-AzServiceFabricApplication
+    - Get-AzServiceFabricApplicationType
+    - Get-AzServiceFabricApplicationTypeVersion
+    - Get-AzServiceFabricService
+    - Remove-AzServiceFabricApplication
+    - Remove-AzServiceFabricApplicationType
+    - Remove-AzServiceFabricApplicationTypeVersion
+    - Remove-AzServiceFabricServic
+* Upgraded Service Fabric SDK to version 1.2.0 which uses service fabric resource provider api-version 2019-03-01.
+
+#### Az.SignalR
+* Add Update, Restart, CheckNameAvailability, GetUsage Cmdlets
+
+#### Az.Sql
+* Update example in reference documentation for 'Get-AzSqlElasticPool'
+* Added vCore example to creating an elastic pool (New-AzSqlElasticPool).
+* Remove the validation of EmailAddresses and the check that EmailAdmins is not false in case EmailAddresses is empty in Set-AzSqlServerAdvancedThreatProtectionPolicy and Set-AzSqlDatabaseAdvancedThreatProtectionPolicy
+* Enabled removal of server/database auditing settings when multiple diagnostic settings that enable audit category exist.
+* Fix email addresses validation in multiple Sql Vulnerability Assessment cmdlets (Update-AzSqlDatabaseVulnerabilityAssessmentSetting, Update-AzSqlServerVulnerabilityAssessmentSetting, Update-AzSqlInstanceDatabaseVulnerabilityAssessmentSetting and Update-AzSqlInstanceVulnerabilityAssessmentSetting).
+
+#### Az.Storage
+* Updated example in reference documentation for 'Get-AzStorageAccountKey'
+* In upload/Downalod Azure File,support perserve the source File SMB properties (File Attributtes, File Creation Time, File Last Write Time) in the destination file
+    -  Set-AzStorageFileContent
+    -  Get-AzStorageFileContent
+* Fix Upload block blob with properties/metadate fail on container enabled ImmutabilityPolicy.
+    -  Set-AzStorageBlobContent
+* Support manage Azure File shares with Management plane API
+    -  New-AzRmStorageShare
+    -  Get-AzRmStorageShare
+    -  Update-AzRmStorageShare
+    -  Remove-AzRmStorageShare
+
+#### Az.Websites
+* Fixing issue where webapp Tags were getting deleted when migrating App to new ASPwhere webapp Tags were getting deleted when migrating App to new ASP
+* Fixing the Publish-AzureWebapp to work across Linux and windows
+* Update example in 'Get-AzWebAppPublishingProfile' reference documentation
+
 ## 2.6.0 - August 2019
 #### General
 * Fixed miscellaneous typos across numerous modules

src/Accounts/Accounts/Az.Accounts.psd1

@@ -12,7 +12,7 @@
 # RootModule = ''
 
 # Version number of this module.
-ModuleVersion = '1.6.2'
+ModuleVersion = '1.6.3'
 
 # Supported PSEditions
 CompatiblePSEditions = 'Core', 'Desktop'

src/Accounts/Accounts/ChangeLog.md

@@ -19,6 +19,9 @@
 -->
 ## Upcoming Release
 
+## Version 1.6.3
+* Update telemetry and url rewriting for generated modules, fix windows unit tests.
+
 ## Version 1.6.2
 * Fixed miscellaneous typos across module
 * Support user-assigned MSI in Azure Functions Authentication (#9479)

src/Accounts/Accounts/CommonModule/EnvironmentExtensions.cs

@@ -237,8 +237,8 @@ internal static Uri PatchHost(this Uri baseUri, string newBase)
             if (baseUri.IsAbsoluteUri)
             {
                 output.Path = output.Uri.AppendPathRemoveDuplicates(baseUri.AbsolutePath);
-                output.Query = baseUri.Query;
-                output.Fragment = baseUri.Fragment;
+                output.Query = baseUri.Query?.TrimStart('?');
+                output.Fragment = baseUri.Fragment?.TrimStart('#');
                 return output.Uri;
             }
 

src/Accounts/Accounts/CommonModule/TelemetryProvider.cs

@@ -139,9 +139,11 @@ public virtual AzurePSQoSEvent CreateQosEvent(InvocationInfo invocationInfo, str
                 SessionId = correlationId,
                 ParameterSetName = parameterSetName,
                 InvocationName = invocationInfo?.InvocationName,
-                InputFromPipeline = invocationInfo?.PipelineLength > 0,
+                InputFromPipeline = invocationInfo?.PipelineLength > 0
             };
 
+            data.CustomProperties.Add("PSPreviewVersion", "4.0.0");
+
             if (invocationInfo != null)
             {
                 data.Parameters = string.Join(",", invocationInfo?.BoundParameters?.Keys?.ToArray());

src/Accounts/Accounts/CommonModule/UniqueId.cs

@@ -16,9 +16,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using System.Net.Http;
-using Microsoft.Azure.Commands.Common.Authentication;
-using System.Net.Http.Headers;
-using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.Common
 {
@@ -28,19 +25,12 @@ namespace Microsoft.Azure.Commands.Common
     /// <summary>
     /// Pipeline step for adding x-ms-unique-id header
     /// </summary>
-    public class UserAgent
+    public class UniqueId
     {
-        Version _version;
+        private static UniqueId _instance;
+        public static UniqueId Instance => UniqueId._instance ?? (UniqueId._instance = new UniqueId());
 
-        public UserAgent(InvocationInfo invocation)
-            : this(invocation?.MyCommand?.Module?.Version ?? new Version("1.0.0"))
-        {
-        }
-
-        public UserAgent(Version moduleVersion)
-        {
-            _version = moduleVersion;
-        }
+        private int count;
 
         /// <summary>
         /// Pipeline delegate to add a unique id header to an outgoing request
@@ -53,13 +43,8 @@ public UserAgent(Version moduleVersion)
         /// <returns>Amended pipeline for retrieving a response</returns>
         public Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken token, Action cancel, SignalDelegate signal, NextDelegate next)
         {
-            var userAgents = AzureSession.Instance?.ClientFactory?.UserAgents ?? new ProductInfoHeaderValue[] { new ProductInfoHeaderValue("AzurePowerShell", $"Az{_version.ToString()}") };
-            // add user agent haeaders
-
-            foreach (var userAgent in userAgents)
-            {
-                request.Headers.UserAgent.Add(userAgent);
-            }
+            // add a header...
+            request.Headers.Add("x-ms-unique-id", Interlocked.Increment(ref this.count).ToString());
 
             // continue with pipeline.
             return next(request, token, cancel, signal);

src/Accounts/Accounts/CommonModule/UserAgent.cs

@@ -16,6 +16,9 @@
 using System.Threading;
 using System.Threading.Tasks;
 using System.Net.Http;
+using Microsoft.Azure.Commands.Common.Authentication;
+using System.Net.Http.Headers;
+using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.Common
 {
@@ -25,12 +28,19 @@ namespace Microsoft.Azure.Commands.Common
     /// <summary>
     /// Pipeline step for adding x-ms-unique-id header
     /// </summary>
-    public class UniqueId
+    public class UserAgent
     {
-        private static UniqueId _instance;
-        public static UniqueId Instance => UniqueId._instance ?? (UniqueId._instance = new UniqueId());
+        Version _version;
 
-        private int count;
+        public UserAgent(InvocationInfo invocation)
+            : this(invocation?.MyCommand?.Module?.Version ?? new Version("1.0.0"))
+        {
+        }
+
+        public UserAgent(Version moduleVersion)
+        {
+            _version = moduleVersion;
+        }
 
         /// <summary>
         /// Pipeline delegate to add a unique id header to an outgoing request
@@ -43,8 +53,13 @@ public class UniqueId
         /// <returns>Amended pipeline for retrieving a response</returns>
         public Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken token, Action cancel, SignalDelegate signal, NextDelegate next)
         {
-            // add a header...
-            request.Headers.Add("x-ms-unique-id", Interlocked.Increment(ref this.count).ToString());
+            var userAgents = new ProductInfoHeaderValue[] { new ProductInfoHeaderValue("AzurePowerShell", $"Az4.0.0-preview") };
+            // add user agent haeaders
+
+            foreach (var userAgent in userAgents)
+            {
+                request.Headers.UserAgent.Add(userAgent);
+            }
 
             // continue with pipeline.
             return next(request, token, cancel, signal);

src/Accounts/Accounts/Properties/AssemblyInfo.cs

@@ -43,8 +43,8 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 
-[assembly: AssemblyVersion("1.6.2")]
-[assembly: AssemblyFileVersion("1.6.2")]
+[assembly: AssemblyVersion("1.6.3")]
+[assembly: AssemblyFileVersion("1.6.3")]
 #if !SIGN
 [assembly: InternalsVisibleTo("Microsoft.Azure.PowerShell.Cmdlets.Accounts.Test")]
 #endif

src/Advisor/Advisor/Az.Advisor.psd1

@@ -51,7 +51,7 @@ DotNetFrameworkVersion = '4.7.2'
 # ProcessorArchitecture = ''
 
 # Modules that must be imported into the global environment prior to importing this module
-RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.6.2'; })
+RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.6.3'; })
 
 # Assemblies that must be loaded prior to importing this module
 RequiredAssemblies = '.\Microsoft.Azure.Management.Advisor.dll'

src/Aks/Aks/Az.Aks.psd1

@@ -53,7 +53,7 @@ DotNetFrameworkVersion = '4.7.2'
 # ProcessorArchitecture = ''
 
 # Modules that must be imported into the global environment prior to importing this module
-RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.6.2'; })
+RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.6.3'; })
 
 # Assemblies that must be loaded prior to importing this module
 RequiredAssemblies = '.\YamlDotNet.dll', '.\AutoMapper.dll'

src/AlertsManagement/AlertsManagement/Az.AlertsManagement.psd1

@@ -53,7 +53,7 @@ DotNetFrameworkVersion = '4.7.2'
 # ProcessorArchitecture = ''
 
 # Modules that must be imported into the global environment prior to importing this module
-RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.6.2'; })
+RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.6.3'; })
 
 # Assemblies that must be loaded prior to importing this module
 RequiredAssemblies = '.\Microsoft.Azure.Management.AlertsManagement.dll'

src/AnalysisServices/AnalysisServices/Az.AnalysisServices.psd1

@@ -53,7 +53,7 @@ DotNetFrameworkVersion = '4.7.2'
 # ProcessorArchitecture = ''
 
 # Modules that must be imported into the global environment prior to importing this module
-RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.6.2'; })
+RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.6.3'; })
 
 # Assemblies that must be loaded prior to importing this module
 RequiredAssemblies = '.\Microsoft.Azure.Management.Analysis.dll'