String case match for data container names, MigrationPlanNoConfig parameter value change, convert MigrationPlanNoConfig message to warning

Author: sarav123

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/GetAzureStorSimpleLegacyVolumeContainerConfirmStatus.cs

@@ -42,7 +42,7 @@ public override void ExecuteCmdlet()
                     {
                         var legacyContainerNameList = LegacyContainerNames.ToList();
                         confirmStatus.ContainerConfirmStatus = confirmStatus.ContainerConfirmStatus.ToList().FindAll(
-                            status => legacyContainerNameList.Contains(status.CloudConfigurationName));
+                            status => legacyContainerNameList.Contains(status.CloudConfigurationName, StringComparer.OrdinalIgnoreCase));
                     }
                 }
 

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/GetAzureStorSimpleLegacyVolumeContainerMigrationPlan.cs

@@ -41,7 +41,7 @@ public override void ExecuteCmdlet()
                     var migrationPlanList = StorSimpleClient.GetAllMigrationPlan();
                     if (migrationPlanList.MigrationPlans.Count == 0)
                     {
-                        throw new ArgumentException(Resources.MigrationPlanNoConfigs);
+                        WriteWarning(Resources.MigrationPlanNoConfigs);
                     }
                     else
                     {
@@ -68,7 +68,7 @@ public override void ExecuteCmdlet()
                             var legacyContainerNamesList = LegacyContainerNames.ToList();
                             migrationPlan.MigrationPlanInfo =
                                 migrationPlan.MigrationPlanInfo.ToList().FindAll(
-                                    plan => legacyContainerNamesList.Contains(plan.DataContainerName));
+                                    plan => legacyContainerNamesList.Contains(plan.DataContainerName, StringComparer.OrdinalIgnoreCase));
                         }
 
                         var migrationPlanMsg = new MigrationPlanMsg(migrationPlan);

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/GetAzureStorSimpleLegacyVolumeContainerStatus.cs

@@ -41,9 +41,10 @@ public override void ExecuteCmdlet()
                     overallMigrationStatusList.MigrationDataContainerStatuses.ToList();
                 if (null != LegacyContainerNames && 0 < LegacyContainerNames.Length)
                 {
-                    List<string> containerNameList = LegacyContainerNames.ToList();
+
+                    var containerNameList = LegacyContainerNames.ToList();
                     migrationDataContainerStatusList = migrationDataContainerStatusList.ToList().FindAll(
-                        status => containerNameList.Contains(status.CloudConfigurationName));
+                        status => containerNameList.Contains(status.CloudConfigurationName, StringComparer.OrdinalIgnoreCase));
                 }
 
                 var migrationStatus = new DataContainerMigrationStatus(

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/ImportAzureStorSimpleLegacyVolumeContainer.cs

@@ -46,7 +46,7 @@ public override void ExecuteCmdlet()
             {
                 var importDataContainerRequest = new MigrationImportDataContainerRequest();
                 importDataContainerRequest.DataContainerNames = (null != LegacyContainerNames)
-                    ? new List<string>(LegacyContainerNames.ToList().Distinct())
+                    ? new List<string>(LegacyContainerNames.ToList().Distinct(StringComparer.OrdinalIgnoreCase))
                     : new List<string>();
                 importDataContainerRequest.ForceOnOtherDevice = Force.IsPresent;
                 importDataContainerRequest.SkipACRs = SkipACRs.IsPresent;

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/StartAzureStorSimpleLegacyVolumeContainerMigrationPlan.cs

@@ -40,7 +40,7 @@ public override void ExecuteCmdlet()
                 var startMigrationPlanRequest = new MigrationPlanStartRequest();
                 startMigrationPlanRequest.ConfigId = LegacyConfigId;
                 startMigrationPlanRequest.DataContainerNameList = (null != LegacyContainerNames)
-                    ? new List<string>(LegacyContainerNames.ToList().Distinct())
+                    ? new List<string>(LegacyContainerNames.ToList().Distinct(StringComparer.OrdinalIgnoreCase))
                     : new List<string>();
 
                 var status = StorSimpleClient.StartLegacyVolumeContainerMigrationPlan(startMigrationPlanRequest);

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs

@@ -566,7 +566,7 @@ a special character</value>
     <value>Import started. You can check the import status with Get-AzureStorSimpleLegacyVolumeContainerStatus cmdlet.</value>
   </data>
   <data name="MigrationPlanNoConfigs" xml:space="preserve">
-    <value>There are no configs on the resource.</value>
+    <value>No ConfigFile imported.</value>
   </data>
   <data name="MigrationPlanNotFound" xml:space="preserve">
     <value>No migration plan found corresponding to the LegacyConfigId.</value>