resolve review comments

Author: shleiAmy

src/Attestation/Attestation/Az.Attestation.psd1

@@ -53,7 +53,7 @@ DotNetFrameworkVersion = '4.7.2'
 # ProcessorArchitecture = ''
 
 # Modules that must be imported into the global environment prior to importing this module
-RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.5.2'; })
+RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.6.0'; })
 
 # Assemblies that must be loaded prior to importing this module
 RequiredAssemblies = '.\Microsoft.Azure.Management.Attestation.dll'

src/Attestation/Attestation/ChangeLog.md

@@ -18,7 +18,4 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
-
-## Version 0.1.1
-
 * General availability of `Az.Attestation` module

src/Attestation/Attestation/Commands/GetAzureAttestation.cs

@@ -48,6 +48,7 @@ public class GetAzureAttestation : AttestationManagementCmdletBase
         [Parameter(
             Position = 0,
             Mandatory = true,
+            ValueFromPipelineByPropertyName = true,
             ParameterSetName = ResourceGroupParameterSet,
             HelpMessage = "Specifies the name of the ResourceID associated with the attestation being queried")]
         [ResourceGroupCompleter()]

src/Attestation/Attestation/Commands/RemoveAzureAttestation.cs

@@ -80,8 +80,6 @@ public class RemoveAzureAttestation : AttestationManagementCmdletBase
         [ValidateNotNullOrEmpty()]
         public string ResourceGroupName { get; set; }
 
-        [Parameter(Mandatory = false, HelpMessage = "Run cmdlet in the background")]
-        public SwitchParameter AsJob { get; set; }
 
         [Parameter(Mandatory = false,
             HelpMessage = "This Cmdlet does not return an object by default. If this switch is specified, it returns true if successful.")]
@@ -102,7 +100,7 @@ public override void ExecuteCmdlet()
                 ResourceGroupName = resourceIdentifier.ResourceGroupName;
             }
 
-            if (ShouldProcess(Name))
+            if (ShouldProcess(Name, "RemoveAttestation"))
             {
                 AttestationClient.DeleteAttestation(Name, ResourceGroupName);
 

src/Attestation/Attestation/help/Get-AzAttestation.md

@@ -99,7 +99,7 @@ Aliases:
 Required: True
 Position: 0
 Default value: None
-Accept pipeline input: False
+Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
@@ -108,7 +108,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
 
 ## INPUTS
 
-### None
+### System.String
 
 ## OUTPUTS
 

src/Attestation/Attestation/help/Remove-AzAttestation.md

@@ -20,14 +20,14 @@ Remove-AzAttestation [-Name] <String> [-ResourceGroupName] <String> [-AsJob] [-P
 
 ### ResourceIdByAvailableAttestation
 ```
-Remove-AzAttestation [-ResourceId] <String> [-AsJob] [-PassThru] [-DefaultProfile <IAzureContextContainer>]
- [-WhatIf] [-Confirm] [<CommonParameters>]
+Remove-AzAttestation [-ResourceId] <String> [-PassThru] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
+ [-Confirm] [<CommonParameters>]
 ```
 
 ### InputObjectByAvailableAttestation
 ```
-Remove-AzAttestation [-InputObject] <PSAttestation> [-AsJob] [-PassThru]
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
+Remove-AzAttestation [-InputObject] <PSAttestation> [-PassThru] [-DefaultProfile <IAzureContextContainer>]
+ [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ## DESCRIPTION