Fix for comments from PR

Author: rajsing

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceDetails/SetAzureStorSimpleVirtualDevice.cs

@@ -117,8 +117,8 @@ public override void ExecuteCmdlet()
         private void ValidateParams() {
             ValidateLength(AdministratorPassword, 8, 15, Resources.AdminPasswordLengthError);
             ValidateLength(SnapshotManagerPassword, 14, 15, Resources.SnapshotPasswordLengthError);
-            ValidatePasswordComplexity(AdministratorPassword);
-            ValidatePasswordComplexity(SnapshotManagerPassword);
+            ValidatePasswordComplexity(AdministratorPassword, "AdministratorPassword");
+            ValidatePasswordComplexity(SnapshotManagerPassword, "SnapshotManagerPassword");
         }
     }
 }

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs

@@ -514,7 +514,7 @@
     <value>Invalid value for Registration Key. CIK provided couldnt be used to decrypt the secrets! The exact exception while decrypting is "{0}"!</value>
   </data>
   <data name="PasswordCharacterCriteriaError" xml:space="preserve">
-    <value>The password must contain 3 of the following:
+    <value>{0} is not complex enough. It must contain 3 of the following:
 a lowercase character
 an uppercase character
 a number

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.resx

@@ -547,17 +547,19 @@ internal void ValidateLength(string data, uint minLength, uint maxLength, string
         /// conditions when the validation fails.
         /// </summary>
         /// <param name="data"></param>
-        internal void ValidatePasswordComplexity(string data)
+        internal void ValidatePasswordComplexity(string data, string passwordName)
         {
-            string errorMessage = Resources.PasswordCharacterCriteriaError;
+            string errorMessage = string.Format(Resources.PasswordCharacterCriteriaError, passwordName);
             var criteriaFulfilled = 0;
             // Regular expressions for lowercase letter, uppercase letter, digit and special char
             // respectively
             string[] criteriaRegexs = { ".*[a-z]", ".*[A-Z]", ".*\\d", ".*\\W" };
 
             foreach(var regexStr in criteriaRegexs){
-                var regex = new Regex(regexStr);
-                if(regex.IsMatch(data)){
+                // The static IsMatch method is supposed to use an Application-wide cache of compiled regexes
+                // and hence should save computation time (though not very significant because we are not doing tens of 
+                // thousands of such tests)
+                if(Regex.IsMatch(data, regexStr)){
                     criteriaFulfilled += 1;
                 }
             }